summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* [stable-only] Pin tox <49.1.1stable/zedBrian Rosmaita2023-01-052-0/+3
| | | | | | | | | | | | Continue to use tox 3 in the stable branches. Two changes: - .zuul.yaml: set the ensure_tox_version to use <4, which will tell zuul to install tox<4 if it's not present - tox.ini: set requires=tox<4 so that if tox has been installed already, our tox-based jobs will use tox 3 to run the tests Change-Id: Ica4c0a1d4f861e528ce8995766e82541dc710e0f
* Handle downgraded client for snapshot-createBrian Rosmaita2022-11-094-0/+100
| | | | | | | | | | | | | | | | | | | | When a CLI user specifies --os-volume api-version 3.66, the shell will execute the appropriate shell code, but if the server only supports < 3.66, the client is automatically downgraded and correctly uses the pre-3.66 SnapshotManager.create() method. In that case, the 'force' parameter, which is technically not allowed in mv 3.66 (but which silently accepts a True value for backward compatibility), will have a value of None, which the pre-3.66 code happily passes to cinder as '"force": null' in the request body, and which then fails the Block Storage API request-schema check. Handle this situation by detecting a None 'force' value and setting it to its pre-3.66 default value of False. Change-Id: I3ad8283c2a9aaac58c8d2b50fa7ac86b617e5dd3 Closes-bug: #1995883 (cherry picked from commit 9df653571d4da06c25222189be27e87a6da75628)
* Update TOX_CONSTRAINTS_FILE for stable/zedOpenStack Release Bot2022-09-091-4/+4
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/zed branch, tests will continue to use the upper-constraints list on master. Change-Id: I30316852d7ead5d3078e12c748a3ccdde2cf0601
* Update .gitreview for stable/zedOpenStack Release Bot2022-09-091-0/+1
| | | | Change-Id: I79a62ef19c67ba945573d0f6069d643af6c336a5
* Bump API max version to 3.709.1.0Alan Bishop2022-08-091-1/+1
| | | | | | | | | | Bump MAX_VERSION to 3.70 to support the following: - 3.69 - Allow null value for shared_targets - 3.70 - Support encrypted volume transfers Implements: bp/transfer-encrypted-volume Depends-On: I459f06504e90025c9c0b539981d3d56a2a9394c7 Change-Id: I11072d6d8a185037c7f4cdd52c45933b0cccaf05
* Fix extension loading from python pathzack chen2022-06-291-0/+2
| | | | | | | | | Commit 3502a5591a654ae57741c6738994ffa9d8457696 broke extension loading from pythonpath. Incompatible on python3.6.8, python3.8, python3.9. Put it back. Closes-Bug: #1980184 Change-Id: I5b67c93e3c789252d9bd35ee69dddbe1b556dec4
* Update python testing as per zed cycle testing runtime9.0.0Ghanshyam Mann2022-05-194-12/+16
| | | | | | | | | | | In Zed cycle, we have dropped the python 3.6/3.7[1] testing and its support. Moving the py36 job to py38 based but to run on ubuntu focal as c8s does not seems to have py38. Also updating the python classifier also to reflect the same. [1] https://governance.openstack.org/tc/reference/runtimes/zed.html Change-Id: Ic26a360d2bb09fa6622d1acaa5021c5afbc70240
* Update master for stable/yogaOpenStack Release Bot2022-02-252-0/+7
| | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/yoga. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/yoga. Sem-Ver: feature Change-Id: I96aa28bd09724d3f14935e1dbf13f7e791261ccb
* Prepare for Yoga cinderclient release8.3.0Brian Rosmaita2022-02-241-0/+5
| | | | | | Add a release note prelude for the Yoga release. Change-Id: Id601999762596713c94e7805a7d76dbcf31edf24
* Merge "Add volume reimage command"Zuul2022-02-248-1/+84
|\
| * Add volume reimage commandwhoami-rajat2022-02-248-1/+84
| | | | | | | | | | | | | | | | | | | | A new reimage API will be introduced on cinder API side with change in depends on. This patch provides the CLI support for the same by adding a reimage command. Implements: blueprint add-volume-re-image-api Change-Id: I37c254d4caf2f416e456ff6a78b5a4df4e08a176
* | Move tempest requirement to functional envEric Harney2022-02-172-1/+5
| | | | | | | | | | | | | | | | We don't need to track this in test-reqs for unit tests, etc. since it's only used for functional tests. Change-Id: I2e9a55d0f4530e9f3fd0f6c1c48cf5ee19c841da
* | Merge "Add Python 3 only classifier"Zuul2022-02-111-0/+1
|\ \
| * | Add Python 3 only classifierTakashi Kajinami2022-02-081-0/+1
| |/ | | | | | | | | | | | | | | | | | | Python 2 support was removed during Ussuri cycle. This change adds the classifier to clearly state that only Python 3 is supported. This allows us to keep the setup.cfg file in cinder and the one in cinderclient more consistent. Change-Id: I5ad342f2b60348a0ba79c95415fdf1ae39714558
* | Updating python testing as per Yoga testing runtimetushargite962021-12-153-11/+8
|/ | | | | | | | | | | | | | | | Yoga testing runtime[1] has been updated to add py39 testing as voting and as we are testing py3.6 and py3.9 we do not need to test py3.7|8 explicitly. Unit tests update are handled by the job template change in openstack-zuul-job - https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286 this commit makes other required changes in zuul.yaml and update the classifier in setup.cfg file. [1] https://governance.openstack.org/tc/reference/runtimes/yoga.html Change-Id: Ib5b93ca7863fcc0b6d00fb4d52a5f299d1903056
* Merge "Improve help text of volume create command"Zuul2021-11-192-2/+11
|\
| * Improve help text of volume create commandwhoami-rajat2021-11-082-2/+11
| | | | | | | | | | | | | | | | | | This patch adds information about whichever default type is set for API will be used during volume creation if we don't provide a volume type in volume create command. This patch also improves the help text of `cinder type-default` command. Change-Id: I0c437b2c4f02c12d17c04719cbeff8521647ae15
* | Merge "Correct "Increase default quotas for zuul jobs""8.2.0Zuul2021-11-091-5/+3
|\ \ | |/ |/|
| * Correct "Increase default quotas for zuul jobs"Brian Rosmaita2021-09-231-5/+3
| | | | | | | | | | | | | | | | | | | | | | It turns out that you can't use the devstack post_config phase for this because it happens too late. The quota settings must be made to cinder.conf before cinder-manage db_sync is called where they're used to set the max limit for the tables used by the db quotas driver. Depends-on: https://review.opendev.org/c/openstack/devstack/+/803521 Change-Id: I3bb7d9f9bede063573b24fb5a33a364c53d52434
* | Merge "Remove the unused tool scripts"Zuul2021-10-153-252/+0
|\ \ | |/ |/|
| * Remove the unused tool scriptsdengzhaosen2021-08-263-252/+0
| | | | | | | | | | | | | | We support Python 3.6 as a minimum now, making these checks no-ops. These file is unused in current project and remove them. Change-Id: Ie5cbd9653375deeb523190d9c499f0c89c035d2e
* | Merge "Add W503 to flake8 ignores"Zuul2021-09-151-1/+1
|\ \
| * | Add W503 to flake8 ignoresBrian Rosmaita2021-09-021-1/+1
| | | | | | | | | | | | | | | | | | | | | Cinder ignores both W503 and W504, and it's really annoying that cinderclient is not consistent with cinder about this. Change-Id: Iab7ff2bfcb61fd5d8a7ee25e245cebe7a50c46b1
* | | Add Python3 yoga unit testsOpenStack Release Bot2021-09-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for yoga. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: Ie02a19f3bd51825ee3a4b122ef265eb2b3752a8a
* | | Update master for stable/xenaOpenStack Release Bot2021-09-032-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/xena. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/xena. Sem-Ver: feature Change-Id: I1a2ed0695125b5d0733299f3efd263fe61868ee7
* | | Prepare for Xena cinderclient releasexena-em8.1.0Brian Rosmaita2021-09-021-0/+21
| | | | | | | | | | | | | | | | | | Includes prelude plus a note for change I524490aa988f. Change-Id: I233faad57c9708cae9544c965fd0d94abdf6d684
* | | Support Block Storage API mv 3.66Brian Rosmaita2021-09-026-57/+254
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | Block Storage API mv 3.66 enables snapshots of in-use volumes without requiring a 'force' flag. For backward compatibility, the API silently accepts force=true, even though the 'force' flag is considered invalid for that call. That behavior is replicated in the client, where --force with a true value is silently accepted. The --force option is not advertised in the shell and an option value that doesn't evaluate to true raises an UnsupportedAttribute error. Similar behavior from the v3 Snapshot class, except it raises a ValueError under similar circumstances. Change-Id: I7408d0e3a5ed7f4cbcaf65cf3434ad60aaed511d
* | Merge "update some scripts"Zuul2021-09-012-335/+1
|\ \
| * | update some scriptsdengzhaosen2021-09-012-335/+1
| |/ | | | | | | | | | | | | remove the the colorizer.py which hasn't been used since https://review.opendev.org/c/openstack/python-cinderclient/+/502120 Change-Id: I9bed2ec947705cd53daa04678093a80581dc3282
* | Merge "Add functional jobs to the gate"Zuul2021-08-301-0/+9
|\ \
| * | Add functional jobs to the gateBrian Rosmaita2021-08-241-0/+9
| | | | | | | | | | | | | | | | | | Voting check jobs are supposed to also be gate jobs. Change-Id: Ibdf4c30606552fa0c2660a24c97354f814e5be24
* | | Merge "Fix list resources when use limit and with-count"Zuul2021-08-301-0/+6
|\ \ \
| * | | Fix list resources when use limit and with-countzhu.boxiang2020-12-171-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we use with-count query param, we will get the count of resources. While the _list function return two different result, one is just list, another is tuple with list and int. So we must to handle the items which return from _list function. Closes-bug: #1908474 Change-Id: If8e31a637cf098cca60d8a10e9835ef66a3e66bc
* | | | Merge "Increase default quotas for zuul jobs"Zuul2021-08-301-0/+5
|\ \ \ \ | | |/ / | |/| |
| * | | Increase default quotas for zuul jobsBrian Rosmaita2021-08-051-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're seeing occasional failures in the functional test jobs due to exceeding volumes quota, so increase these from the default value of 10 to something more reasonable like 25. Change-Id: Id1ab94849bfb35256dd0705b888708f3fa1106c4
* | | | Merge "client: Stop logging request-id twice in DEBUG"Zuul2021-08-301-14/+0
|\ \ \ \
| * | | | client: Stop logging request-id twice in DEBUGLee Yarwood2021-03-101-14/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is already logged by http_log_resp in DEBUG along with the other response headers so drop the duplicate logging in _log_request_id. Change-Id: I3c5ad2b480d80611ecb10449068d836c4bbe7bdb
* | | | | Add consumes quota field supportGorka Eguileor2021-08-253-16/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cinder microversion v3.65 adds consumes_quota key to volume and snapshots as a way to differentiate between use generated resources and temporary ones. This patch adds support for this microversion and presents the consumes_quota field when the server sends it (which only happens when we request this microversion). Change-Id: I524490aa988fa4d654bfa8050d89cf99ce50bb4b Depends-On: I655a47fc75ddc11caf1defe984d9a66a9ad5a2e7 Implements: blueprint temp-resources
* | | | | Merge "Unset tempest.lib timeout in functional tests"Zuul2021-08-051-0/+5
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Unset tempest.lib timeout in functional testsBrian Rosmaita2021-07-291-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test_cli.CinderBackupTests.test_backup_create_and_delete test is hitting timeout errors in the python-cinderclient-functional-py36 zuul job. This is happening because it's inheriting the OS_TEST_TIMEOUT value of 60 from the base testenv, and that value is being used by the tempest.lib class we inherit from as a timeout for each test. This is a problem for test_backup_create_and_delete because it creates a volume, waits for available, creates a backup, waits for available, deletes the volume, waits for deletion, deletes the backup, waits for deletion. Our functional tests have their own timeout handling, so turn off the tempest.lib timeout and use ours. An alternative to turning it off is to set it at a value that respects our timeout for our longest test, which would be: - time-to-available: 120 sec (x2) - time-to-deleted: 60 sec (x2) that is, 360 sec. Change-Id: I33399b4c094af2cc059da6e332f4c0a91e6ab57e
* | | | | Merge "Dropping lower constraints testing"Zuul2021-08-043-25/+0
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Dropping lower constraints testingzhangboye2021-07-073-25/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We facing errors related to the new pip resolver, this topic was discussed on the ML and QA team proposed to to test lower-constraints [1]. I propose to drop this test because the complexity and recurring pain needed to maintain that now exceeds the benefits provided by this mechanismes. [1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html Change-Id: I324cd145da8469f505ae2c135ee5035ee7008ca1
* | | | | Merge "Make instance_uuid optional in attachment create"8.0.0Zuul2021-07-206-3/+79
|\ \ \ \ \
| * | | | | Make instance_uuid optional in attachment createRajat Dhasmana2021-07-146-3/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cinder and cinderclient assumes an attachment create request will always contain instance_uuid. This is not true when glance calls cinder for attachment in glance cinder configuration. This patch (along with the cinder patch) make the instance_uuid optional and allow glance to do attachments without passing instance_uuid. Change-Id: Ifbaca4aa87d890bc5130069638d42665b914b378
* | | | | | Merge "Remove v2 classes"Zuul2021-07-2072-2039/+1122
|\ \ \ \ \ \
| * | | | | | Remove v2 classesBrian Rosmaita2021-07-1472-2039/+1122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove all cinderclient.v2 classes, mostly incorporating them into their v3 counterparts and updating the tests and test fixtures. Depends-on: https://review.opendev.org/c/openstack/horizon/+/800814 Change-Id: I335db5c1799edb2273bf8bfc9e1bc9de404a4ba5
* | | | | | | Merge "Remove v2 support from the shell"Zuul2021-07-2013-1454/+188
|\ \ \ \ \ \ \ | |/ / / / / / | | | / / / / | |_|/ / / / |/| | | | |
| * | | | | Remove v2 support from the shellBrian Rosmaita2021-07-1213-1454/+188
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also removes the v2 support from the generic client and restores a skipped test. Additionally, the cinderclient.tests.v2.test_availablity_zone module depends on the v2.shell class, so move that module to v3, update the v3 AvailablityZone class, and make appropriate adjustments to the tests and test fixtures. Change-Id: I7a3cca15f5944141d510a75af6684221c297963b
* | | | | | Remove skip_missing_interpretersBrian Rosmaita2021-07-013-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This prevents a job reporting 'success' when the appropriate python interpreter cannot be found, when actually it didn't run at all. Also change the default envlist to use generic 'py3' instead of a specific version which might not be present. Also change zuul config so the python-cinderclient-functional-py36 job runs on centos-8-stream nodes, where py36 should be available. And change bindep.txt to specify the correct package name for centos-8. Jeremy Stanley has given a more thorough explanation of why this is a good change: http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014810.html This isn't a theoretical issue. If you look at recent python-cinderclient-functional-py36 job results (for example, [0]), you'll see that Zuul reported 'success', but on a closer look, you'll see that no tests were run. [0] https://zuul.opendev.org/t/openstack/build/1bfc80638086405f8b29905cdd6f71be/log/job-output.txt#25470 Change-Id: I2e2aa24e1592b66b287c84eda97b5079c40a36ec
* | | | | | Merge "Add Python3 xena unit tests"Zuul2021-06-181-1/+1
|\ \ \ \ \ \
View Lorry Controller Status