summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrian Rosmaita <rosmaita.fossdev@gmail.com>2021-06-30 16:24:06 -0400
committerBrian Rosmaita <rosmaita.fossdev@gmail.com>2021-07-30 14:43:15 -0400
commit2239d425f9ef38270bd309f55fb75401641ea59d (patch)
treee2204cde4ebe3b1bc4835eb2542eaec336eccb54
parentb568bfaf24b92a64ba02bcc4c801cc002e560290 (diff)
downloadpython-cinderclient-2239d425f9ef38270bd309f55fb75401641ea59d.tar.gz
Remove skip_missing_interpreters
This prevents a job reporting 'success' when the appropriate python interpreter cannot be found, when actually it didn't run at all. Also change the default envlist to use generic 'py3' instead of a specific version which might not be present. Also change zuul config so the python-cinderclient-functional-py36 job runs on centos-8-stream nodes, where py36 should be available. And change bindep.txt to specify the correct package name for centos-8. Jeremy Stanley has given a more thorough explanation of why this is a good change: http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014810.html This isn't a theoretical issue. If you look at recent python-cinderclient-functional-py36 job results (for example, [0]), you'll see that Zuul reported 'success', but on a closer look, you'll see that no tests were run. [0] https://zuul.opendev.org/t/openstack/build/1bfc80638086405f8b29905cdd6f71be/log/job-output.txt#25470 Depends-on: https://review.opendev.org/c/openstack/devstack/+/803072 Change-Id: I2e2aa24e1592b66b287c84eda97b5079c40a36ec (cherry picked from commit b891c9980f316bd603a9f1429eebad41adf43825) (cherry picked from commit 4c6c3b49b5334518be1b776d32fada394743142f) changed: .zuul.yaml - using centos-8 node
-rw-r--r--.zuul.yaml3
-rw-r--r--bindep.txt4
-rw-r--r--tox.ini5
3 files changed, 6 insertions, 6 deletions
diff --git a/.zuul.yaml b/.zuul.yaml
index 2a431b7..2d6777a 100644
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -15,7 +15,8 @@
- job:
name: python-cinderclient-functional-py36
parent: python-cinderclient-functional-base
- nodeset: openstack-single-node-bionic
+ # need to specify a platform that has python 3.6 available
+ nodeset: devstack-single-node-centos-8
vars:
python_version: 3.6
tox_envlist: functional-py36
diff --git a/bindep.txt b/bindep.txt
index 812bcba..2dbd41a 100644
--- a/bindep.txt
+++ b/bindep.txt
@@ -7,7 +7,7 @@ libffi-devel [platform:rpm]
libssl-dev [platform:ubuntu-xenial]
locales [platform:debian]
python-dev [platform:dpkg]
-python-devel [platform:rpm]
+python-devel [platform:rpm !platform:centos-8]
python3-all-dev [platform:ubuntu !platform:ubuntu-precise]
python3-dev [platform:dpkg]
-python3-devel [platform:fedora]
+python3-devel [platform:rpm]
diff --git a/tox.ini b/tox.ini
index fb1f64b..236cf6d 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,9 +1,8 @@
[tox]
distribute = False
-envlist = py36,py38,pep8
-minversion = 3.1.0
+envlist = py3,pep8
+minversion = 3.18.0
skipsdist = True
-skip_missing_interpreters = true
# this allows tox to infer the base python from the environment name
# and override any basepython configured in this file
ignore_basepython_conflict=true