summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2019-03-07 11:20:16 +0000
committerGerrit Code Review <review@openstack.org>2019-03-07 11:20:16 +0000
commitd63ec1fe624a3dc08e5d7413cf0bf4be3dfb1920 (patch)
treedfc57360d7911300b0f1813932dea132535f78bb
parentb5dd705a5db5b271d5cab57548f69ad5d7c28c40 (diff)
parent009c5e3bfe88594d791034f38a4b2dbf7219c16f (diff)
downloadoslo-vmware-d63ec1fe624a3dc08e5d7413cf0bf4be3dfb1920.tar.gz
Merge "Return None if no suitable datastore is found"
-rw-r--r--oslo_vmware/objects/datastore.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/oslo_vmware/objects/datastore.py b/oslo_vmware/objects/datastore.py
index c927781..ef3bf7f 100644
--- a/oslo_vmware/objects/datastore.py
+++ b/oslo_vmware/objects/datastore.py
@@ -61,6 +61,9 @@ def get_recommended_datastore(session, sp_spec):
"RecommendDatastores",
session.vim.service_content.storageResourceManager,
storageSpec=sp_spec)
+ if not hasattr(spr, 'recommendations'):
+ LOG.error("Unable to find suitable datastore")
+ return
return spr.recommendations[0].key