diff options
author | Andreas Jaeger <aj@suse.com> | 2017-12-01 09:56:54 +0100 |
---|---|---|
committer | Andreas Jaeger <aj@suse.com> | 2017-12-01 09:56:54 +0100 |
commit | fed9e7cea51053716c092a506e2612168e73a704 (patch) | |
tree | bc7b9cbe38ac1edf83ddb71e0d565df6641db4df | |
parent | 8e3e0b792a9c189c384b87d2bd28524e856dea4d (diff) | |
download | oslo-vmware-fed9e7cea51053716c092a506e2612168e73a704.tar.gz |
Avoid tox_install.sh for constraints support
We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.
This follows https://review.openstack.org/#/c/508061 to remove
tools/tox_install.sh.
Change-Id: I0e3485e2cab064db3f8faf85c406c83720fb0242
-rwxr-xr-x | tools/tox_install.sh | 30 | ||||
-rw-r--r-- | tox.ini | 17 |
2 files changed, 9 insertions, 38 deletions
diff --git a/tools/tox_install.sh b/tools/tox_install.sh deleted file mode 100755 index 43468e4..0000000 --- a/tools/tox_install.sh +++ /dev/null @@ -1,30 +0,0 @@ -#!/usr/bin/env bash - -# Client constraint file contains this client version pin that is in conflict -# with installing the client from source. We should remove the version pin in -# the constraints file before applying it for from-source installation. - -CONSTRAINTS_FILE=$1 -shift 1 - -set -e - -# NOTE(tonyb): Place this in the tox enviroment's log dir so it will get -# published to logs.openstack.org for easy debugging. -localfile="$VIRTUAL_ENV/log/upper-constraints.txt" - -if [[ $CONSTRAINTS_FILE != http* ]]; then - CONSTRAINTS_FILE=file://$CONSTRAINTS_FILE -fi -# NOTE(tonyb): need to add curl to bindep.txt if the project supports bindep -curl $CONSTRAINTS_FILE --insecure --progress-bar --output $localfile - -pip install -c$localfile openstack-requirements - -# This is the main purpose of the script: Allow local installation of -# the current repo. It is listed in constraints file and thus any -# install will be constrained and we need to unconstrain it. -edit-constraints $localfile -- $CLIENT_NAME - -pip install -c$localfile -U $* -exit $? @@ -3,14 +3,13 @@ minversion = 2.0 envlist = py35,py27,pypy,pep8 [testenv] -setenv = - VIRTUAL_ENV={envdir} - BRANCH_NAME=master - CLIENT_NAME=oslo.vmware -install_command = {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages} +install_command = pip install -U {opts} {packages} whitelist_externals = find rm -deps = -r{toxinidir}/test-requirements.txt +deps = + -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} + -r{toxinidir}/test-requirements.txt + -r{toxinidir}/requirements.txt commands = python setup.py testr --slowest --testr-args='{posargs}' [testenv:pep8] @@ -20,12 +19,14 @@ commands = bandit -r oslo_vmware [testenv:pylint] -deps = -r{toxinidir}/test-requirements.txt +deps = + -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} + -r{toxinidir}/test-requirements.txt + -r{toxinidir}/requirements.txt pylint>=1.3.0 commands = pylint oslo [testenv:bandit] -deps = -r{toxinidir}/test-requirements.txt commands = bandit -r oslo_vmware [testenv:docs] |