summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* [imageutils] Fix __str__ for QemuImgInfostable/xenaBrian Rosmaita2023-01-302-1/+4
| | | | | | | | Code is calling 'appened' on a list; correct this to 'append'. Closes-bug: #1996426 Change-Id: I8729cf180f92f43519c942e22f3b285377a5612f (cherry picked from commit d49d5944824f15d00e04e1b9c7f8c3b03b440c95)
* fix strutils password regexxena-em4.10.2Hervé Beraud2022-03-103-0/+18
| | | | | | | | | | | | | | | Those regexes will fix Object style representation output. See the payload used in tests for details. This kind of output can be obtained by using the command: ``` $ openstack --debug ``` Co-Authored-By: Daniel Bengtsson <dbengt@redhat.com> Change-Id: I9024be93b109d1b64ca736546c0f69db7a5e06d0 (cherry picked from commit de4429f2be5fa21d1f6e1cacbb3c8417a7c56310) (cherry picked from commit 2c1b0628771695e546b0acb1e3c44c16c0c690db)
* Fix regex used to mask password4.10.1Hervé Beraud2022-01-133-1/+35
| | | | | | | | | | | | | | Some use cases are poorly handled by the regex used to mask password. Indeed when the password contains quotes or double quotes in the middle such as `pass"word`, the mask_password method will return `***"word`. For more details please see https://bugs.launchpad.net/oslo.utils/+bug/1949623 Closes-Bug: #1949623 Change-Id: I941750b4d49d2d75f0831b24d6dd17f4040f70a2 (cherry picked from commit 6e17ae1f7959c64dfd20a5f67edf422e702426aa)
* QemuImgInfo: Fix inconsistent value format of encryptedTakashi Kajinami2021-10-183-2/+11
| | | | | | | | | | | | | The qemu-img info command shows the encrpyed field in different formats according to the output format. When the default human format is used the field can be 'yes' or None while when json format is used the same field can be True or False. This change ensures the corresponding attribute has the consistent format regardless of the output format used. Closes-Bug: #1942682 Change-Id: I949f07582a708114fdfba76f1a05aa3a3e5c4f40 (cherry picked from commit 2922a3491a5987aa80f0612df44bd60ed22a0225)
* Update TOX_CONSTRAINTS_FILE for stable/xenaOpenStack Release Bot2021-09-101-2/+2
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/xena branch, tests will continue to use the upper-constraints list on master. Change-Id: I1156d4a02852bb638ac9e4183c4aa1a4e21be49e
* Update .gitreview for stable/xenaOpenStack Release Bot2021-09-101-1/+2
| | | | Change-Id: I09a922bb6fa2f831741ec8ee63dcd6c332a746c4
* Modify UUID sentinel to support keystone-like UUIDs4.10.0Alexey Stupnikov2021-08-033-3/+25
| | | | | | | | | | | | | | Keystone User IDs and Project IDs are used in unit tests, but _UUIDSentinels() class doesn't generate UUIDs without hyphens. This patch makes backward compatible modifications to _UUIDSentinels() class and introduces keystoneidsentinel global that could be used in the same way as existing uuidsentinel. Original "UUID sentinel" change: I214ff21b461fa1ca4b83476e1d0a763efe986217 Related-Bug: #1746747 Change-Id: Idb3e893cc03d64ad0522b5e4cedfa30c4f4a2a2f
* QemuImgInfo: Skip deprecation warning when output is not passed4.9.2Takashi Kajinami2021-07-061-5/+6
| | | | | | | | | | | | | | | | | | | | | | Change 73eb0673f627aad382e08a816191b637af436465 deprecated usage of the human format and introduced a deprecatipon warning message which is shown unless format is explicitly set to 'json'. To avoid the deprecation warning, all usage of QemuImgInfo requires explicit definition of format='json'. This means that we should add the format parameter to all existing usage of QemuImgInfo even if output is blank as is described in the following example. QemuImgInfo() QemuImgInfo(output=None) However later we should revert these implementations again when we deprecated or remove the format parameter. These steps are very redundant. This change suppresses the warning message when output is blank so that we can avoid deprecation warnings without redundant update and revert. Change-Id: If1ec42dae757fa3d74c740a52c346701ea19f1c9
* Drop warnings enable filteryatinkarel2021-07-011-2/+0
| | | | | | | | | | | | [1] Enabled warnings without specifying category, leading to all sort of warnings enabled, this patch drops it and let it to consumers to enable warnings types which they are interested in. [1] https://review.opendev.org/c/openstack/oslo.utils/+/790429 Closes-Bug: #1934098 Change-Id: I822138c18e0932e8f7e3dc62267f167876c962ae
* Remove references to 'sys.version_info'4.9.1dengzhaosen2021-06-012-107/+6
| | | | | | We support Python 3.6 as a minimum now, making these checks no-ops. Change-Id: Ia183dc2f19bf08635fb830d603f2bed888765ef6
* Merge "Ussuri+ is python3 only and update python to python3"Zuul2021-05-261-1/+1
|\
| * Ussuri+ is python3 only and update python to python3dengzhaosen2021-05-061-1/+1
| | | | | | | | Change-Id: If3f844ee6bfebc16f15263dc03653cb2aba27bf2
* | Merge "Deprecate the fnmatch module."Zuul2021-05-262-0/+14
|\ \
| * | Deprecate the fnmatch module.Hervé Beraud2021-05-112-0/+14
| |/ | | | | | | | | | | | | | | | | | | | | Oslo.utils's fnmatch module was added to fix the py2.7 fnmatch module who was not thread safe [1]. Python 2.7 is no longer supported so now we can use the stdlib's fnmatch module and deprecate the one of oslo.utils. [1] https://bugs.python.org/issue23191$ [2] https://opendev.org/openstack/oslo.utils/commit/e46a46ba90741987f1147afc56876e3d0d27e8a2 Change-Id: I538379f91d2ba415c566ada8d221b62b47ba80bb
* | Merge "Dropping lower constraints testing"Zuul2021-05-261-39/+0
|\ \
| * | Dropping lower constraints testingsongwenping2021-04-251-39/+0
| |/ | | | | | | | | | | | | | | | | | | | | | | | | We facing errors related to the new pip resolver, this topic was discussed on the ML and QA team proposed to to test lower-constraints [1]. I propose to drop this test because the complexity and recurring pain needed to maintain that now exceeds the benefits provided by this mechanismes. [1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html Change-Id: Ib7db2f9aafa9b9a3acfb74ed33aef6c3355b4db8
* | Deprecate the human format on QemuImgInfoHervé Beraud2021-05-103-8/+37
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | ``human`` format parsing introduced many issue in the past. Each time qemu will update it's human format output we could be impacted by their changes and it could introduce new issues on oslo.utils. Human format is a human readable format which need to be parsed by regexes, in other words it's not really a format that machine can consume natively. Qemu introduced json output since version 1.3 [1] and this format is machine readable, for the sake of stability on oslo.utils we decided to drop the support of the human format and to use json as the unique and only supported format. We will reach our goal by following this scenario: step 1: deprecate the human format step 2: remove the human format and deprecate the format parameters step 3: remove the parameter (json all the time) These changes deprecate the ``human`` format (step 1) [1] https://wiki.qemu.org/ChangeLog/1.3 Change-Id: Ia8d6cd08a8989395f9b0f9097d2e57757b8cb915
* Merge "Drop lower-constraints"4.9.0Zuul2021-04-161-6/+0
|\
| * Drop lower-constraintssongwenping2021-04-161-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lower-constraints is not a requirement of the OpenStack Python PTI [0] and there currently is a discussion on the mailing list [1] about dropping the test, with the oslo team already having done so [2]. The new dependency resolver in pip fails due to incompatible dependency versions in our lower-constraints file, meaning that we were never providing any real guarantees with it. To unblock the CI, I am disabling lower-constraints job for now, with the option to reenable it in case we fix the constraints, and based on the outcome of the mailing list discussions and consensus. [0]. https://governance.openstack.org/tc/reference/pti/python.html [1]. http://lists.openstack.org/pipermail/openstack-discuss/2021-January/019672.html [2]. http://lists.openstack.org/pipermail/openstack-discuss/2021-January/019659.html Change-Id: I8c647b325a6f489aaffdab474117c5451852c81e
* | Merge "strutils: Stop masking encryption_key_id"Zuul2021-04-162-4/+1
|\ \
| * | strutils: Stop masking encryption_key_idLee Yarwood2020-11-232-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As the name suggests this is simply an id referring to a key and not the actual key itself. As such we should stop masking this in an effort to ease debugging and troubleshooting when it is logged. This was previously incorrectly masked by I9e684cd8bab85728ff0117f95a30eb7dbb5bf51c as part of bug #1814365. Closes-Bug: #1905264 Change-Id: I856e3cf32c409debdfb15aa96415c3309fe2f516
* | | Merge "Address nits from six removal patch"Zuul2021-04-164-12/+12
|\ \ \
| * | | Address nits from six removal patchStephen Finucane2021-02-014-12/+12
| | | | | | | | | | | | | | | | | | | | Change-Id: Ia487c2961849a1d42eb72b2a69c360ea638f9d1b Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
* | | | Merge "Switch to collections.abc.*"Zuul2021-04-162-7/+5
|\ \ \ \ | |_|_|/ |/| | |
| * | | Switch to collections.abc.*Stephen Finucane2021-02-012-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The abstract base classes previously defined in 'collections' were moved to 'collections.abc' in 3.3. The aliases will be removed in 3.10. Preempt this change now with a simple find-replace: $ ag -l 'collections.($TYPES)' | \ xargs sed -i 's/\(collections\)\.\($TYPES\)/\1.abc.\2/g' Where $TYPES is the list of moved ABCs from [1]. [1] https://docs.python.org/3/library/collections.abc.html Change-Id: I85f2757852c0313967f5d82166124feb10aa4c6a Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
* | | | Merge "Add Python3 xena unit tests"Zuul2021-04-151-1/+1
|\ \ \ \
| * | | | Add Python3 xena unit testsOpenStack Release Bot2021-03-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for xena. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: Iab337adf2d60019667e6cd1602c7d446158e960d
* | | | | Merge "Update master for stable/wallaby"Zuul2021-04-152-0/+7
|\ \ \ \ \ | |/ / / /
| * | | | Update master for stable/wallabyOpenStack Release Bot2021-03-182-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/wallaby. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/wallaby. Sem-Ver: feature Change-Id: I5a6aa9963662929b03c7ecd68fb18235af428b06
* | | | | Move flake8 as a pre-commit local target.Daniel Bengtsson2021-03-231-3/+7
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The goal here is to avoid conflicts between flake8 and hacking version each 2 days. Inspired from nova's approach[1]. The flake8 version to install will be determined by hacking and requirements[2] will stay aligned instead of relying on different versions. [1] https://opendev.org/openstack/nova/src/branch/master/.pre-commit-config.yaml#L26-L35 [2] https://opendev.org/openstack/hacking/src/branch/master/requirements.txt#L1 Change-Id: I831311270134dfa592b02497701d9aee0100607d
* | | | Add a ``strict`` flag allowing users to restrict validation of IPv4 format4.8.0Hervé Beraud2021-02-053-3/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a ``strict`` flag allowing users to restrict validation to IP addresses in presentation format (``a.b.c.d``) as opposed to address format (``a.b.c.d``, ``a.b.c``, ``a.b``, ``a``). https://github.com/netaddr/netaddr/issues/186 https://man7.org/linux/man-pages/man3/inet_pton.3.html https://bugzilla.redhat.com/show_bug.cgi?id=1924436 Change-Id: I10fed16dad77ac17691a5d175c42b25916dc8bc4 Closes-Bug: #1914386
* | | | Merge "Use TOX_CONSTRAINTS_FILE"Zuul2021-02-010-0/+0
|\ \ \ \
| * | | | Use TOX_CONSTRAINTS_FILEzhangboye2020-12-241-1/+1
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | UPPER_CONSTRAINTS_FILE is old name and deprecated This allows to use upper-constraints file as more readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>. Change-Id: I331232afa7fb438224a4bd700de0d3412fdcc9df
* | | | Merge "Remove all usage of six library"Zuul2021-02-0118-265/+124
|\ \ \ \ | |_|/ / |/| | / | | |/ | |/|
| * | Remove all usage of six libraryhaixin2020-10-0918-265/+124
| | | | | | | | | | | | | | | | | | Replace six with Python 3 style code. Change-Id: I52aa4a0f679b56ffa57cdd2199933e36cf076992
* | | Merge "Use TOX_CONSTRAINTS_FILE"Zuul2021-01-141-2/+2
|\ \ \
| * | | Use TOX_CONSTRAINTS_FILEHervé Beraud2020-11-041-2/+2
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | UPPER_CONSTRAINTS_FILE is old name and deprecated This allows to use upper-constraints file as more readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>. [1] https://review.opendev.org/#/c/722814/ [2] https://zuul-ci.org/docs/zuul-jobs/python-roles.html#rolevar-tox.tox_constraints_file Change-Id: I4b54c27a99a095c7712c88b0e8bd59a21d7bc0b4
* | | Dropping lower constraints testingHervé Beraud2020-12-181-1/+0
|/ / | | | | | | | | | | | | | | | | | | | | | | | | We facing errors related to the new pip resolver, this topic was discussed on the ML and QA team proposed to to test lower-constraints [1]. I propose to drop this test because the complexity and recurring pain needed to maintain that now exceeds the benefits provided by this mechanismes. [1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html Change-Id: Ia02154a1eb04434658a21adf82599ae55302e310
* | Use py3 as the default runtime for toxHervé Beraud2020-11-031-1/+1
|/ | | | | | | | | | | | | | | | | Moving on py3 as the default runtime for tox to avoid to update this at each new cycle. Wallaby support officially the following runtimes [1]: - Python 3.6 - Python 3.8 During Victoria Python 3.7 was used as the default runtime [2] however this version isn't longer officially supported. [1] https://governance.openstack.org/tc/reference/runtimes/wallaby.html#python-runtimes-for-wallaby [2] https://governance.openstack.org/tc/reference/runtimes/victoria.html#python-runtimes-for-victoria Change-Id: Icaa63c0a076029c228c009015a833b8ca60f1ef4
* Merge "Adding pre-commit"4.7.0Zuul2020-09-226-6/+44
|\
| * Adding pre-commitHervé Beraud2020-09-096-6/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduced changes: - pre-commit config and rules - Add pre-commit to pep8 gate, Flake8 is covered in the pre-commithooks. - Applying fixes for pre-commit compliance in all code. Also commit hash will be used instead of version tags in pre-commit to prevend arbitrary code from running in developer's machines. pre-commit will be used to: - trailing whitespace; - Replaces or checks mixed line ending (mixed-line-ending); - Forbid files which have a UTF-8 byte-order marker (check-byte-order-marker); - Checks that non-binary executables have a proper shebang (check-executables-have-shebangs); - Check for files that contain merge conflict strings (check-merge-conflict); - Check for debugger imports and py37+ breakpoint() calls in python source (debug-statements); - Attempts to load all yaml files to verify syntax (check-yaml); - Run flake8 checks (flake8) (local) For further details about tests please refer to: https://github.com/pre-commit/pre-commit-hooks Change-Id: Iba1e2ce707051ea393ac559fc51b1f07da1f6ee8 Signed-off-by: Moisés Guimarães de Medeiros <moguimar@redhat.com>
* | Merge "Add function to encapsule md5 for FIPS systems"Zuul2020-09-213-0/+84
|\ \
| * | Add function to encapsule md5 for FIPS systemsAde Lee2020-09-163-0/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For systems in FIPS mode, invocations of MD5 will fail. This occurs even in cases where the MD5 is used in a non-cryptographical context eg. for an etag in swift. There is a proposal in Python to allow developers to mark these non-crypto cases as valid through a new usedforsecurity keyword. See https://bugs.python.org/issue9216. Some downstream versions of python already implement this keyword. To permit OpenStack to run in FIPS enabled systems with these versions of python, we add a simple encapsulation of hashlib.md5() here. Once the issue is resolved in upstream python, we can remove this function. Change-Id: I09433fea6ad6e6849677a93b269e24dec5c05b69
* | | Add Python3 wallaby unit testsSean McGinnis2020-09-141-1/+1
| | | | | | | | | | | | | | | Change-Id: I3101cbcb8c1f7269683f6c10db929135b53c1270 Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* | | Merge "Add Python3 victoria unit tests"Zuul2020-09-141-1/+1
|\ \ \
| * | | Add Python3 victoria unit testsOpenStack Release Bot2020-09-071-1/+1
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for victoria. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: I6f3456802fd432580dd27d9c03bde21759c4a3ae
* | | Update master for stable/victoriaOpenStack Release Bot2020-09-112-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/victoria. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/victoria. Change-Id: I0fe9048d788b5d334ba93d97a9c3c6f9562c98db Sem-Ver: feature
* | | [goal] Migrate testing to ubuntu focal4.6.0Ghanshyam Mann2020-09-071-1/+1
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per victoria cycle testing runtime and community goal[1] we need to migrate upstream CI/CD to Ubuntu Focal(20.04). Fixing: - bug#1886298 Bump the lower constraints for required deps which added python3.8 support in their later version. Story: #2007865 Task: #40207 Closes-Bug: #1886298 [1] https://governance.openstack.org/tc/goals/selected/victoria/migrate-ci-cd-jobs-to-ubuntu-focal.h> Change-Id: Ic0a2606a414ce9d169c3736968356ce0133acb70
* | Fix is_same_callback() testing for python3.8Ghanshyam Mann2020-09-072-7/+43
|/ | | | | | | | | | | | | | | | | | | | Python3.8 onwards, comparision of bound methods is changed. It no longer decide the bound method's equality based on their bounded objects equality instead it checks the identity of their '__self__'. Details about this behavior change in python 3.8 - https://bugs.python.org/issue1617161 - python-dev discussion: https://mail.python.org/pipermail/python-dev/2018-June/153959.html So python3.8 onwards, 'strict' arg has no meaning. For backward compatibility for python <3.8, we can keep the 'strict' arg but with deprecation warning. Also modify the is_same_callback() unit tests to verify the 'strict' arg based on python version. Change-Id: I3e6d9bbceccacddd0e1a514bbe5d0722a3408ecb Closes-Bug: #1841072
* Add util methods for checking json and yaml formatted file4.5.0Ghanshyam Mann2020-08-263-1/+84
| | | | | | | | | | | | | | | | As part of oslo_policy policy_file JSON to YAML migration BP, we need to check if oslo policy_file is JSON or YAML formatted (almost on all projects with policy in code, example Needed-By). - https://specs.openstack.org/openstack/oslo-specs/specs/victoria/policy-json-to-yaml.html These util methods try quick checks of file type by loading the file using json or yaml. Needed-By: https://review.opendev.org/#/c/748059/ Related Blueprint: policy-json-to-yaml Change-Id: I0edf030dc5cd6b77e0101089746589332860fa16
View Lorry Controller Status