summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Release greenthread when computing checksumstein-em3.40.7stable/steinVladyslav Drok2020-06-102-0/+22
| | | | | | | | | | | Having time.sleep(0) after reading each block of data for computing checksum will allow other greenthreads to run. Closes-Bug: 1882569 Change-Id: I6e547d206de9e3e333e29ccad52bf6b519a86ff9 (cherry picked from commit b9938230f992935e8332b6e288937be890724cd2) (cherry picked from commit eeb7b1010720c47511d8b1abb94260357b0bea3f) (cherry picked from commit f4deaad463efacaaaf429ac37bf5d37903cb4f55)
* tox: Use upper-constraints for docs jobscaoyuan2020-04-231-4/+7
| | | | | | | | | Note(elod.illes): upper constraint file link modified to point to Stein version of the file. Change-Id: I43225fc4ed3ba471ba7097f1e317bc6ffa777a46 (cherry picked from commit 8433aba4d6b5925fa8fb223d51a816ff541f1f2f) (cherry picked from commit c3c5aac8ff75f9bb9dc6228169a8c6936c5548e0)
* Fix regex to correctly recognize scientific notation with QemuImgInfo3.40.6Hervé Beraud2020-02-263-1/+11
| | | | | | | | | | | | | | | | | | | | | qemu 4.1.0 output shifts to scientific notation at 1000mb, breaking oslo.utils. Problem here is that the qemu-img output shifts to scientific notation: 999 => 999 MiB 1000 => 1e+03 MiB The regex in python-oslo-utils does not cover this. This issue is likely regexp parsing "disk size: 1e+03 MiB" value. These changes fix that. Change-Id: I4c016865890135023ceb497de18d75ccebd5961a Closes-Bug: 1864529 (cherry picked from commit ebf8368501500767fd4e6e13602bb88950a4484b) (cherry picked from commit 85cd57d1c5b7f1e046f831b9b1caa341b688cfb4)
* Make mask_dict_password case insensitive and add new patterns3.40.5Dougal Matthews2019-11-183-5/+31
| | | | | | | | | | | | | | In Icc19b7c8bdb6a3182939d5e9fdef21288b19f43d mask_password was made case insensitive but mask_dict_password wasn't. This update makes the behaviour of these functions the same. Instead of lowering _SANITIZE_KEYS each time the source list is lowered. New password patterns from realworld logs were added to the patterns. Change-Id: Ic3ee301857630a15b9c26fd5d0fc907c43199517 Related-Bug: #1850843 (cherry picked from commit ed70bd3cd10eae2a34a5e9bd5d1fe0a6791ab3de)
* Make mask_password case insensitive, and add new patternsCédric Jeanneret2019-11-133-14/+64
| | | | | | | | | | | It appears that Mistral service logs everything, and doesn't use yet the mask_password (nor mask_dict_password) method. In order to ensure all is properly masked, we have to add some new patterns, and make it case insensitive in order to simplify and avoid duplicated entries. Change-Id: Icc19b7c8bdb6a3182939d5e9fdef21288b19f43d Related-Bug: #1850843 Signed-off-by: Cédric Jeanneret <cjeanner@redhat.com>
* Mask encryption_key_idyenai2019-11-132-1/+5
| | | | | | Change-Id: I9e684cd8bab85728ff0117f95a30eb7dbb5bf51c Closes-Bug: #1814365 (cherry picked from commit 08d76b5373dd19d0425d525983637f260d9be629)
* Support "qemu-img info" virtual size in QEMU 4.1 and later3.40.4Mark Mielke2019-10-042-2/+17
| | | | | | | | | | | | | | | | | | | QEMU 4.0 and earlier have output like: virtual size: 1.5M (1572864 bytes) QEMU 4.1 and later have output like: virtual size: 1.5 MiB (1572864 bytes) Adjust the regular expression to allow for optional whitespace between the magnitude and the unit. Adjust the unit parsing to support the expanded "MiB" form. Change-Id: I1f316d6982c0def3296af4835484ad2d81a87fd4 Closes-Bug: 1844050 (cherry picked from commit 5204dfcd6c5a8f75bb1fe3dc348cec82a6284eff)
* OpenDev Migration PatchOpenDev Sysadmins2019-04-191-1/+1
| | | | | | | | | | | | | | | This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
* Update UPPER_CONSTRAINTS_FILE for stable/steinOpenStack Release Bot2019-03-181-1/+1
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/stein branch, tests will continue to use the upper-constraints list on master. Change-Id: I2ee5fe3390211d6687c3503de1863f97091f1a74
* Update .gitreview for stable/steinOpenStack Release Bot2019-03-181-1/+2
| | | | Change-Id: I2d07d5baba5061ef468bf8a27ef8c87dded6f3eb
* add python 3.7 unit test job3.40.3ZhongShengping2019-02-191-0/+1
| | | | | | | | | | | | | This is a mechanically generated patch to add a unit test job running under Python 3.7. See ML discussion here [1] for context. [1] http://lists.openstack.org/pipermail/openstack-dev/2018-October/135626.html Story: #2004073 Task: #27440 Change-Id: I856881d9a710e01ed171d25c8d2dbf97eb7ed7b3
* Update hacking versionZhijunWei2019-02-135-8/+9
| | | | | | | Use latest release 1.1.0 and compatible changes w.r.t pep8 Change-Id: Ide3a556918f341de6eafecb36ca431da40a0aed0 Closes-Bug: #1815715
* Avoid double-setting event3.40.2Ben Nemec2019-01-232-1/+13
| | | | | | | | | | | | | | | | In commit cc8b51e1e16f6bdc7d6c0e571e2002e70cde098d we added a send on the old event when clearing an EventletEvent. However, this was done unconditionally, which means if the event was already sent then we attempt to send it again. This fails with: AssertionError: Trying to re-send() an already-triggered event. Similar to 14a53c4d8a9d5605b14a503803859df0d6d4b820, we should check if self._set is True and if so then we know that the event was already sent and we don't need to do it again. Change-Id: I660601383072d11e4a077aada8c1b8c30b9d8d1d Closes-Bug: 1812922
* Merge "Avoid calling eventlet.event.Event.reset()"3.40.1Zuul2019-01-182-9/+6
|\
| * Avoid calling eventlet.event.Event.reset()Zane Bitter2019-01-032-9/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The eventlet maintainers have made it clear that calling reset() on an Event is not recommended: https://github.com/eventlet/eventlet/commit/715b2ced5239bbada84c06f488b9c8dda8180230 We don't really need to resend the event to wake up threads, because Event.wait() will return immediately once the event has been sent. So just rely on the internal _set flag to tell us whether we need to send the event. Change-Id: I466aa7cb64308e018598c3bb63a9d0cfbc833adc
* | Merge "Support non-dict mappings in mask_dict_password"3.40.0Zuul2019-01-082-3/+45
|\ \
| * | Support non-dict mappings in mask_dict_passwordBen Nemec2018-12-032-3/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mask_dict_password doesn't actually have a dependency on the dict type specifically. It can work on any subclass of collections.Mapping. This changes the isinstance check to reflect that and adds a unit test using a collections.Mapping subclass. Change-Id: I28781acf027b9b34f8274196db5dd4d2a9adc9ba Closes-Bug: 1804528
* | | Merge "Fix race condition in eventletutils Event"3.39.1Zuul2019-01-074-3/+67
|\ \ \ | | |/ | |/|
| * | Fix race condition in eventletutils EventZane Bitter2018-12-054-3/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The threading-compatible eventlet Event class has a race condition on the wait method. If greenthread A is blocked on the wait, but another greenthread B calls clear() and then set(), B calls self._event.send(), but A is waiting on a different eventlet Event which is no longer used by the oslo.service Event... To resolve this, when clearing an Event trigger the underlying eventlet Event immediately, then have the wait() method resume waiting on the new eventlet Event. Change-Id: I81579e2977bb965a5398a2cb4e3e24f5671e856a Co-Authored-By: Victor Stinner <vstinner@redhat.com> Co-Authored-By: Hervé Beraud <hberaud@redhat.com> Closes-Bug: #1805706
* | | Use template for lower-constraintsAndreas Jaeger2018-12-201-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Small cleanups: * Use openstack-lower-constraints-jobs template, remove individual jobs. * Sort list of templates Change-Id: I3c1f03ef0cf2ee912db0b81005353e822e7ba4d2 Needed-By: https://review.openstack.org/623229
* | | Merge "Don't use monotonic on Python >=3.3"3.39.0Zuul2018-12-132-2/+6
|\ \ \ | |/ /
| * | Don't use monotonic on Python >=3.3Zane Bitter2018-12-052-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A change to the global-requirements[1] has limited use of the monotonic library to Python versions earlier than 3.3 (later versions have built-in support for a monotonic clock), so no requirements changes can be merged until we similarly limit it in requirements.txt. [1] https://review.openstack.org/615441 Change-Id: Ib53d89ea820d21114d10280c9f4ab1b0c2c4a4bc
* | | Update mailinglist from dev to discussZhongShengping2018-12-051-1/+1
|/ / | | | | | | | | | | | | openstack-dev was decomissioned this night in https://review.openstack.org/621258 Update openstack-dev to openstack-discuss Change-Id: I815cf3290b137940cbe9811bb5b5a59739425f01
* | Expose eventlet Event wrapper class3.38.0Ben Nemec2018-11-012-3/+4
|/ | | | | | | | | | | | | | | We have a need to use the eventlet Event class directly in oslo.service. Currently it is copy-pasted from this project, but we now have a duplicate bug due to that so let's just expose it so one copy can be used in both places. This should be safe as the class implements a stdlib interface so we can't really alter the API, and it's not really private since instances of it are returned to users. Change-Id: If8e7a41f9fe5573a780f9faabdbaf1326631d37a Related-Change: https://review.openstack.org/558879 Related-Bug: 1800879
* Clean up .gitignore references to personal toolsZhongShengping2018-10-151-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | Developers run all sorts of different tools within Git repositories, any of which can leave their own special trashfiles all over the place. We can't every hope to catalog them all, so better to recommend developers simply configure a global core.excludesfile to filter the irrelevant files which tend to get created by their personal choice of tools. To this end, remove the long-standing sections for "Mr Developer" and "Editors" since their mere existence here sends the signal that we welcome (and have time to review) additions for any old tool someone ever might happen to try. Also add a comment block explaining this, for clarity. We can, and should of course, continue to list files created by the tools recommended by our workflow (test frameworks called from tox, documentation and packaging builds, et cetera). This change is a port of I1b41efac219fca44e2548fc36633724d0ecfc0cb from the openstack-dev/oslo-cookiecutter repository. Change-Id: I09a564e59c4515a67698d5c15df1d1b3d77bbc38
* Fix exception raise at rpdb session3.37.1BubaVV2018-09-071-2/+2
| | | | | | | | Some components raise unrelated exceptions during rpdb session due to unaware attribute handling of file-like objects Change-Id: I04dd5a7d0f6ec2920671dfa612439427dffefd52 Closes-bug: #1791104
* Merge "Fix docstring formatting nit in uuidsentinel"3.37.0Zuul2018-08-281-1/+1
|\
| * Fix docstring formatting nit in uuidsentinelBen Nemec2018-08-281-1/+1
| | | | | | | | | | | | | | | | This doesn't actually appear in the docs because it's a private class, but if we ever made it public we want it to format the code block correctly. Change-Id: Ia79b58d6d7847b65f946763c82a25ce8d8e581fb
* | Merge "UUID sentinel"Zuul2018-08-282-0/+62
|\ \ | |/
| * UUID sentinelEric Fried2018-08-282-0/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a private _UUIDSentinels() class to oslo_utils.fixture that behaves like a mock.sentinel, but returns specifically UUIDs. Expose a (singleton) instance of it called uuidsentinel. This is mostly copied from [1], with the following differences: - We don't do the enforced-singleton thing [2]. But importing the uuidsentinel global yields the same behavior. - We don't do the local import thing [3][4], because we're already in the right lib, so no issues with circular imports. - Locking is added to make this threadsafe. (See discussion at [5]) Note that there is some question as to whether it is more appropriate for this to live here or in oslotest [6]. This has been discussed on the dev ML [7] and it was concluded [8] that it should live here. [1] https://github.com/openstack/nova/blob/722d5b477219f0a2435a9f4ad4d54c61b83219f1/nova/tests/uuidsentinel.py [2] https://github.com/openstack/nova/blob/722d5b477219f0a2435a9f4ad4d54c61b83219f1/nova/tests/uuidsentinel.py#L30 [3] https://github.com/openstack/nova/blob/722d5b477219f0a2435a9f4ad4d54c61b83219f1/nova/tests/uuidsentinel.py#L18-L19 [4] https://github.com/openstack/nova/blob/722d5b477219f0a2435a9f4ad4d54c61b83219f1/nova/tests/uuidsentinel.py#L26 [5] http://eavesdrop.openstack.org/irclogs/%23openstack-oslo/%23openstack-oslo.2018-08-20.log.html#t2018-08-20T20:10:33 [6] https://review.openstack.org/#/c/594068/ [7] http://lists.openstack.org/pipermail/openstack-dev/2018-August/133670.html [8] http://lists.openstack.org/pipermail/openstack-dev/2018-August/133861.html Change-Id: I214ff21b461fa1ca4b83476e1d0a763efe986217
* | Merge "add lib-forward-testing-python3 test job"Zuul2018-08-271-0/+1
|\ \
| * | add lib-forward-testing-python3 test jobDoug Hellmann2018-08-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a mechanically generated patch to add a functional test job running under Python 3 as part of the python3-first goal. See the python3-first goal document for details: https://governance.openstack.org/tc/goals/stein/python3-first.html Change-Id: I3b1472739b25ebcdd8ffbab048c611315b8f108e Story: #2002586 Task: #24322
* | | Merge "add python 3.6 unit test job"Zuul2018-08-251-0/+1
|\ \ \ | |/ /
| * | add python 3.6 unit test jobDoug Hellmann2018-08-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a mechanically generated patch to add a unit test job running under Python 3.6 as part of the python3-first goal. See the python3-first goal document for details: https://governance.openstack.org/tc/goals/stein/python3-first.html Change-Id: If22b90e0b5b1b289a7657ecd5adb8f2f11401f0a Story: #2002586 Task: #24322
* | | Remove moxstubout usageChuck Short2018-08-221-4/+5
| |/ |/| | | | | | | | | | | | | As of oslotest version 3.5.0 moxstub will be deprecated, so remove it where it has been used. Change-Id: I9f038428cbea07a307f08c2251eafed7ab8bbea1 Signed-off-by: Chuck Short <chucks@redhat.com>
* | Merge "Remove extra copy.deepcopy"Zuul2018-08-171-4/+1
|\ \ | |/ |/|
| * Remove extra copy.deepcopyJoshua Harlow2018-07-191-4/+1
| | | | | | | | | | | | | | | | | | This method is called recursively (ie deeply) by default so there doesn't seem to be a good reason to deepcopy over and over and over at every recusion level especially since a new output dictionary is getting created anyway. Change-Id: I644ef881e487c06dc4db77d60cfe765b0e59b547
* | import zuul job settings from project-configDoug Hellmann2018-08-031-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a mechanically generated patch to complete step 1 of moving the zuul job settings out of project-config and into each project repository. Because there will be a separate patch on each branch, the branch specifiers for branch-specific jobs have been removed. See the python3-first goal document for details: https://governance.openstack.org/tc/goals/stein/python3-first.html Change-Id: I96287db07326aed08d1f3557a6c5366277701e67 Story: #2003250
* | Update reno for stable/rockyOpenStack Release Bot2018-07-262-0/+7
|/ | | | Change-Id: I8346274c8dc281f18ae7938334adec6d5dd3780f
* Merge "Handle non-string keys appropriately"3.36.4Zuul2018-07-182-5/+18
|\
| * Handle non-string keys appropriatelyJoshua Harlow2018-07-172-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | In python dict keys can be anything that is hashable; which includes non-strings such as ints. Currently the code is blowing up with these types of keys with exceptions like: TypeError: argument of type 'int' is not iterable So to fix that handle the case where non-string keys are found. Change-Id: I4f576a089df6f68e43572bf0eee15e99f2b557fe
* | Switch to stestrVu Cong Tuan2018-07-046-13/+8
| | | | | | | | | | | | | | | | | | | | According to Openstack summit session [1], stestr is maintained project to which all Openstack projects should migrate. Let's switch to stestr as other projects have already moved to it. [1] https://etherpad.openstack.org/p/YVR-python-pti Change-Id: Ica0262653e8c18681d049acca6d5920ac38f97e6
* | Add release notes link to READMEmelissaml2018-06-211-0/+1
| | | | | | | | Change-Id: Ic64ca857fca154facbbef1e97740af52e2747834
* | Merge "Fix exception with secretutils"3.36.3Zuul2018-06-142-22/+27
|\ \
| * | Fix exception with secretutilschangxun2018-05-242-22/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. There are some problems about the test method. problem 1: Unit tests may not cover our function, it depends on the python version that performed the test. problem 2: when using function 'constant_time_compare(first, second)', 'first' and 'second' params are usually HMAC digest values, it is not appropriate to use utf-8 encoded values as mock data. 2. The previous commit `f1d332a` lead into a bug, but due to the problem 1 and the problem 2, we did not find out the error. Change-Id: I1c29bfe69f8eda60f3c5caaf3e5447dd5b69b108 Closes-Bug: #1772851
* | | fix tox python3 overridesDoug Hellmann2018-06-061-1/+7
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to default to running all tox environments under python 3, so set the basepython value in each environment. We do not want to specify a minor version number, because we do not want to have to update the file every time we upgrade python. We do not want to set the override once in testenv, because that breaks the more specific versions used in default environments like py35 and py36. Change-Id: Iba35cef6449b9c40a820114d59c1c45f56946b8d Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | Add private_key to the list of sanitized keys3.36.2Matthew Booth2018-05-111-1/+1
| | | | | | | | | | | | | | | | Nova's create keypair operation will currently log the generated keypair if debug logs are enabled. Closes-Bug: #1770683 Change-Id: I7f889f0bf254fad43b1e26d32fa145f88c668b39
* | Remove stale pip-missing-reqs tox testKenneth Giusti2018-05-021-8/+0
| | | | | | | | | | | | | | | | | | | | pip_missing_reqs tool is no longer maintained and has broken with release 10 of pip Refer to: http://lists.openstack.org/pipermail/openstack-dev/2018-April/130027.html Change-Id: I0f9170586dc4c270df282d8f7417910eec109d78
* | Capitalize OsloBen Nemec2018-04-241-2/+2
| | | | | | | | | | | | | | | | | | It's a proper name. Mostly this is just to trigger the release notes jobs again after they failed on release. Change-Id: I5ea88dfbad5b9d60d9b404cef4a586e92fb5a957
* | Trivial: Update pypi url to new url3.36.1Tovin Seven2018-04-202-3/+3
| | | | | | | | | | | | | | | | | | Pypi url changed from [1] to [2] [1] https://pypi.python.org/pypi/<package> [2] https://pypi.org/project/<package> Change-Id: I53bfd078ba2a47a5744c2ebf1354d06ad6438544