summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * Use unittest.mock instead of third party mockSean McGinnis2020-03-319-11/+8
| | | | | | | | | | | | | | | | Now that we no longer support py27, we can use the standard library unittest.mock module instead of the third party mock lib. Change-Id: I4c5451afece8dfff30aa1ec4c7e0d5eb277043fd Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* | Update hacking for Python3Andreas Jaeger2020-04-028-8/+9
|/ | | | | | | | | | | | The repo is Python 3 now, so update hacking to version 3.0 which supports Python 3. Fix problems found. Remove hacking and friends from lower-constraints, they are not needed for installation. Change-Id: I3f23bf09ef24fe34e128102c34382da98e10f5c1
* tox: Use upper-constraints for docs jobscaoyuan2020-03-111-4/+7
| | | | Change-Id: I43225fc4ed3ba471ba7097f1e317bc6ffa777a46
* Merge "tests: Convert remaining tests to mock"Zuul2020-02-281-166/+173
|\
| * tests: Convert remaining tests to mockStephen Finucane2020-02-251-166/+173
| | | | | | | | | | | | | | | | | | | | Convert remaining tests from mox to mock. This actually highlights something mock doesn't do that well - ensuring the order that things are called in. It's not a big deal and the tests are ultimately easier to grok (IMO), but it's worth highlighting. Change-Id: I0add2c96a9da510e1a9be0d6d07b7a6a33ac6528 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | Merge "Add test to check scientific notation on disk virtual size"Zuul2020-02-261-1/+3
|\ \
| * | Add test to check scientific notation on disk virtual sizeHervé Beraud2020-02-261-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we only focused tests on disk size these changes add more tests on other value which could be given and also parsed by using similar regexes. Also these changes format test name to match default format. Change-Id: I49a67c4670e14f324a52b0454e78f9149813c6a0
* | | Merge "Fix regex to correctly recognize scientific notation with QemuImgInfo"4.1.0Zuul2020-02-263-1/+11
|\ \ \ | |/ / | | / | |/ |/|
| * Fix regex to correctly recognize scientific notation with QemuImgInfoHervé Beraud2020-02-253-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | qemu 4.1.0 output shifts to scientific notation at 1000mb, breaking oslo.utils. Problem here is that the qemu-img output shifts to scientific notation: 999 => 999 MiB 1000 => 1e+03 MiB The regex in python-oslo-utils does not cover this. This issue is likely regexp parsing "disk size: 1e+03 MiB" value. These changes fix that. Change-Id: I4c016865890135023ceb497de18d75ccebd5961a Closes-Bug: 1864529
* | Flatten test caseStephen Finucane2020-02-251-86/+195
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | mock doesn't have a way to do the below pattern: foo.bar(call_arg).AndReturn(return_arg) my_call() Instead, you have to do the following: mock_foo.return_value = return_arg my_call() mock_foo.assert_call_once_with(call_arg) As such, we can't easily map the below to mock: def check_something(self): mock_foo.assert_call_once_with(call_arg) def test_foo(self): self.check_something() self.check_something() self.check_something() my_call() And we need to flatten this out, somewhat dumbly, to allow the conversion. Change-Id: I0f0e3e9ce4a410f60639c28aaadb9197aa47b492 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* imageutils: Report format specific details when using JSON output formatLee Yarwood2020-02-142-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The data held within this section is particularly useful when dealing with encrypted LUKSv1, as shown below: $ qemu-img info --output=json rbd:volumes/volume { [..] "format-specific": { "type": "luks", "data": { "ivgen-alg": "plain64", "hash-alg": "sha256", "cipher-alg": "aes-256", "uuid": "de946b24-f318-4fa6-aacf-c5e97db04609", "cipher-mode": "xts", "slots": [ { "active": true, "iters": 1966316, "key-offset": 4096, "stripes": 4000 }, { "active": false, "key-offset": 262144 }, { "active": false, "key-offset": 520192 }, { "active": false, "key-offset": 778240 }, { "active": false, "key-offset": 1036288 }, { "active": false, "key-offset": 1294336 }, { "active": false, "key-offset": 1552384 }, { "active": false, "key-offset": 1810432 } ], "payload-offset": 2068480, "master-key-iters": 479636 } }, } Unfortunately the only documentation for this is in the QEMU codebase at present, for example for LUKSv1: https://github.com/qemu/qemu/blob/d8d5fefd8657d4f7b380b3a1533340434b5b9def/qapi/crypto.json#L272-L298 Related-Bug: #1861071 Change-Id: I133da07a5a9628b8a9338556939c858afae679f4
* remove outdated header4.0.1Hervé Beraud2020-02-101-1/+0
| | | | Change-Id: I33025e633a18e6582961462e942cbdeac3a085b7
* Merge "Remove universal wheel configuration"Zuul2020-02-101-2/+0
|\
| * Remove universal wheel configurationBen Nemec2020-02-061-2/+0
| | | | | | | | | | | | | | Now that we've dropped py2 support we shouldn't be setting this anymore. Change-Id: Ib8d04a107cba50e73f4ed7fad210135c98479b5c
* | reword releasenote for py27 support droppingHervé Beraud2020-02-061-1/+1
|/ | | | Change-Id: I1fd384a0e08716cc48c2a4e7dfad28d6efa15f3c
* [ussuri][goal] Drop python 2.7 support and testing4.0.0Hervé Beraud2020-02-038-22/+11
| | | | | | | | | | | | | | OpenStack is dropping the py2.7 support in Ussuri cycle. Complete discussion & schedule can be found in - http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html - https://etherpad.openstack.org/p/drop-python2-support Ussuri Communtiy-wide goal: https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html Change-Id: If437786eb8dbba9386dd473b45dab0933812c649
* Merge "tox: Trivial cleanup"Zuul2020-01-301-9/+3
|\
| * tox: Trivial cleanupHervé Beraud2020-01-081-9/+3
| | | | | | | | | | | | | | | | | | Move 'basepython' to the top-level 'testenv'. Use the default 'install_command' https://tox.readthedocs.io/en/latest/config.html#conf-install_command Change-Id: I45981d5e80ab8ea03176ce08e119556fec078a37
* | Merge "trivial: Move setup code into setUp helper"Zuul2020-01-071-20/+7
|\ \
| * | trivial: Move setup code into setUp helperStephen Finucane2019-12-181-20/+7
| |/ | | | | | | | | | | | | | | All this stuff was being called at the beginning of each test. It belongs in 'setUp', so place it there. Change-Id: Icb50e64d47c364c3485371311abe1311502831a5 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | Ignore releasenote cache within git untracked filesHervé Beraud2019-12-201-0/+2
|/ | | | Change-Id: I5617295e7392d9bed8881796ca5179e060aa3316
* Merge "Switch to Ussuri jobs"Zuul2019-12-181-1/+1
|\
| * Switch to Ussuri jobspengyuesheng2019-10-241-1/+1
| | | | | | | | Change-Id: Ia7202ded06e1a8403aa093a73cf6e200fa03af1c
* | Merge "Bump the openstackdocstheme extension to 1.20"Zuul2019-12-023-19/+1
|\ \
| * | Bump the openstackdocstheme extension to 1.20pengyuesheng2019-11-123-19/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some options are now automatically configured by the version 1.20: - project - html_last_updated_fmt - latex_engine - latex_elements - version - release. Change-Id: Id5c6afef01c6f38cb72c3a6526352db40dcb3a87
* | | Merge "Ignore the .eggs directory"Zuul2019-12-021-0/+1
|\ \ \
| * | | Ignore the .eggs directoryDougal Matthews2019-11-211-0/+1
| | | | | | | | | | | | | | | | Change-Id: I37e614d81126a9d3c4f775d8a8f32a911b03c92b
* | | | Verify the sanitize keys are lowered3.42.1Dougal Matthews2019-11-222-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This change is preventative to ensure any keys added in the future are all lowercase. Change-Id: Ib843fe59a80b081d9d0193717ff5a980e22c81b0
* | | | Fix invalid escapes in regular expression stringsRadomir Dopieralski2019-11-211-3/+3
|/ / / | | | | | | | | | | | | | | | | | | | | | The "r" for raw strings has to repeated when several strings are concatenated, otherwise the backslash in the strings that miss the "r" are interpreted directly, and result in invalid escapes. Change-Id: I3736a40043c8aa6c36c21803bf68f842af5cd55e
* | | Make mask_dict_password case insensitive and add new patternsDougal Matthews2019-11-153-5/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Icc19b7c8bdb6a3182939d5e9fdef21288b19f43d mask_password was made case insensitive but mask_dict_password wasn't. This update makes the behaviour of these functions the same. Instead of lowering _SANITIZE_KEYS each time the source list is lowered. New password patterns from realworld logs were added to the patterns. Change-Id: Ic3ee301857630a15b9c26fd5d0fc907c43199517 Related-Bug: #1850843
* | | Merge "Make mask_password case insensitive, and add new patterns"Zuul2019-11-123-14/+64
|\ \ \ | |/ / |/| |
| * | Make mask_password case insensitive, and add new patterns3.42.0Cédric Jeanneret2019-11-053-14/+64
| |/ | | | | | | | | | | | | | | | | | | | | It appears that Mistral service logs everything, and doesn't use yet the mask_password (nor mask_dict_password) method. In order to ensure all is properly masked, we have to add some new patterns, and make it case insensitive in order to simplify and avoid duplicated entries. Change-Id: Icc19b7c8bdb6a3182939d5e9fdef21288b19f43d Related-Bug: #1850843 Signed-off-by: Cédric Jeanneret <cjeanner@redhat.com>
* | tox: Keeping going with docscaoyuan2019-10-242-4/+7
|/ | | | | | | | | | | | Sphinx 1.8 introduced [1] the '--keep-going' argument which, as its name suggests, keeps the build running when it encounters non-fatal errors. This is exceptionally useful in avoiding a continuous edit-build loop when undertaking large doc reworks where multiple errors may be introduced. [1] https://github.com/sphinx-doc/sphinx/commit/e3483e9b045 Change-Id: I7d39be84c5c8bd730119220720d2d33cb9e4ef62
* Merge "Update master for stable/train"Zuul2019-10-102-0/+7
|\
| * Update master for stable/trainOpenStack Release Bot2019-09-202-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/train. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/train. Change-Id: I1cff7414fb67be165c6d8df9b3c9d6969c7c8bd8 Sem-Ver: feature
* | Merge "Support "qemu-img info" virtual size in QEMU 4.1 and later"Zuul2019-09-302-2/+17
|\ \
| * | Support "qemu-img info" virtual size in QEMU 4.1 and laterMark Mielke2019-09-202-2/+17
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | QEMU 4.0 and earlier have output like: virtual size: 1.5M (1572864 bytes) QEMU 4.1 and later have output like: virtual size: 1.5 MiB (1572864 bytes) Adjust the regular expression to allow for optional whitespace between the magnitude and the unit. Adjust the unit parsing to support the expanded "MiB" form. Change-Id: I1f316d6982c0def3296af4835484ad2d81a87fd4 Closes-Bug: 1844050
* | Update the constraints urlpengyuesheng2019-09-291-1/+1
|/ | | | | | For more detail, see http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006478.html Change-Id: I071620b42a9e48590b21bc8bc04b079e01909451
* Add digestmod when using hmac3.41.1Alfredo Moralejo2019-08-211-1/+3
| | | | | | | | | | | | | Until Python 3.8 hmc.new() defaulted the digestmod argument to 'hmac-md5'. This was deperecated, to be removed in Python 3.8 [1], so let's get ready for new python. Also switching to more secure sha1 algorithm, using md5 anywhere may trigger alerts from automatic security tools. [1] https://docs.python.org/3.8/library/hmac.html Change-Id: I4b365cb05de98bdd498b3c2094e4a77ab3944b12
* Add Python 3 Train unit testsCorey Bryant2019-07-053-3/+3
| | | | | | | | | | | | This is a mechanically generated patch to ensure unit testing is in place for all of the Tested Runtimes for Train. See the Train python3-updates goal document for details: https://governance.openstack.org/tc/goals/train/python3-updates.html Change-Id: Iaf3ca4799bb9e78b180bbfdab26f57d88781bd42 Story: #2005924 Task: #34234
* Cap Bandit below 1.6.0 and update Sphinx requirementBen Nemec2019-05-152-2/+3
| | | | | | | | | | | | Bandit 1.6.0 accidentally changed how the exclusion list option is handled and breaks our use of it. Cap to the previous version until Bandit has fixed the problem. Sphinx 2.0 no longer works on python 2.7, so we need to start capping it there as well. Change-Id: I719a8cff50dcc0dea62db14edf7b9ab35b72facd Reference: https://github.com/PyCQA/bandit/pull/489
* Merge "Replace git.openstack.org URLs with opendev.org URLs"Zuul2019-05-032-2/+2
|\
| * Replace git.openstack.org URLs with opendev.org URLsjacky062019-04-232-2/+2
| | | | | | | | | | | | | | Thorough replacement of git.openstack.org URLs with their opendev.org counterparts. Change-Id: I90c0338f37fb6c8ed3b555b2d9d6b76aff6dad76 Closes-Bug: #1825935
* | Merge "Dropping the py35 testing"Zuul2019-05-033-3/+2
|\ \ | |/ |/|
| * Dropping the py35 testingGhanshyam Mann2019-04-153-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All the integration testing has been moved to Bionic now[1] and py3.5 is not tested runtime for Train or stable/stein[2]. As per below ML thread, we are good to drop the py35 testing now: http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005097.html [1] http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004647.html [2] https://governance.openstack.org/tc/reference/runtimes/stein.html https://governance.openstack.org/tc/reference/runtimes/train.html Change-Id: I431a9623991dfad180f0654891b930b547df2689
* | OpenDev Migration Patch3.41.0OpenDev Sysadmins2019-04-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
* | Merge "eventletutils: Optimise EventletEvent.clear()"Zuul2019-04-162-7/+27
|\ \ | |/ |/|
| * eventletutils: Optimise EventletEvent.clear()Zane Bitter2019-01-252-7/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When EventletEvent.clear() is called twice in succession without an intervening set(), there's no need to replace the underlying eventlet.event.Event object, since it has never been sent. Doing so would have woken other greenthreads waiting on the event to no particular end. When clear() is called after the event has been set(), we already did not do anything special with the existing eventlet.event.Event as we cannot call send() on it twice. We simply replace it with a new one; the code in wait() will handle the situation correctly, since it will wake up (due to the initial event having been sent) and begin waiting on the new eventlet.event.Event instead. This is consistent with the observed behaviour of threading.Event. A new unit test verifies this. Change-Id: Ibd5324926431fc760c3dd0be064324e3009cc2c2
* | Merge "Mask encryption_key_id"Zuul2019-03-272-1/+5
|\ \
| * | Mask encryption_key_idyenai2019-02-022-1/+5
| |/ | | | | | | | | Change-Id: I9e684cd8bab85728ff0117f95a30eb7dbb5bf51c Closes-Bug: #1814365
View Lorry Controller Status