diff options
Diffstat (limited to 'oslo_utils/tests/test_netutils.py')
| -rw-r--r-- | oslo_utils/tests/test_netutils.py | 41 |
1 files changed, 40 insertions, 1 deletions
diff --git a/oslo_utils/tests/test_netutils.py b/oslo_utils/tests/test_netutils.py index 28bb1d9..93fedf3 100644 --- a/oslo_utils/tests/test_netutils.py +++ b/oslo_utils/tests/test_netutils.py @@ -154,13 +154,52 @@ class NetworkUtilsTest(test_base.BaseTestCase): netutils.set_tcp_keepalive(mock_sock, False) self.assertEqual(1, len(mock_sock.mock_calls)) - def test_is_valid_ipv4(self): + @mock.patch.object(netutils, 'LOG', autospec=True) + def test_is_valid_ipv4(self, mock_log): + expected_log = 'Converting in non strict mode is deprecated. ' \ + 'You should pass strict=False if you want to preserve ' \ + 'legacy behavior' self.assertTrue(netutils.is_valid_ipv4('42.42.42.42')) self.assertFalse(netutils.is_valid_ipv4('-1.11.11.11')) self.assertFalse(netutils.is_valid_ipv4('')) + self.assertTrue(netutils.is_valid_ipv4('10')) + mock_log.warn.assert_called_with(expected_log) + mock_log.reset_mock() + self.assertTrue(netutils.is_valid_ipv4('10.10')) + mock_log.warn.assert_called_with(expected_log) + mock_log.reset_mock() + self.assertTrue(netutils.is_valid_ipv4('10.10.10')) + mock_log.warn.assert_called_with(expected_log) + mock_log.reset_mock() + self.assertTrue(netutils.is_valid_ipv4('10.10.10.10')) + mock_log.warn.assert_not_called() + mock_log.reset_mock() + self.assertFalse( + netutils.is_valid_ipv4('10', strict=True) + ) + self.assertFalse( + netutils.is_valid_ipv4('10.10', strict=True) + ) + self.assertFalse( + netutils.is_valid_ipv4('10.10.10', strict=True) + ) + mock_log.warn.assert_not_called() + mock_log.reset_mock() + self.assertTrue( + netutils.is_valid_ipv4('10', strict=False) + ) + self.assertTrue( + netutils.is_valid_ipv4('10.10', strict=False) + ) + self.assertTrue( + netutils.is_valid_ipv4('10.10.10', strict=False) + ) + mock_log.warn.assert_not_called() + mock_log.reset_mock() + def test_is_valid_ipv6(self): self.assertTrue(netutils.is_valid_ipv6('::1')) |