summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.openstack.org>2019-01-18 03:31:53 +0000
committerGerrit Code Review <review@openstack.org>2019-01-18 03:31:53 +0000
commiteff0629790af2dda13d8566a20ceee21f4a52a7a (patch)
tree5f6d687afe5ced5418b8058bff3531ab83010870
parent380bf5a47ef1bceb8b2b1c5c9f15e6c7cfdc038d (diff)
parent14a53c4d8a9d5605b14a503803859df0d6d4b820 (diff)
downloadoslo-utils-eff0629790af2dda13d8566a20ceee21f4a52a7a.tar.gz
Merge "Avoid calling eventlet.event.Event.reset()"3.40.1
-rw-r--r--oslo_utils/eventletutils.py8
-rw-r--r--oslo_utils/tests/test_eventletutils.py7
2 files changed, 6 insertions, 9 deletions
diff --git a/oslo_utils/eventletutils.py b/oslo_utils/eventletutils.py
index 1f90b6e..30fc41c 100644
--- a/oslo_utils/eventletutils.py
+++ b/oslo_utils/eventletutils.py
@@ -165,11 +165,9 @@ class EventletEvent(object):
isSet = is_set
def set(self):
- if self._set:
- self._event.reset()
-
- self._set = True
- self._event.send(True)
+ if not self._set:
+ self._set = True
+ self._event.send(True)
def wait(self, timeout=None):
with timeutils.StopWatch(timeout) as sw:
diff --git a/oslo_utils/tests/test_eventletutils.py b/oslo_utils/tests/test_eventletutils.py
index 4460649..96205f0 100644
--- a/oslo_utils/tests/test_eventletutils.py
+++ b/oslo_utils/tests/test_eventletutils.py
@@ -146,12 +146,11 @@ class EventletUtilsTest(test_base.BaseTestCase):
self.assertTrue(hasattr(e_event, method))
# Ensure set() allows multiple invocations, same as in
- # threading implementation. Must call reset on underlying
- # Event before reusing it
+ # threading implementation.
e_event.set()
- self.assertEqual(0, mock_eventlet.event.Event().reset.call_count)
+ self.assertTrue(e_event.isSet())
e_event.set()
- self.assertEqual(1, mock_eventlet.event.Event().reset.call_count)
+ self.assertTrue(e_event.isSet())
def test_event_no_timeout(self):
event = eventletutils.EventletEvent()