Fix serializer tests

The serializer tests occasionally fail since the order of a dict() is
not guaranteed.  Explicitly compute the serializer instead of
pre-computing it.

Change-Id: I74f8fa227e6508491b5982fe7e2841683724540c

1 files changed, 4 insertions, 4 deletions

diff --git a/oslo_messaging/tests/rpc/test_client.py b/oslo_messaging/tests/rpc/test_client.py
index 6123087..e955167 100755
--- a/oslo_messaging/tests/rpc/test_client.py
+++ b/oslo_messaging/tests/rpc/test_client.py
@@ -348,13 +348,13 @@ class TestSerializer(test_utils.BaseTestCase):
         serializer.deserialize_entity = mock.Mock()
         serializer.serialize_context = mock.Mock()
 
+        def _stub(ctxt, arg):
+            return 's' + arg
+
         msg = dict(method='foo', args=dict())
-        expected_side_effect = []
         for k, v in self.args.items():
             msg['args'][k] = 's' + v
-            expected_side_effect.append('s' + v)
-
-        serializer.serialize_entity.side_effect = expected_side_effect
+        serializer.serialize_entity.side_effect = _stub
 
         if self.call:
             serializer.deserialize_entity.return_value = 'd' + self.retval