Fixup list types handling tuples

The addition to enforce_type now tries to convert the
value (even if enforcing is off) which can result in
types the list class was not handling now being handled.

One example is someone setting an override for a tuple
go through the same code path as for lists.

Related-Bug: #1635717

Co-Authored-By: Adam Harwell <flux.adam@gmail.com>
Change-Id: Icdce83d731642724ea3ce6920b84c25d61bd63c5

2 files changed, 13 insertions, 8 deletions

diff --git a/oslo_config/tests/test_types.py b/oslo_config/tests/test_types.py
index 7df0f1d..2389d9b 100644
--- a/oslo_config/tests/test_types.py
+++ b/oslo_config/tests/test_types.py
@@ -503,6 +503,10 @@ class ListTypeTests(TypeTestHelper, unittest.TestCase):
         self.assertConvertedValue(' foo bar ',
                                   ['foo bar'])
 
+    def test_tuple_of_values(self):
+        self.assertConvertedValue(('foo', 'bar'),
+                                  ['foo', 'bar'])
+
     def test_list_of_values(self):
         self.assertConvertedValue(' foo bar, baz ',
                                   ['foo bar',
diff --git a/oslo_config/types.py b/oslo_config/types.py
index e4f4e02..9a3bda1 100644
--- a/oslo_config/types.py
+++ b/oslo_config/types.py
@@ -440,23 +440,24 @@ class List(ConfigType):
         self.bounds = bounds
 
     def __call__(self, value):
-        if isinstance(value, list):
-            return value
+        if isinstance(value, (list, tuple)):
+            return list(value)
 
-        result = []
         s = value.strip()
-
         if self.bounds:
             if not s.startswith('['):
                 raise ValueError('Value should start with "["')
             if not s.endswith(']'):
                 raise ValueError('Value should end with "]"')
             s = s[1:-1]
+        if s:
+            values = s.split(',')
+        else:
+            values = []
+        if not values:
+            return []
 
-        if s == '':
-            return result
-
-        values = s.split(',')
+        result = []
         while values:
             value = values.pop(0)
             while True: