| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow up to change
I8e4e5afc773d53dee9c1c24951bb07a45ddc2f1a which fixed an issue with
validation when the topmost patch after a Zuul rebase is a merge
patch.
We need to also use the $commit_hash variable for the check for
stable-only patches, else it will incorrectly fail because it is
checking the merge patch's commit message.
Change-Id: Ia725346b65dd5e2f16aa049c74b45d99e22b3524
(cherry picked from commit 1e10461c71cb78226824988b8c903448ba7a8a76)
(cherry picked from commit f1e4f6b078baf72e83cd7341c380aa0fc511519e)
(cherry picked from commit e676a480544b3fa71fcaa984a658e2131b7538c5)
(cherry picked from commit 115b43ed3e9514d9e4fb41da5582f0b185ecd10a)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE(elod.illes): This is a combination of 2 commits: the cherry-pick
hash checker script and a fix for the script.
1. Check cherry-pick hashes in pep8 tox target
This adds a tools/ script that checks any cherry-picked hashes
on the current commit (or a provided commit) to make sure that
all the hashes exist on at least master or stable/.* branches.
This should help avoid accidentally merging stable backports
where one of the hashes along the line has changed due to conflicts.
2. Fix cherry-pick check for merge patch
Cherry-pick check script validates the proposed patch's commit message.
If a patch is not on top of the given branch then Zuul rebases it to
the top and the patch becomes a merge patch. In this case the script
validates the merge patch's commit message instead of the original
patch's commit message and fails.
This fix selects the parent of the patch if it is a merge patch.
(cherry picked from commit c7c48c6f52c9159767b60a4576ba37726156a5f7)
(cherry picked from commit 02f213b831d8e1d4a1d8ebb18d1260571fe20b84)
(cherry picked from commit 7a5111ba2943014b6fd53a5fe7adcd9bc445315e)
Change-Id: I4afaa0808b75cc31a8dd14663912c162281a1a42
(cherry picked from commit aebc829c4e0d39a160eaaa5ad949c1256c8179e6)
(cherry picked from commit 5cacfaab82853241022d3a2a0734f82dae59a34b)
(cherry picked from commit d307b964ce380f2fa57debc6c4c8346ac8736afe)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A couple places in the Xen code have been using syntax that is
python2-specific. This replaces those instances with code that will
work in both python2 and python3.
PEP 3108 [1] moves urllib.urlopen to urllib.request.urlopen. The six
module is used in order to work in both python2 and python3 [2].
PEP 3110 [3] changed the grammar for except clauses, such that the
'as' keyword is now required in place of a comma when specifying an
exception variable.
[1] https://www.python.org/dev/peps/pep-3108/
[2] https://pythonhosted.org/six/#module-six.moves.urllib.request
[3] https://www.python.org/dev/peps/pep-3110/
Change-Id: I1235d767718a4207f4cef3e5b140319d003ad7b0
|
|
|
|
|
|
|
| |
This ensures it will get run in the gate.
Change-Id: I923c39d3115b595b8de94e85d2977eb7782d98e2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
|
|
|
|
|
|
|
|
| |
This is not needed since reno 2.1.0 (commit f8fc8f97) [1].
[1] https://github.com/openstack/reno/commit/f8fc8f97ff20026582742e3e7838cdd0ed5cad68
Change-Id: I66ba0e0835970b965acce00ba69d143bd4471037
|
|
|
|
|
|
|
|
|
|
| |
These were deprecated in Queens:
Id793ac2c5cdc5dc473f95eac53b77617a1e389da
And can now be removed.
Change-Id: I27518d1154ec09c57700905bc58ae6a3ce1d8049
|
|
|
|
|
|
|
|
|
|
|
| |
Nova switched to using stestr for all it's in tree testing except for
the coverage job. This commit updates that job so it also uses stestr
and cleans up the last bits of testr setup left in tree. As part of
this change this moves all the one off per job configuration into the
tox job definitions instead of hiding it in either the .stestr.conf or
in a wrapper script.
Change-Id: I36e0e791d485b44641a1ed8770eca8e95aca19be
|
|
|
|
|
|
|
|
|
| |
For xenapi driver, there needs to be some way to delete cached
images based on when they were created. add an optional arg to
control delete operation.
Change-Id: I24fc45e989aa951aab55a261fce77f7e3667d988
Closes-bug: 1481689
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since ostestr switched to running stestr under the covers, we lost the
old magic setting of the environment variables via .testr.conf for
capturing stderr/stdout and the test timeout. This makes the unit,
functional, and api-samples envs consistent with the py27 env that was
already updated to set those variables.
This also updates the pretty_tox3.sh script to run stestr directly.
Change-Id: I27fa9b7e25c1a1dc921653eec84864423f898a85
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Two files are removed.
'ebtables.workaround' was required for libvirt < 1.2.11 for the reasons
described in the file itself. We no longer support this version of
libvirt, thus, the workaround can be removed.
'regression_tester' is a tool for running tests in a patch against old
code, to ensure the tests validate what the patch is supposed to be
fixing. This is unmaintained and is not referenced anywhere, and should
therefore be removed as it's likely bitrotted (or will do so).
Change-Id: Iac7f16ff4c178b5e71b786c332ca46a78bef5e3c
TrivialFix
|
| |
| |
| |
| |
| |
| | |
Because those blank lines sure are annoying.
Change-Id: I7b73536a89d18e0752651c198018eff6cc8b0e57
|
| |
| |
| |
| |
| |
| |
| | |
If there is no api reference for some placement API method
tox -e placement-api-ref will fail now.
Change-Id: Ifefedcd51f1f8d5e741ef6d02b7a0879a185e05f
|
|/
|
|
|
|
|
|
|
| |
XenServer 6.0 has long since been replaced and the bug was fixed in 6.1
[1]. No need to keep this legacy script around.
[1] https://bugs.launchpad.net/nova/+bug/1103158/comments/1
Change-Id: I8c41e88281aaf4250859622142a2f03f4452e1be
|
|
|
|
|
|
|
|
|
|
|
| |
Some time ago the placement-api-ref source structure was changed
(Ia2fd62ae7f401cad34ee7c2b355c9a5ab1c93f6b) to use inc-files istead of
putting all in index.rst, but that change broke placement_api_docs.py.
This change modifies placement_api_docs.py to go through all *.inc files
in placement-api-ref directory and scan for the "rest method" header.
Change-Id: I60150ab51173934f848662499dcf6af18625697e
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This consists of a duplicate of the [nova-]api-ref setup and
conf.py along with tooling to fail the tox -edocs target when
a route that is defined in
nova.api.openstack.placement.handler.ROUTE_DECLARATIONS is not
present in placement-api-ref/source/index.rst.
tools/placement_api_docs.py will report which routes are missing.
Though completely gameable (as demonstrated in the current lame
index.rst) it's better than nothing and provides some useful
structuring on what to do next. It's also the case that the 'docs'
target in tox is not part of gating.
The response for GET / is in place with the necessary
parameters.yaml for it to be correctly described. The 'get-root.json'
file provides the JSON of the expected response. The expectation is
that later commits will add information for other urls and their
JSON files will be named method-path-separated-by-dash.json with a
request/response qualifier as necessary.
Followup patches will add other routes.
A new parameters.yaml is used instead of reusing the one from
api-ref as there isn't a lot of expected overlap and having a
separate file will ease eventual extraction.
Running tox -eplacement-api-ref will generate the docs for review,
with output in placement-api-ref/build/html/index.html.
This will be hooked up with CI to deploy the generated docs,
eventually.
Change-Id: Ifb4d91d39db0e49b55952e37cdfc9f63dcd37aa3
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use ostestr as runner instead of the custome pretty_tox.sh script
(pretty much removed everywhere). pretty_tox3.sh is just a wrapper
for ostestr but it could be probably removed as well going forward.
Also remove the tempest-lib dependency, which originally provided
subunit-trace (now from os-testr).
Change-Id: I4390964ce83167d634b80f696e82a0e199582ce6
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
oslo.log deprecate config option verbose since aug 1, 2015 in review:
in https://review.openstack.org/#/c/206437/
That was a long time ago so it should be possible to remove it now. This
was already merged once but had to be reverted because some projects
were still relying on it. Oslo team plan to remove it, so we need clean
up its usage before removing it.
Closes-Bug: #1663570
Change-Id: I072e1078486f50cebea92695ff46c1af879eb23d
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This was used by the 'run_tests.sh' script, which has long since been
removed. There appears to be something similar built into ostestr [1]
should people care about this (I suspect they don't).
[1] https://github.com/openstack/os-testr/blob/0.8.0/os_testr/utils/colorizer.py
Change-Id: I5634b3f75fa2b392a2f49a61b7b46a299bbcd2fd
|
|\ \ \
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Nothing appears to use this any more. No point in keeping it around.
Change-Id: I7150c78f55fd2eb639ed85c868d38461219fda12
|
|\ \ \
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
tox has long since usurped this as the preferred approach to development
and testing.
Change-Id: I4baa1688b88135b71e1e04b4aede6d6d0197504b
|
|\ \ \
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Whatever function this script served in the past, it has long outlived
its usefulness in the age of neutron.
Change-Id: I0e5b0e0a49ee26bddbfce456aa91ffe78f62f34d
|
|\ \ \
| |/ / |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
This relies on the 'run_tests.sh' script, which has long since been
removed. git-review will do this for us so there's not much point in
keeping this around now.
Change-Id: Ie3edfa1cefeea94c36cf5646fcfae6ad4b3d8d84
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add simple script to setup mysql and postgresql databases, this script
can be run by users during testing and will be run by CI systems for
specific setup before running unit tests. This is exactly what is
currently done by OpenStack CI in project-config.
This allows to change in project-config the python-db jobs to
python-jobs since python-jobs will call this script initially.
See also
http://lists.openstack.org/pipermail/openstack-dev/2016-November/107784.html
Update devref for this.
Needed-By: Iea42a0525b2c5a5cdbf8604eb23a6e7b029f6b48
Change-Id: Ie9bae659077dbe299eea131572117036065bdccf
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
XenServer has released os-xenapi lib on pypi, this patch is to
use os-xenapi in nova project. In this patch, we only change
the usage of XenAPI to os-xenapi and fix unit tests. In the next
patch, we will delete those unused files.
Partially-Implements: blueprint add-os-xenapi-library
Depends-On: Ic327135b893a77672fd42af919f47f181e932773
Change-Id: I424dfcd507c4b7fbeea5245cc1c234dec01d5781
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
We prevent a lot of tests from getting run on tools/ changes given
that most of that is unrelated to running any tests. By having the
gate hooks in that directory it made for somewhat odd separation of
what is test sensitive and what is not.
This moves things to the gate/ top level directory, and puts a symlink
in place to handle project-config compatibility until that can be
updated.
Change-Id: Iec9e89f0380256c1ae8df2d19c547d67bbdebd65
|
|
|
|
|
|
|
| |
Add Python 3.5 functional tests tox envlist, this is
needed by python 3.5 functional tests Jenkins job.
Change-Id: I1bba877fcc2c1f2140cbbba2bc6e6c20d7972615
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As per OpenStack licensing guide lines [1]:
[H102 H103] Newly contributed Source Code should be licensed under
the Apache 2.0 license.
[H104] Files with no code shouldn't contain any license header nor
comments, and must be left completely empty.
[1] http://docs.openstack.org/developer/hacking/#openstack-licensing
Change-Id: I74d25d88ac285c456cbb8874deb000ed782c2192
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When 'tox -ereleasenotes' is run, the releasenotes are built from
the committed notes. We have a script that displays a reminder when
it detects uncommitted notes. It doesn't, however, detect newly
added notes or untracked notes.
This adds detection of added and untracked notes for displaying
the reminder message.
Change-Id: I5164f0089eae4a95bc3e68cd3b515ef23556b227
|
|/
|
|
|
|
|
| |
This helps with automating to know when it's done. Update our own
post-test-hook to use it.
Change-Id: I61c3b187edab3e0e612470735eecd2db59028413
|
|
|
|
|
|
|
|
|
|
|
|
| |
The archive_deleted_rows command in nova-manage is often-broken and
not well tested by us. We can test it to some degree in functional tests,
but running it against a real database with real deleted stuff in it
is a good idea. This adds a post-test hook and runs the archive so that
after a full test run in the gate, we'll see the output. Later, we should
make a failed run of this fatal, but for now, just run it so we can see
how close we are to being able to gate on it.
Change-Id: I16b2e00eede6af455cb74ca4e6ca951d56fdbcbc
|
|
|
|
|
|
|
|
|
|
| |
Following OpenStack Style Guidelines:
http://docs.openstack.org/developer/hacking/#dictionaries-lists
Using locals() for formmatting strings is not clear as using explicit dictionaries
and can hire errors during refactoring.
Change-Id: If3930d62fea166760161eaa3bdf85efca95be121
|
|
|
|
|
|
|
|
|
| |
A bad release note slipped through because the bash script
wasn't returing the actual results. This fixes the script
and the busted release note.
Change-Id: Id32557f34121fe82fac21d089e4117a72ff585e5
Closes-Bug: #1610312
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I9b58a1a1128921dd4de07a65b5615d1a0fe3fea9
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| | |
This patch introduces a new tools/releasenotes_tox.sh script for the
tox -e releasenotes test environment. It will detect when there are
uncommitted release notes and print a reminder to commit them.
Change-Id: I54af12d7eb20b37263e23443900745884cffacea
|
|/
|
|
|
|
| |
TrivialFix
Change-Id: Ice05cc9848bc0b647ee20cfad20c23b47f8fedbd
|
|
|
|
|
|
|
|
|
|
| |
Made corrections in import order as per OpenStack import standards [1].
[1] http://docs.openstack.org/developer/hacking/#import-order-template
TrivialFix
Change-Id: Ieb63c7fc5becc68db8d68b3e6847321e77ceeed3
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For py27 you can simply run specific tests by calling
tox -e py27 nova.tests.unit.test_something
Add a similiar option for the py34 environment. This will skip the
blacklist of tests that would otherwise be ignored for python3.
Change-Id: I9bf5901afed4abf592e1aaff2f4820b9e3abc671
|