summaryrefslogtreecommitdiff
path: root/nova/virt/libvirt/volume/volume.py
diff options
context:
space:
mode:
authorSpencer Yu <yushb@gohighsec.com>2016-12-20 23:43:53 -0800
committerSpencer Yu <yushb@gohighsec.com>2017-01-09 09:11:00 +0000
commit70730c09abd3e0e7d0162dd1a942c6671c57f0eb (patch)
tree2cd21731d71bb7049092f42879726c86d44cced2 /nova/virt/libvirt/volume/volume.py
parentf55815b2f90b934801a88e10bf750876b0587328 (diff)
downloadnova-70730c09abd3e0e7d0162dd1a942c6671c57f0eb.tar.gz
[2/3]Replace six.iteritems() with .items()
1.As mentioned in [1], we should avoid using six.iteritems to achieve iterators. We can use dict.items instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2.In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html The patch list: 1. cells. 2. compute api. 3. image. 4. network. 5. objects. 6. scheduler. 7. virt. 8. other resources. Partial-Implements: blueprint replace-iteritems-with-items Change-Id: Ic6e469eb80ee1774de1374bb36f38b5134b6b311
Diffstat (limited to 'nova/virt/libvirt/volume/volume.py')
-rw-r--r--nova/virt/libvirt/volume/volume.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/nova/virt/libvirt/volume/volume.py b/nova/virt/libvirt/volume/volume.py
index fff56c7931..d4f0307bb3 100644
--- a/nova/virt/libvirt/volume/volume.py
+++ b/nova/virt/libvirt/volume/volume.py
@@ -17,7 +17,7 @@
"""Volume drivers for libvirt."""
from oslo_log import log as logging
-import six
+
import nova.conf
from nova import exception
@@ -72,7 +72,7 @@ class LibvirtBaseVolumeDriver(object):
'read_iops_sec', 'write_iops_sec']
specs = data['qos_specs']
if isinstance(specs, dict):
- for k, v in six.iteritems(specs):
+ for k, v in specs.items():
if k in tune_opts:
new_key = 'disk_' + k
setattr(conf, new_key, v)