summaryrefslogtreecommitdiff
path: root/nova/privsep
diff options
context:
space:
mode:
authorMichael Still <mikal@stillhq.com>2019-04-01 08:27:01 +0000
committerMichael Still <mikal@stillhq.com>2019-04-04 20:44:01 +0000
commit504099e4e2bdd3fcda661d53956c303af88e8dfb (patch)
treed2c7bd2969e1a879a5a3c229c5e4a520edeab8bc /nova/privsep
parent82c79ceac30d7b97d68c2d71bdd0aae8c7038811 (diff)
downloadnova-504099e4e2bdd3fcda661d53956c303af88e8dfb.tar.gz
Add test coverage for nova.privsep.qemu.
Now that we have a fixture that makes this easier, pay down some technical debt. Change-Id: I74491ecce3527fe375d219f5c6bc87123f796c44
Diffstat (limited to 'nova/privsep')
-rw-r--r--nova/privsep/qemu.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/nova/privsep/qemu.py b/nova/privsep/qemu.py
index 8c22d689cb..5880fb1775 100644
--- a/nova/privsep/qemu.py
+++ b/nova/privsep/qemu.py
@@ -55,6 +55,8 @@ def unprivileged_convert_image(source, dest, in_format, out_format,
# just like 'writethrough', calls fsync(2)|fdatasync(2), which
# ensures to safely write the data to the physical disk.
+ # NOTE(mikal): there is an assumption here that the source and destination
+ # are in the instances_path. Is that worth enforcing?
if nova.privsep.utils.supports_direct_io(instances_path):
cache_mode = 'none'
else: