summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVishvananda Ishaya <vishvananda@gmail.com>2010-07-27 13:08:22 -0700
committerVishvananda Ishaya <vishvananda@gmail.com>2010-07-27 13:08:22 -0700
commitfe4ba7d896347485347306b9702ebb5daa2afebf (patch)
tree8561513a5f0de3ad77f68141034995a477995711
parent754db8ef1ceb84fa9a1f44bfc6c5c6bbd99cd7e1 (diff)
parenta5f4a865b537d95acf5f02458824f95d30aac261 (diff)
downloadnova-fe4ba7d896347485347306b9702ebb5daa2afebf.tar.gz
merged trunk
-rw-r--r--.bzrignore1
-rw-r--r--.gitignore1
-rw-r--r--Makefile27
-rwxr-xr-xbin/nova-api2
-rwxr-xr-xbin/nova-dhcpbridge2
-rwxr-xr-xbin/nova-manage10
-rwxr-xr-xbin/nova-rsapi12
-rw-r--r--debian/nova-api.conf1
-rw-r--r--debian/nova-common.install5
-rw-r--r--debian/nova-compute.conf1
-rw-r--r--debian/nova-dhcpbridge.conf (renamed from debian/nova-dhcp.conf)1
-rw-r--r--debian/nova-objectstore.conf1
-rw-r--r--debian/nova-volume.conf1
-rw-r--r--nova/auth/ldapdriver.py481
-rw-r--r--nova/auth/manager.py809
-rw-r--r--nova/auth/rbac.py2
-rw-r--r--nova/auth/signer.py8
-rw-r--r--nova/auth/users.py974
-rw-r--r--nova/cloudpipe/api.py2
-rw-r--r--nova/cloudpipe/pipelib.py4
-rw-r--r--nova/compute/linux_net.py2
-rw-r--r--nova/compute/network.py14
-rw-r--r--nova/compute/service.py25
-rw-r--r--nova/endpoint/admin.py14
-rwxr-xr-xnova/endpoint/api.py4
-rw-r--r--nova/endpoint/cloud.py6
-rw-r--r--nova/endpoint/rackspace.py6
-rw-r--r--nova/flags.py1
-rw-r--r--nova/objectstore/handler.py52
-rw-r--r--nova/tests/access_unittest.py6
-rw-r--r--nova/tests/api_unittest.py31
-rw-r--r--nova/tests/auth_unittest.py (renamed from nova/tests/users_unittest.py)101
-rw-r--r--nova/tests/cloud_unittest.py15
-rw-r--r--nova/tests/compute_unittest.py3
-rw-r--r--nova/tests/fake_flags.py2
-rw-r--r--nova/tests/model_unittest.py3
-rw-r--r--nova/tests/network_unittest.py95
-rw-r--r--nova/tests/objectstore_unittest.py116
-rw-r--r--nova/tests/real_flags.py1
-rw-r--r--run_tests.py2
-rw-r--r--tools/install_venv.py94
-rw-r--r--tools/pip-requires15
-rwxr-xr-xtools/with_venv.sh4
43 files changed, 1782 insertions, 1175 deletions
diff --git a/.bzrignore b/.bzrignore
index 93fc868a3a..c3a502a1a4 100644
--- a/.bzrignore
+++ b/.bzrignore
@@ -1 +1,2 @@
run_tests.err.log
+.nova-venv
diff --git a/.gitignore b/.gitignore
index 9db87ac294..2afc7a32c6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,3 +9,4 @@ keys
build/*
build-stamp
nova.egg-info
+.nova-venv
diff --git a/Makefile b/Makefile
new file mode 100644
index 0000000000..fa11cf335d
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,27 @@
+venv=.nova-venv
+with_venv=tools/with_venv.sh
+
+build:
+ # Nothing to do
+
+test: $(venv)
+ $(with_venv) python run_tests.py
+
+test-system:
+ python run_tests.py
+
+clean:
+ rm -rf _trial_temp
+ rm -rf keys
+ rm -rf instances
+ rm -rf networks
+ rm -f run_tests.err.log
+
+clean-all: clean
+ rm -rf $(venv)
+
+$(venv):
+ @echo "You need to install the Nova virtualenv before you can run this."
+ @echo ""
+ @echo "Please run tools/install_venv.py"
+ @exit 1
diff --git a/bin/nova-api b/bin/nova-api
index 26f5dbc877..1f2009c307 100755
--- a/bin/nova-api
+++ b/bin/nova-api
@@ -29,7 +29,7 @@ from nova import flags
from nova import rpc
from nova import server
from nova import utils
-from nova.auth import users
+from nova.auth import manager
from nova.compute import model
from nova.endpoint import admin
from nova.endpoint import api
diff --git a/bin/nova-dhcpbridge b/bin/nova-dhcpbridge
index d15924e57d..c519c6ccb7 100755
--- a/bin/nova-dhcpbridge
+++ b/bin/nova-dhcpbridge
@@ -78,7 +78,7 @@ def main():
FLAGS.network_size = 32
FLAGS.fake_libvirt=True
FLAGS.fake_network=True
- FLAGS.fake_users = True
+ FLAGS.auth_driver='nova.auth.ldapdriver.FakeLdapDriver'
action = argv[1]
if action in ['add','del','old']:
mac = argv[2]
diff --git a/bin/nova-manage b/bin/nova-manage
index 56f89ce30f..b0f0029edf 100755
--- a/bin/nova-manage
+++ b/bin/nova-manage
@@ -27,7 +27,7 @@ import time
from nova import flags
from nova import utils
-from nova.auth import users
+from nova.auth import manager
from nova.compute import model
from nova.compute import network
from nova.cloudpipe import pipelib
@@ -42,7 +42,7 @@ class NetworkCommands(object):
class VpnCommands(object):
def __init__(self):
- self.manager = users.UserManager.instance()
+ self.manager = manager.AuthManager()
self.instdir = model.InstanceDirectory()
self.pipe = pipelib.CloudPipe(cloud.CloudController())
@@ -90,7 +90,7 @@ class VpnCommands(object):
class RoleCommands(object):
def __init__(self):
- self.manager = users.UserManager.instance()
+ self.manager = manager.AuthManager()
def add(self, user, role, project=None):
"""adds role to user
@@ -113,7 +113,7 @@ class RoleCommands(object):
class UserCommands(object):
def __init__(self):
- self.manager = users.UserManager.instance()
+ self.manager = manager.AuthManager()
def __print_export(self, user):
print 'export EC2_ACCESS_KEY=%s' % user.access
@@ -153,7 +153,7 @@ class UserCommands(object):
class ProjectCommands(object):
def __init__(self):
- self.manager = users.UserManager.instance()
+ self.manager = manager.AuthManager()
def add(self, project, user):
"""adds user to project
diff --git a/bin/nova-rsapi b/bin/nova-rsapi
index 5cbe2d8c11..306a1fc603 100755
--- a/bin/nova-rsapi
+++ b/bin/nova-rsapi
@@ -4,20 +4,20 @@
# Copyright 2010 United States Government as represented by the
# Administrator of the National Aeronautics and Space Administration.
# All Rights Reserved.
-#
+#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
-#
+#
# http://www.apache.org/licenses/LICENSE-2.0
-#
+#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""
- WSGI daemon for the main API endpoint.
+ WSGI daemon for the main API endpoint.
"""
import logging
@@ -28,14 +28,14 @@ from nova import flags
from nova import rpc
from nova import server
from nova import utils
-from nova.auth import users
+from nova.auth import manager
from nova.endpoint import rackspace
FLAGS = flags.FLAGS
flags.DEFINE_integer('cc_port', 8773, 'cloud controller port')
def main(_argv):
- user_manager = users.UserManager()
+ user_manager = manager.AuthManager()
api_instance = rackspace.Api(user_manager)
conn = rpc.Connection.instance()
rpc_consumer = rpc.AdapterConsumer(connection=conn,
diff --git a/debian/nova-api.conf b/debian/nova-api.conf
index d0b7968782..3e6c056ad5 100644
--- a/debian/nova-api.conf
+++ b/debian/nova-api.conf
@@ -3,4 +3,3 @@
--keys_path=/var/lib/nova/keys
--networks_path=/var/lib/nova/networks
--dhcpbridge_flagfile=/etc/nova/nova-dhcpbridge.conf
---fake_users=1
diff --git a/debian/nova-common.install b/debian/nova-common.install
index 9b1bbf1473..93251363a5 100644
--- a/debian/nova-common.install
+++ b/debian/nova-common.install
@@ -1,10 +1,9 @@
-bin/nova-manage usr/bin
-debian/nova-manage.conf etc/nova
+bin/nova-manage usr/bin
+debian/nova-manage.conf etc/nova
nova/auth/novarc.template usr/share/nova
nova/cloudpipe/client.ovpn.template usr/share/nova
nova/compute/libvirt.xml.template usr/share/nova
nova/compute/interfaces.template usr/share/nova
-usr/lib/python*/*-packages/nova/*
CA/openssl.cnf.tmpl var/lib/nova/CA
CA/geninter.sh var/lib/nova/CA
CA/genrootca.sh var/lib/nova/CA
diff --git a/debian/nova-compute.conf b/debian/nova-compute.conf
index d862f23282..11de13ff65 100644
--- a/debian/nova-compute.conf
+++ b/debian/nova-compute.conf
@@ -5,4 +5,3 @@
--libvirt_xml_template=/usr/share/nova/libvirt.xml.template
--vpn_client_template=/usr/share/nova/client.ovpn.template
--credentials_template=/usr/share/nova/novarc.template
---fake_users=1
diff --git a/debian/nova-dhcp.conf b/debian/nova-dhcpbridge.conf
index 0aafe7549b..68cb8903e4 100644
--- a/debian/nova-dhcp.conf
+++ b/debian/nova-dhcpbridge.conf
@@ -1,2 +1 @@
--networks_path=/var/lib/nova/networks
---fake_users=1
diff --git a/debian/nova-objectstore.conf b/debian/nova-objectstore.conf
index 03f5df051e..8eca397159 100644
--- a/debian/nova-objectstore.conf
+++ b/debian/nova-objectstore.conf
@@ -1,6 +1,5 @@
--daemonize=1
--ca_path=/var/lib/nova/CA
--keys_path=/var/lib/nova/keys
---fake_users=1
--images_path=/var/lib/nova/images
--buckets_path=/var/lib/nova/buckets
diff --git a/debian/nova-volume.conf b/debian/nova-volume.conf
index 7899e30c40..57e3411a05 100644
--- a/debian/nova-volume.conf
+++ b/debian/nova-volume.conf
@@ -1,5 +1,4 @@
--ca_path=/var/lib/nova/CA
--keys_path=/var/lib/nova/keys
---fake_users=1
--images_path=/var/lib/nova/images
--buckets_path=/var/lib/nova/buckets
diff --git a/nova/auth/ldapdriver.py b/nova/auth/ldapdriver.py
new file mode 100644
index 0000000000..1591c88e90
--- /dev/null
+++ b/nova/auth/ldapdriver.py
@@ -0,0 +1,481 @@
+# vim: tabstop=4 shiftwidth=4 softtabstop=4
+
+# Copyright 2010 United States Government as represented by the
+# Administrator of the National Aeronautics and Space Administration.
+# All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+"""
+Auth driver for ldap. Includes FakeLdapDriver.
+
+It should be easy to create a replacement for this driver supporting
+other backends by creating another class that exposes the same
+public methods.
+"""
+
+import logging
+import sys
+
+from nova import exception
+from nova import flags
+
+FLAGS = flags.FLAGS
+flags.DEFINE_string('ldap_url', 'ldap://localhost',
+ 'Point this at your ldap server')
+flags.DEFINE_string('ldap_password', 'changeme', 'LDAP password')
+flags.DEFINE_string('ldap_user_dn', 'cn=Manager,dc=example,dc=com',
+ 'DN of admin user')
+flags.DEFINE_string('ldap_user_unit', 'Users', 'OID for Users')
+flags.DEFINE_string('ldap_user_subtree', 'ou=Users,dc=example,dc=com',
+ 'OU for Users')
+flags.DEFINE_string('ldap_project_subtree', 'ou=Groups,dc=example,dc=com',
+ 'OU for Projects')
+flags.DEFINE_string('role_project_subtree', 'ou=Groups,dc=example,dc=com',
+ 'OU for Roles')
+
+# NOTE(vish): mapping with these flags is necessary because we're going
+# to tie in to an existing ldap schema
+flags.DEFINE_string('ldap_cloudadmin',
+ 'cn=cloudadmins,ou=Groups,dc=example,dc=com', 'cn for Cloud Admins')
+flags.DEFINE_string('ldap_itsec',
+ 'cn=itsec,ou=Groups,dc=example,dc=com', 'cn for ItSec')
+flags.DEFINE_string('ldap_sysadmin',
+ 'cn=sysadmins,ou=Groups,dc=example,dc=com', 'cn for Sysadmins')
+flags.DEFINE_string('ldap_netadmin',
+ 'cn=netadmins,ou=Groups,dc=example,dc=com', 'cn for NetAdmins')
+flags.DEFINE_string('ldap_developer',
+ 'cn=developers,ou=Groups,dc=example,dc=com', 'cn for Developers')
+
+
+# TODO(vish): make an abstract base class with the same public methods
+# to define a set interface for AuthDrivers. I'm delaying
+# creating this now because I'm expecting an auth refactor
+# in which we may want to change the interface a bit more.
+class LdapDriver(object):
+ """Ldap Auth driver
+
+ Defines enter and exit and therefore supports the with/as syntax.
+ """
+ def __init__(self):
+ """Imports the LDAP module"""
+ self.ldap = __import__('ldap')
+
+ def __enter__(self):
+ """Creates the connection to LDAP"""
+ self.conn = self.ldap.initialize(FLAGS.ldap_url)
+ self.conn.simple_bind_s(FLAGS.ldap_user_dn, FLAGS.ldap_password)
+ return self
+
+ def __exit__(self, type, value, traceback):
+ """Destroys the connection to LDAP"""
+ self.conn.unbind_s()
+ return False
+
+ def get_user(self, uid):
+ """Retrieve user by id"""
+ attr = self.__find_object(self.__uid_to_dn(uid),
+ '(objectclass=novaUser)')
+ return self.__to_user(attr)
+
+ def get_user_from_access_key(self, access):
+ """Retrieve user by access key"""
+ query = '(accessKey=%s)' % access
+ dn = FLAGS.ldap_user_subtree
+ return self.__to_user(self.__find_object(dn, query))
+
+ def get_key_pair(self, uid, key_name):
+ """Retrieve key pair by uid and key name"""
+ dn = 'cn=%s,%s' % (key_name,
+ self.__uid_to_dn(uid))
+ attr = self.__find_object(dn, '(objectclass=novaKeyPair)')
+ return self.__to_key_pair(uid, attr)
+
+ def get_project(self, pid):
+ """Retrieve project by id"""
+ dn = 'cn=%s,%s' % (pid,
+ FLAGS.ldap_project_subtree)
+ attr = self.__find_object(dn, '(objectclass=novaProject)')
+ return self.__to_project(attr)
+
+ def get_users(self):
+ """Retrieve list of users"""
+ attrs = self.__find_objects(FLAGS.ldap_user_subtree,
+ '(objectclass=novaUser)')
+ return [self.__to_user(attr) for attr in attrs]
+
+ def get_key_pairs(self, uid):
+ """Retrieve list of key pairs"""
+ attrs = self.__find_objects(self.__uid_to_dn(uid),
+ '(objectclass=novaKeyPair)')
+ return [self.__to_key_pair(uid, attr) for attr in attrs]
+
+ def get_projects(self):
+ """Retrieve list of projects"""
+ attrs = self.__find_objects(FLAGS.ldap_project_subtree,
+ '(objectclass=novaProject)')
+ return [self.__to_project(attr) for attr in attrs]
+
+ def create_user(self, name, access_key, secret_key, is_admin):
+ """Create a user"""
+ if self.__user_exists(name):
+ raise exception.Duplicate("LDAP user %s already exists" % name)
+ attr = [
+ ('objectclass', ['person',
+ 'organizationalPerson',
+ 'inetOrgPerson',
+ 'novaUser']),
+ ('ou', [FLAGS.ldap_user_unit]),
+ ('uid', [name]),
+ ('sn', [name]),
+ ('cn', [name]),
+ ('secretKey', [secret_key]),
+ ('accessKey', [access_key]),
+ ('isAdmin', [str(is_admin).upper()]),
+ ]
+ self.conn.add_s(self.__uid_to_dn(name), attr)
+ return self.__to_user(dict(attr))
+
+ def create_key_pair(self, uid, key_name, public_key, fingerprint):
+ """Create a key pair"""
+ # TODO(vish): possibly refactor this to store keys in their own ou
+ # and put dn reference in the user object
+ attr = [
+ ('objectclass', ['novaKeyPair']),
+ ('cn', [key_name]),
+ ('sshPublicKey', [public_key]),
+ ('keyFingerprint', [fingerprint]),
+ ]
+ self.conn.add_s('cn=%s,%s' % (key_name,
+ self.__uid_to_dn(uid)),
+ attr)
+ return self.__to_key_pair(uid, dict(attr))
+
+ def create_project(self, name, manager_uid,
+ description=None, member_uids=None):
+ """Create a project"""
+ if self.__project_exists(name):
+ raise exception.Duplicate("Project can't be created because "
+ "project %s already exists" % name)
+ if not self.__user_exists(manager_uid):
+ raise exception.NotFound("Project can't be created because "
+ "manager %s doesn't exist" % manager_uid)
+ manager_dn = self.__uid_to_dn(manager_uid)
+ # description is a required attribute
+ if description is None:
+ description = name
+ members = []
+ if member_uids != None:
+ for member_uid in member_uids:
+ if not self.__user_exists(member_uid):
+ raise exception.NotFound("Project can't be created "
+ "because user %s doesn't exist" % member_uid)
+ members.append(self.__uid_to_dn(member_uid))
+ # always add the manager as a member because members is required
+ if not manager_dn in members:
+ members.append(manager_dn)
+ attr = [
+ ('objectclass', ['novaProject']),
+ ('cn', [name]),
+ ('description', [description]),
+ ('projectManager', [manager_dn]),
+ ('member', members)
+ ]
+ self.conn.add_s('cn=%s,%s' % (name, FLAGS.ldap_project_subtree), attr)
+ return self.__to_project(dict(attr))
+
+ def add_to_project(self, uid, project_id):
+ """Add user to project"""
+ dn = 'cn=%s,%s' % (project_id, FLAGS.ldap_project_subtree)
+ return self.__add_to_group(uid, dn)
+
+ def remove_from_project(self, uid, project_id):
+ """Remove user from project"""
+ dn = 'cn=%s,%s' % (project_id, FLAGS.ldap_project_subtree)
+ return self.__remove_from_group(uid, dn)
+
+ def is_in_project(self, uid, project_id):
+ """Check if user is in project"""
+ dn = 'cn=%s,%s' % (project_id, FLAGS.ldap_project_subtree)
+ return self.__is_in_group(uid, dn)
+
+ def has_role(self, uid, role, project_id=None):
+ """Check if user has role
+
+ If project is specified, it checks for local role, otherwise it
+ checks for global role
+ """
+ role_dn = self.__role_to_dn(role, project_id)
+ return self.__is_in_group(uid, role_dn)
+
+ def add_role(self, uid, role, project_id=None):
+ """Add role for user (or user and project)"""
+ role_dn = self.__role_to_dn(role, project_id)
+ if not self.__group_exists(role_dn):
+ # create the role if it doesn't exist
+ description = '%s role for %s' % (role, project_id)
+ self.__create_group(role_dn, role, uid, description)
+ else:
+ return self.__add_to_group(uid, role_dn)
+
+ def remove_role(self, uid, role, project_id=None):
+ """Remove role for user (or user and project)"""
+ role_dn = self.__role_to_dn(role, project_id)
+ return self.__remove_from_group(uid, role_dn)
+
+ def delete_user(self, uid):
+ """Delete a user"""
+ if not self.__user_exists(uid):
+ raise exception.NotFound("User %s doesn't exist" % uid)
+ self.__delete_key_pairs(uid)
+ self.__remove_from_all(uid)
+ self.conn.delete_s('uid=%s,%s' % (uid,
+ FLAGS.ldap_user_subtree))
+
+ def delete_key_pair(self, uid, key_name):
+ """Delete a key pair"""
+ if not self.__key_pair_exists(uid, key_name):
+ raise exception.NotFound("Key Pair %s doesn't exist for user %s" %
+ (key_name, uid))
+ self.conn.delete_s('cn=%s,uid=%s,%s' % (key_name, uid,
+ FLAGS.ldap_user_subtree))
+
+ def delete_project(self, name):
+ """Delete a project"""
+ project_dn = 'cn=%s,%s' % (name, FLAGS.ldap_project_subtree)
+ self.__delete_roles(project_dn)
+ self.__delete_group(project_dn)
+
+ def __user_exists(self, name):
+ """Check if user exists"""
+ return self.get_user(name) != None
+
+ def __key_pair_exists(self, uid, key_name):
+ """Check if key pair exists"""
+ return self.get_user(uid) != None
+ return self.get_key_pair(uid, key_name) != None
+
+ def __project_exists(self, name):
+ """Check if project exists"""
+ return self.get_project(name) != None
+
+ def __find_object(self, dn, query = None):
+ """Find an object by dn and query"""
+ objects = self.__find_objects(dn, query)
+ if len(objects) == 0:
+ return None
+ return objects[0]
+
+ def __find_dns(self, dn, query=None):
+ """Find dns by query"""
+ try:
+ res = self.conn.search_s(dn, self.ldap.SCOPE_SUBTREE, query)
+ except self.ldap.NO_SUCH_OBJECT:
+ return []
+ # just return the DNs
+ return [dn for dn, attributes in res]
+
+ def __find_objects(self, dn, query = None):
+ """Find objects by query"""
+ try:
+ res = self.conn.search_s(dn, self.ldap.SCOPE_SUBTREE, query)
+ except self.ldap.NO_SUCH_OBJECT:
+ return []
+ # just return the attributes
+ return [attributes for dn, attributes in res]
+
+ def __find_role_dns(self, tree):
+ """Find dns of role objects in given tree"""
+ return self.__find_dns(tree,
+ '(&(objectclass=groupOfNames)(!(objectclass=novaProject)))')
+
+ def __find_group_dns_with_member(self, tree, uid):
+ """Find dns of group objects in a given tree that contain member"""
+ dns = self.__find_dns(tree,
+ '(&(objectclass=groupOfNames)(member=%s))' %
+ self.__uid_to_dn(uid))
+ return dns
+
+ def __group_exists(self, dn):
+ """Check if group exists"""
+ return self.__find_object(dn, '(objectclass=groupOfNames)') != None
+
+ def __delete_key_pairs(self, uid):
+ """Delete all key pairs for user"""
+ keys = self.get_key_pairs(uid)
+ if keys != None:
+ for key in keys:
+ self.delete_key_pair(uid, key['name'])
+
+ def __role_to_dn(self, role, project_id=None):
+ """Convert role to corresponding dn"""
+ if project_id == None:
+ return FLAGS.__getitem__("ldap_%s" % role).value
+ else:
+ return 'cn=%s,cn=%s,%s' % (role,
+ project_id,
+ FLAGS.ldap_project_subtree)
+
+ def __create_group(self, group_dn, name, uid,
+ description, member_uids = None):
+ """Create a group"""
+ if self.__group_exists(group_dn):
+ raise exception.Duplicate("Group can't be created because "
+ "group %s already exists" % name)
+ members = []
+ if member_uids != None:
+ for member_uid in member_uids:
+ if not self.__user_exists(member_uid):
+ raise exception.NotFound("Group can't be created "
+ "because user %s doesn't exist" % member_uid)
+ members.append(self.__uid_to_dn(member_uid))
+ dn = self.__uid_to_dn(uid)
+ if not dn in members:
+ members.append(dn)
+ attr = [
+ ('objectclass', ['groupOfNames']),
+ ('cn', [name]),
+ ('description', [description]),
+ ('member', members)
+ ]
+ self.conn.add_s(group_dn, attr)
+
+ def __is_in_group(self, uid, group_dn):
+ """Check if user is in group"""
+ if not self.__user_exists(uid):
+ raise exception.NotFound("User %s can't be searched in group "
+ "becuase the user doesn't exist" % (uid,))
+ if not self.__group_exists(group_dn):
+ return False
+ res = self.__find_object(group_dn,
+ '(member=%s)' % self.__uid_to_dn(uid))
+ return res != None
+
+ def __add_to_group(self, uid, group_dn):
+ """Add user to group"""
+ if not self.__user_exists(uid):
+ raise exception.NotFound("User %s can't be added to the group "
+ "becuase the user doesn't exist" % (uid,))
+ if not self.__group_exists(group_dn):
+ raise exception.NotFound("The group at dn %s doesn't exist" %
+ (group_dn,))
+ if self.__is_in_group(uid, group_dn):
+ raise exception.Duplicate("User %s is already a member of "
+ "the group %s" % (uid, group_dn))
+ attr = [
+ (self.ldap.MOD_ADD, 'member', self.__uid_to_dn(uid))
+ ]
+ self.conn.modify_s(group_dn, attr)
+
+ def __remove_from_group(self, uid, group_dn):
+ """Remove user from group"""
+ if not self.__group_exists(group_dn):
+ raise exception.NotFound("The group at dn %s doesn't exist" %
+ (group_dn,))
+ if not self.__user_exists(uid):
+ raise exception.NotFound("User %s can't be removed from the "
+ "group because the user doesn't exist" % (uid,))
+ if not self.__is_in_group(uid, group_dn):
+ raise exception.NotFound("User %s is not a member of the group" %
+ (uid,))
+ self.__safe_remove_from_group(uid, group_dn)
+
+ def __safe_remove_from_group(self, uid, group_dn):
+ """Remove user from group, deleting group if user is last member"""
+ # FIXME(vish): what if deleted user is a project manager?
+ attr = [(self.ldap.MOD_DELETE, 'member', self.__uid_to_dn(uid))]
+ try:
+ self.conn.modify_s(group_dn, attr)
+ except self.ldap.OBJECT_CLASS_VIOLATION:
+ logging.debug("Attempted to remove the last member of a group. "
+ "Deleting the group at %s instead." % group_dn )
+ self.__delete_group(group_dn)
+
+ def __remove_from_all(self, uid):
+ """Remove user from all roles and projects"""
+ if not self.__user_exists(uid):
+ raise exception.NotFound("User %s can't be removed from all "
+ "because the user doesn't exist" % (uid,))
+ dn = self.__uid_to_dn(uid)
+ role_dns = self.__find_group_dns_with_member(
+ FLAGS.role_project_subtree, uid)
+ for role_dn in role_dns:
+ self.__safe_remove_from_group(uid, role_dn)
+ project_dns = self.__find_group_dns_with_member(
+ FLAGS.ldap_project_subtree, uid)
+ for project_dn in project_dns:
+ self.__safe_remove_from_group(uid, role_dn)
+
+ def __delete_group(self, group_dn):
+ """Delete Group"""
+ if not self.__group_exists(group_dn):
+ raise exception.NotFound("Group at dn %s doesn't exist" % group_dn)
+ self.conn.delete_s(group_dn)
+
+ def __delete_roles(self, project_dn):
+ """Delete all roles for project"""
+ for role_dn in self.__find_role_dns(project_dn):
+ self.__delete_group(role_dn)
+
+ def __to_user(self, attr):
+ """Convert ldap attributes to User object"""
+ if attr == None:
+ return None
+ return {
+ 'id': attr['uid'][0],
+ 'name': attr['cn'][0],
+ 'access': attr['accessKey'][0],
+ 'secret': attr['secretKey'][0],
+ 'admin': (attr['isAdmin'][0] == 'TRUE')
+ }
+
+ def __to_key_pair(self, owner, attr):
+ """Convert ldap attributes to KeyPair object"""
+ if attr == None:
+ return None
+ return {
+ 'id': attr['cn'][0],
+ 'name': attr['cn'][0],
+ 'owner_id': owner,
+ 'public_key': attr['sshPublicKey'][0],
+ 'fingerprint': attr['keyFingerprint'][0],
+ }
+
+ def __to_project(self, attr):
+ """Convert ldap attributes to Project object"""
+ if attr == None:
+ return None
+ member_dns = attr.get('member', [])
+ return {
+ 'id': attr['cn'][0],
+ 'name': attr['cn'][0],
+ 'project_manager_id': self.__dn_to_uid(attr['projectManager'][0]),
+ 'description': attr.get('description', [None])[0],
+ 'member_ids': [self.__dn_to_uid(x) for x in member_dns]
+ }
+
+ def __dn_to_uid(self, dn):
+ """Convert user dn to uid"""
+ return dn.split(',')[0].split('=')[1]
+
+ def __uid_to_dn(self, dn):
+ """Convert uid to dn"""
+ return 'uid=%s,%s' % (dn, FLAGS.ldap_user_subtree)
+
+
+class FakeLdapDriver(LdapDriver):
+ """Fake Ldap Auth driver"""
+ def __init__(self):
+ __import__('nova.auth.fakeldap')
+ self.ldap = sys.modules['nova.auth.fakeldap']
+
diff --git a/nova/auth/manager.py b/nova/auth/manager.py
new file mode 100644
index 0000000000..b3b5d14cae
--- /dev/null
+++ b/nova/auth/manager.py
@@ -0,0 +1,809 @@
+# vim: tabstop=4 shiftwidth=4 softtabstop=4
+
+# Copyright 2010 United States Government as represented by the
+# Administrator of the National Aeronautics and Space Administration.
+# All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+"""
+Nova authentication management
+"""
+
+import logging
+import os
+import shutil
+import string
+import sys
+import tempfile
+import uuid
+import zipfile
+
+from nova import crypto
+from nova import datastore
+from nova import exception
+from nova import flags
+from nova import objectstore # for flags
+from nova import utils
+from nova.auth import signer
+FLAGS = flags.FLAGS
+
+# NOTE(vish): a user with one of these roles will be a superuser and
+# have access to all api commands
+flags.DEFINE_list('superuser_roles', ['cloudadmin'],
+ 'Roles that ignore rbac checking completely')
+
+# NOTE(vish): a user with one of these roles will have it for every
+# project, even if he or she is not a member of the project
+flags.DEFINE_list('global_roles', ['cloudadmin', 'itsec'],
+ 'Roles that apply to all projects')
+
+
+flags.DEFINE_bool('use_vpn', True, 'Support per-project vpns')
+flags.DEFINE_string('credentials_template',
+ utils.abspath('auth/novarc.template'),
+ 'Template for creating users rc file')
+flags.DEFINE_string('vpn_client_template',
+ utils.abspath('cloudpipe/client.ovpn.template'),
+ 'Template for creating users vpn file')
+flags.DEFINE_string('credential_key_file', 'pk.pem',
+ 'Filename of private key in credentials zip')
+flags.DEFINE_string('credential_cert_file', 'cert.pem',
+ 'Filename of certificate in credentials zip')
+flags.DEFINE_string('credential_rc_file', 'novarc',
+ 'Filename of rc in credentials zip')
+
+flags.DEFINE_integer('vpn_start_port', 1000,
+ 'Start port for the cloudpipe VPN servers')
+flags.DEFINE_integer('vpn_end_port', 2000,
+ 'End port for the cloudpipe VPN servers')
+
+flags.DEFINE_string('credential_cert_subject',
+ '/C=US/ST=California/L=MountainView/O=AnsoLabs/'
+ 'OU=NovaDev/CN=%s-%s',
+ 'Subject for certificate for users')
+
+flags.DEFINE_string('vpn_ip', '127.0.0.1',
+ 'Public IP for the cloudpipe VPN servers')
+
+flags.DEFINE_string('auth_driver', 'nova.auth.ldapdriver.FakeLdapDriver',
+ 'Driver that auth manager uses')
+
+class AuthBase(object):
+ """Base class for objects relating to auth
+
+ Objects derived from this class should be stupid data objects with
+ an id member. They may optionally contain methods that delegate to
+ AuthManager, but should not implement logic themselves.
+ """
+ @classmethod
+ def safe_id(cls, obj):
+ """Safe get object id
+
+ This method will return the id of the object if the object
+ is of this class, otherwise it will return the original object.
+ This allows methods to accept objects or ids as paramaters.
+
+ """
+ if isinstance(obj, cls):
+ return obj.id
+ else:
+ return obj
+
+
+class User(AuthBase):
+ """Object representing a user"""
+ def __init__(self, id, name, access, secret, admin):
+ self.id = id
+ self.name = name
+ self.access = access
+ self.secret = secret
+ self.admin = admin
+
+ def is_superuser(self):
+ return AuthManager().is_superuser(self)
+
+ def is_admin(self):
+ return AuthManager().is_admin(self)
+
+ def has_role(self, role):
+ return AuthManager().has_role(self, role)
+
+ def add_role(self, role):
+ return AuthManager().add_role(self, role)
+
+ def remove_role(self, role):
+ return AuthManager().remove_role(self, role)
+
+ def is_project_member(self, project):
+ return AuthManager().is_project_member(self, project)
+
+ def is_project_manager(self, project):
+ return AuthManager().is_project_manager(self, project)
+
+ def generate_key_pair(self, name):
+ return AuthManager().generate_key_pair(self.id, name)
+
+ def create_key_pair(self, name, public_key, fingerprint):
+ return AuthManager().create_key_pair(self.id,
+ name,
+ public_key,
+ fingerprint)
+
+ def get_key_pair(self, name):
+ return AuthManager().get_key_pair(self.id, name)
+
+ def delete_key_pair(self, name):
+ return AuthManager().delete_key_pair(self.id, name)
+
+ def get_key_pairs(self):
+ return AuthManager().get_key_pairs(self.id)
+
+ def __repr__(self):
+ return "User('%s', '%s', '%s', '%s', %s)" % (self.id,
+ self.name,
+ self.access,
+ self.secret,
+ self.admin)
+
+
+class KeyPair(AuthBase):
+ """Represents an ssh key returned from the datastore
+
+ Even though this object is named KeyPair, only the public key and
+ fingerprint is stored. The user's private key is not saved.
+ """
+ def __init__(self, id, name, owner_id, public_key, fingerprint):
+ self.id = id
+ self.name = name
+ self.owner_id = owner_id
+ self.public_key = public_key
+ self.fingerprint = fingerprint
+
+ def __repr__(self):
+ return "KeyPair('%s', '%s', '%s', '%s', '%s')" % (self.id,
+ self.name,
+ self.owner_id,
+ self.public_key,
+ self.fingerprint)
+
+
+class Project(AuthBase):
+ """Represents a Project returned from the datastore"""
+ def __init__(self, id, name, project_manager_id, description, member_ids):
+ self.id = id
+ self.name = name
+ self.project_manager_id = project_manager_id
+ self.description = description
+ self.member_ids = member_ids
+
+ @property
+ def project_manager(self):
+ return AuthManager().get_user(self.project_manager_id)
+
+ @property
+ def vpn_ip(self):
+ ip, port = AuthManager().get_project_vpn_data(self)
+ return ip
+
+ @property
+ def vpn_port(self):
+ ip, port = AuthManager().get_project_vpn_data(self)
+ return port
+
+ def has_manager(self, user):
+ return AuthManager().is_project_manager(user, self)
+
+ def has_member(self, user):
+ return AuthManager().is_project_member(user, self)
+
+ def add_role(self, user, role):
+ return AuthManager().add_role(user, role, self)
+
+ def remove_role(self, user, role):
+ return AuthManager().remove_role(user, role, self)
+
+ def has_role(self, user, role):
+ return AuthManager().has_role(user, role, self)
+
+ def get_credentials(self, user):
+ return AuthManager().get_credentials(user, self)
+
+ def __repr__(self):
+ return "Project('%s', '%s', '%s', '%s', %s)" % (self.id,
+ self.name,
+ self.project_manager_id,
+ self.description,
+ self.member_ids)
+
+
+class NoMorePorts(exception.Error):
+ pass
+
+
+class Vpn(datastore.BasicModel):
+ """Manages vpn ips and ports for projects"""
+ def __init__(self, project_id):
+ self.project_id = project_id
+ super(Vpn, self).__init__()
+
+ @property
+ def identifier(self):
+ """Identifier used for key in redis"""
+ return self.project_id
+
+ @classmethod
+ def create(cls, project_id):
+ """Creates a vpn for project
+
+ This method finds a free ip and port and stores the associated
+ values in the datastore.
+ """
+ # TODO(vish): get list of vpn ips from redis
+ port = cls.find_free_port_for_ip(FLAGS.vpn_ip)
+ vpn = cls(project_id)
+ # save ip for project
+ vpn['project'] = project_id
+ vpn['ip'] = FLAGS.vpn_ip
+ vpn['port'] = port
+ vpn.save()
+ return vpn
+
+ @classmethod
+ def find_free_port_for_ip(cls, ip):
+ """Finds a free port for a given ip from the redis set"""
+ # TODO(vish): these redis commands should be generalized and
+ # placed into a base class. Conceptually, it is
+ # similar to an association, but we are just
+ # storing a set of values instead of keys that
+ # should be turned into objects.
+ redis = datastore.Redis.instance()
+ key = 'ip:%s:ports' % ip
+ # TODO(vish): these ports should be allocated through an admin
+ # command instead of a flag
+ if (not redis.exists(key) and
+ not redis.exists(cls._redis_association_name('ip', ip))):
+ for i in range(FLAGS.vpn_start_port, FLAGS.vpn_end_port + 1):
+ redis.sadd(key, i)
+
+ port = redis.spop(key)
+ if not port:
+ raise NoMorePorts()
+ return port
+
+ @classmethod
+ def num_ports_for_ip(cls, ip):
+ """Calculates the number of free ports for a given ip"""
+ return datastore.Redis.instance().scard('ip:%s:ports' % ip)
+
+ @property
+ def ip(self):
+ """The ip assigned to the project"""
+ return self['ip']
+
+ @property
+ def port(self):
+ """The port assigned to the project"""
+ return int(self['port'])
+
+ def save(self):
+ """Saves the association to the given ip"""
+ self.associate_with('ip', self.ip)
+ super(Vpn, self).save()
+
+ def destroy(self):
+ """Cleans up datastore and adds port back to pool"""
+ self.unassociate_with('ip', self.ip)
+ datastore.Redis.instance().sadd('ip:%s:ports' % self.ip, self.port)
+ super(Vpn, self).destroy()
+
+
+class AuthManager(object):
+ """Manager Singleton for dealing with Users, Projects, and Keypairs
+
+ Methods accept objects or ids.
+
+ AuthManager uses a driver object to make requests to the data backend.
+ See ldapdriver for reference.
+
+ AuthManager also manages associated data related to Auth objects that
+ need to be more accessible, such as vpn ips and ports.
+ """
+ _instance=None
+ def __new__(cls, *args, **kwargs):
+ """Returns the AuthManager singleton with driver set
+
+ __init__ is run every time AuthManager() is called, so we need to do
+ any constructor related stuff here. The driver that is specified
+ in the flagfile is loaded here.
+ """
+ if not cls._instance:
+ cls._instance = super(AuthManager, cls).__new__(
+ cls, *args, **kwargs)
+ mod_str, sep, driver_str = FLAGS.auth_driver.rpartition('.')
+ try:
+ __import__(mod_str)
+ cls._instance.driver = getattr(sys.modules[mod_str],
+ driver_str)
+ except (ImportError, AttributeError):
+ raise exception.Error('Auth driver %s cannot be found'
+ % FLAGS.auth_driver)
+ return cls._instance
+
+ def authenticate(self, access, signature, params, verb='GET',
+ server_string='127.0.0.1:8773', path='/',
+ check_type='ec2', headers=None):
+ """Authenticates AWS request using access key and signature
+
+ If the project is not specified, attempts to authenticate to
+ a project with the same name as the user. This way, older tools
+ that have no project knowledge will still work.
+
+ @type access: str
+ @param access: Access key for user in the form "access:project".
+
+ @type signature: str
+ @param signature: Signature of the request.
+
+ @type params: list of str
+ @param params: Web paramaters used for the signature.
+
+ @type verb: str
+ @param verb: Web request verb ('GET' or 'POST').
+
+ @type server_string: str
+ @param server_string: Web request server string.
+
+ @type path: str
+ @param path: Web request path.
+
+ @type check_type: str
+ @param check_type: Type of signature to check. 'ec2' for EC2, 's3' for
+ S3. Any other value will cause signature not to be
+ checked.
+
+ @type headers: list
+ @param headers: HTTP headers passed with the request (only needed for
+ s3 signature checks)
+
+ @rtype: tuple (User, Project)
+ @return: User and project that the request represents.
+ """
+ # TODO(vish): check for valid timestamp
+ (access_key, sep, project_id) = access.partition(':')
+
+ logging.info('Looking up user: %r', access_key)
+ user = self.get_user_from_access_key(access_key)
+ logging.info('user: %r', user)
+ if user == None:
+ raise exception.NotFound('No user found for access key %s' %
+ access_key)
+
+ # NOTE(vish): if we stop using project name as id we need better
+ # logic to find a default project for user
+ if project_id is '':
+ project_id = user.name
+
+ project = self.get_project(project_id)
+ if project == None:
+ raise exception.NotFound('No project called %s could be found' %
+ project_id)
+ if not self.is_admin(user) and not self.is_project_member(user,
+ project):
+ raise exception.NotFound('User %s is not a member of project %s' %
+ (user.id, project.id))
+ if check_type == 's3':
+ expected_signature = signer.Signer(user.secret.encode()).s3_authorization(headers, verb, path)
+ logging.debug('user.secret: %s', user.secret)
+ logging.debug('expected_signature: %s', expected_signature)
+ logging.debug('signature: %s', signature)
+ if signature != expected_signature:
+ raise exception.NotAuthorized('Signature does not match')
+ elif check_type == 'ec2':
+ # NOTE(vish): hmac can't handle unicode, so encode ensures that
+ # secret isn't unicode
+ expected_signature = signer.Signer(user.secret.encode()).generate(
+ params, verb, server_string, path)
+ logging.debug('user.secret: %s', user.secret)
+ logging.debug('expected_signature: %s', expected_signature)
+ logging.debug('signature: %s', signature)
+ if signature != expected_signature:
+ raise exception.NotAuthorized('Signature does not match')
+ return (user, project)
+
+ def is_superuser(self, user):
+ """Checks for superuser status, allowing user to bypass rbac
+
+ @type user: User or uid
+ @param user: User to check.
+
+ @rtype: bool
+ @return: True for superuser.
+ """
+ if not isinstance(user, User):
+ user = self.get_user(user)
+ # NOTE(vish): admin flag on user represents superuser
+ if user.admin:
+ return True
+ for role in FLAGS.superuser_roles:
+ if self.has_role(user, role):
+ return True
+
+ def is_admin(self, user):
+ """Checks for admin status, allowing user to access all projects
+
+ @type user: User or uid
+ @param user: User to check.
+
+ @rtype: bool
+ @return: True for admin.
+ """
+ if not isinstance(user, User):
+ user = self.get_user(user)
+ if self.is_superuser(user):
+ return True
+ for role in FLAGS.global_roles:
+ if self.has_role(user, role):
+ return True
+
+ def has_role(self, user, role, project=None):
+ """Checks existence of role for user
+
+ If project is not specified, checks for a global role. If project
+ is specified, checks for the union of the global role and the
+ project role.
+
+ Role 'projectmanager' only works for projects and simply checks to
+ see if the user is the project_manager of the specified project. It
+ is the same as calling is_project_manager(user, project).
+
+ @type user: User or uid
+ @param user: User to check.
+
+ @type role: str
+ @param role: Role to check.
+
+ @type project: Project or project_id
+ @param project: Project in which to look for local role.
+
+ @rtype: bool
+ @return: True if the user has the role.
+ """
+ with self.driver() as drv:
+ if role == 'projectmanager':
+ if not project:
+ raise exception.Error("Must specify project")
+ return self.is_project_manager(user, project)
+
+ global_role = drv.has_role(User.safe_id(user),
+ role,
+ None)
+ if not global_role:
+ return global_role
+
+ if not project or role in FLAGS.global_roles:
+ return global_role
+
+ return drv.has_role(User.safe_id(user),
+ role,
+ Project.safe_id(project))
+
+ def add_role(self, user, role, project=None):
+ """Adds role for user
+
+ If project is not specified, adds a global role. If project
+ is specified, adds a local role.
+
+ The 'projectmanager' role is special and can't be added or removed.
+
+ @type user: User or uid
+ @param user: User to which to add role.
+
+ @type role: str
+ @param role: Role to add.
+
+ @type project: Project or project_id
+ @param project: Project in which to add local role.
+ """
+ with self.driver() as drv:
+ drv.add_role(User.safe_id(user), role, Project.safe_id(project))
+
+ def remove_role(self, user, role, project=None):
+ """Removes role for user
+
+ If project is not specified, removes a global role. If project
+ is specified, removes a local role.
+
+ The 'projectmanager' role is special and can't be added or removed.
+
+ @type user: User or uid
+ @param user: User from which to remove role.
+
+ @type role: str
+ @param role: Role to remove.
+
+ @type project: Project or project_id
+ @param project: Project in which to remove local role.
+ """
+ with self.driver() as drv:
+ drv.remove_role(User.safe_id(user), role, Project.safe_id(project))
+
+ def get_project(self, pid):
+ """Get project object by id"""
+ with self.driver() as drv:
+ project_dict = drv.get_project(pid)
+ if project_dict:
+ return Project(**project_dict)
+
+ def get_projects(self):
+ """Retrieves list of all projects"""
+ with self.driver() as drv:
+ project_list = drv.get_projects()
+ if not project_list:
+ return []
+ return [Project(**project_dict) for project_dict in project_list]
+
+ def create_project(self, name, manager_user,
+ description=None, member_users=None):
+ """Create a project
+
+ @type name: str
+ @param name: Name of the project to create. The name will also be
+ used as the project id.
+
+ @type manager_user: User or uid
+ @param manager_user: This user will be the project manager.
+
+ @type description: str
+ @param project: Description of the project. If no description is
+ specified, the name of the project will be used.
+
+ @type member_users: list of User or uid
+ @param: Initial project members. The project manager will always be
+ added as a member, even if he isn't specified in this list.
+
+ @rtype: Project
+ @return: The new project.
+ """
+ if member_users:
+ member_users = [User.safe_id(u) for u in member_users]
+ with self.driver() as drv:
+ project_dict = drv.create_project(name,
+ User.safe_id(manager_user),
+ description,
+ member_users)
+ if project_dict:
+ if FLAGS.use_vpn:
+ Vpn.create(project_dict['id'])
+ return Project(**project_dict)
+
+ def add_to_project(self, user, project):
+ """Add user to project"""
+ with self.driver() as drv:
+ return drv.add_to_project(User.safe_id(user),
+ Project.safe_id(project))
+
+ def is_project_manager(self, user, project):
+ """Checks if user is project manager"""
+ if not isinstance(project, Project):
+ project = self.get_project(project)
+ return User.safe_id(user) == project.project_manager_id
+
+ def is_project_member(self, user, project):
+ """Checks to see if user is a member of project"""
+ if not isinstance(project, Project):
+ project = self.get_project(project)
+ return User.safe_id(user) in project.member_ids
+
+ def remove_from_project(self, user, project):
+ """Removes a user from a project"""
+ with self.driver() as drv:
+ return drv.remove_from_project(User.safe_id(user),
+ Project.safe_id(project))
+
+ def get_project_vpn_data(self, project):
+ """Gets vpn ip and port for project
+
+ @type project: Project or project_id
+ @param project: Project from which to get associated vpn data
+
+ @rvalue: tuple of (str, str)
+ @return: A tuple containing (ip, port) or None, None if vpn has
+ not been allocated for user.
+ """
+ vpn = Vpn.lookup(Project.safe_id(project))
+ if not vpn:
+ return None, None
+ return (vpn.ip, vpn.port)
+
+ def delete_project(self, project):
+ """Deletes a project"""
+ with self.driver() as drv:
+ return drv.delete_project(Project.safe_id(project))
+
+ def get_user(self, uid):
+ """Retrieves a user by id"""
+ with self.driver() as drv:
+ user_dict = drv.get_user(uid)
+ if user_dict:
+ return User(**user_dict)
+
+ def get_user_from_access_key(self, access_key):
+ """Retrieves a user by access key"""
+ with self.driver() as drv:
+ user_dict = drv.get_user_from_access_key(access_key)
+ if user_dict:
+ return User(**user_dict)
+
+ def get_users(self):
+ """Retrieves a list of all users"""
+ with self.driver() as drv:
+ user_list = drv.get_users()
+ if not user_list:
+ return []
+ return [User(**user_dict) for user_dict in user_list]
+
+ def create_user(self, name, access=None, secret=None, admin=False):
+ """Creates a user
+
+ @type name: str
+ @param name: Name of the user to create.
+
+ @type access: str
+ @param access: Access Key (defaults to a random uuid)
+
+ @type secret: str
+ @param secret: Secret Key (defaults to a random uuid)
+
+ @type admin: bool
+ @param admin: Whether to set the admin flag. The admin flag gives
+ superuser status regardless of roles specifed for the user.
+
+ @type create_project: bool
+ @param: Whether to create a project for the user with the same name.
+
+ @rtype: User
+ @return: The new user.
+ """
+ if access == None: access = str(uuid.uuid4())
+ if secret == None: secret = str(uuid.uuid4())
+ with self.driver() as drv:
+ user_dict = drv.create_user(name, access, secret, admin)
+ if user_dict:
+ return User(**user_dict)
+
+ def delete_user(self, user):
+ """Deletes a user"""
+ with self.driver() as drv:
+ drv.delete_user(User.safe_id(user))
+
+ def generate_key_pair(self, user, key_name):
+ """Generates a key pair for a user
+
+ Generates a public and private key, stores the public key using the
+ key_name, and returns the private key and fingerprint.
+
+ @type user: User or uid
+ @param user: User for which to create key pair.
+
+ @type key_name: str
+ @param key_name: Name to use for the generated KeyPair.
+
+ @rtype: tuple (private_key, fingerprint)
+ @return: A tuple containing the private_key and fingerprint.
+ """
+ # NOTE(vish): generating key pair is slow so check for legal
+ # creation before creating keypair
+ uid = User.safe_id(user)
+ with self.driver() as drv:
+ if not drv.get_user(uid):
+ raise exception.NotFound("User %s doesn't exist" % user)
+ if drv.get_key_pair(uid, key_name):
+ raise exception.Duplicate("The keypair %s already exists"
+ % key_name)
+ private_key, public_key, fingerprint = crypto.generate_key_pair()
+ self.create_key_pair(uid, key_name, public_key, fingerprint)
+ return private_key, fingerprint
+
+ def create_key_pair(self, user, key_name, public_key, fingerprint):
+ """Creates a key pair for user"""
+ with self.driver() as drv:
+ kp_dict = drv.create_key_pair(User.safe_id(user),
+ key_name,
+ public_key,
+ fingerprint)
+ if kp_dict:
+ return KeyPair(**kp_dict)
+
+ def get_key_pair(self, user, key_name):
+ """Retrieves a key pair for user"""
+ with self.driver() as drv:
+ kp_dict = drv.get_key_pair(User.safe_id(user), key_name)
+ if kp_dict:
+ return KeyPair(**kp_dict)
+
+ def get_key_pairs(self, user):
+ """Retrieves all key pairs for user"""
+ with self.driver() as drv:
+ kp_list = drv.get_key_pairs(User.safe_id(user))
+ if not kp_list:
+ return []
+ return [KeyPair(**kp_dict) for kp_dict in kp_list]
+
+ def delete_key_pair(self, user, key_name):
+ """Deletes a key pair for user"""
+ with self.driver() as drv:
+ drv.delete_key_pair(User.safe_id(user), key_name)
+
+ def get_credentials(self, user, project=None):
+ """Get credential zip for user in project"""
+ if not isinstance(user, User):
+ user = self.get_user(user)
+ if project is None:
+ project = user.id
+ pid = Project.safe_id(project)
+ rc = self.__generate_rc(user.access, user.secret, pid)
+ private_key, signed_cert = self._generate_x509_cert(user.id, pid)
+
+ vpn = Vpn.lookup(pid)
+ if not vpn:
+ raise exception.Error("No vpn data allocated for project %s" %
+ project.name)
+ configfile = open(FLAGS.vpn_client_template,"r")
+ s = string.Template(configfile.read())
+ configfile.close()
+ config = s.substitute(keyfile=FLAGS.credential_key_file,
+ certfile=FLAGS.credential_cert_file,
+ ip=vpn.ip,
+ port=vpn.port)
+
+ tmpdir = tempfile.mkdtemp()
+ zf = os.path.join(tmpdir, "temp.zip")
+ zippy = zipfile.ZipFile(zf, 'w')
+ zippy.writestr(FLAGS.credential_rc_file, rc)
+ zippy.writestr(FLAGS.credential_key_file, private_key)
+ zippy.writestr(FLAGS.credential_cert_file, signed_cert)
+ zippy.writestr("nebula-client.conf", config)
+ zippy.writestr(FLAGS.ca_file, crypto.fetch_ca(user.id))
+ zippy.close()
+ with open(zf, 'rb') as f:
+ buffer = f.read()
+
+ shutil.rmtree(tmpdir)
+ return buffer
+
+ def __generate_rc(self, access, secret, pid):
+ """Generate rc file for user"""
+ rc = open(FLAGS.credentials_template).read()
+ rc = rc % { 'access': access,
+ 'project': pid,
+ 'secret': secret,
+ 'ec2': FLAGS.ec2_url,
+ 's3': 'http://%s:%s' % (FLAGS.s3_host, FLAGS.s3_port),
+ 'nova': FLAGS.ca_file,
+ 'cert': FLAGS.credential_cert_file,
+ 'key': FLAGS.credential_key_file,
+ }
+ return rc
+
+ def _generate_x509_cert(self, uid, pid):
+ """Generate x509 cert for user"""
+ (private_key, csr) = crypto.generate_x509_cert(
+ self.__cert_subject(uid))
+ # TODO(joshua): This should be async call back to the cloud controller
+ signed_cert = crypto.sign_csr(csr, pid)
+ return (private_key, signed_cert)
+
+ def __cert_subject(self, uid):
+ """Helper to generate cert subject"""
+ return FLAGS.credential_cert_subject % (uid, utils.isotime())
diff --git a/nova/auth/rbac.py b/nova/auth/rbac.py
index 9e2bb830c2..7fab9419f9 100644
--- a/nova/auth/rbac.py
+++ b/nova/auth/rbac.py
@@ -17,7 +17,7 @@
# under the License.
from nova import exception
-from nova.auth import users
+from nova.auth import manager
def allow(*roles):
diff --git a/nova/auth/signer.py b/nova/auth/signer.py
index 83831bfac1..7d7471575a 100644
--- a/nova/auth/signer.py
+++ b/nova/auth/signer.py
@@ -48,6 +48,7 @@ import hashlib
import hmac
import logging
import urllib
+import boto.utils
from nova.exception import Error
@@ -59,6 +60,13 @@ class Signer(object):
if hashlib.sha256:
self.hmac_256 = hmac.new(secret_key, digestmod=hashlib.sha256)
+ def s3_authorization(self, headers, verb, path):
+ c_string = boto.utils.canonical_string(verb, path, headers)
+ hmac = self.hmac.copy()
+ hmac.update(c_string)
+ b64_hmac = base64.encodestring(hmac.digest()).strip()
+ return b64_hmac
+
def generate(self, params, verb, server_string, path):
if params['SignatureVersion'] == '0':
return self._calc_signature_0(params)
diff --git a/nova/auth/users.py b/nova/auth/users.py
deleted file mode 100644
index fc08dc34dd..0000000000
--- a/nova/auth/users.py
+++ /dev/null
@@ -1,974 +0,0 @@
-# vim: tabstop=4 shiftwidth=4 softtabstop=4
-
-# Copyright 2010 United States Government as represented by the
-# Administrator of the National Aeronautics and Space Administration.
-# All Rights Reserved.
-#
-# Licensed under the Apache License, Version 2.0 (the "License"); you may
-# not use this file except in compliance with the License. You may obtain
-# a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-# License for the specific language governing permissions and limitations
-# under the License.
-
-"""
-Nova users and user management, including RBAC hooks.
-"""
-
-import datetime
-import logging
-import os
-import shutil
-import signer
-import string
-import tempfile
-import uuid
-import zipfile
-
-try:
- import ldap
-except Exception, e:
- import fakeldap as ldap
-
-import fakeldap
-
-# TODO(termie): clean up these imports
-from nova import datastore
-from nova import exception
-from nova import flags
-from nova import crypto
-from nova import utils
-from nova import objectstore # for flags
-
-FLAGS = flags.FLAGS
-
-flags.DEFINE_string('ldap_url', 'ldap://localhost',
- 'Point this at your ldap server')
-flags.DEFINE_string('ldap_password', 'changeme', 'LDAP password')
-flags.DEFINE_string('user_dn', 'cn=Manager,dc=example,dc=com',
- 'DN of admin user')
-flags.DEFINE_string('user_unit', 'Users', 'OID for Users')
-flags.DEFINE_string('user_ldap_subtree', 'ou=Users,dc=example,dc=com',
- 'OU for Users')
-flags.DEFINE_string('project_ldap_subtree', 'ou=Groups,dc=example,dc=com',
- 'OU for Projects')
-flags.DEFINE_string('role_ldap_subtree', 'ou=Groups,dc=example,dc=com',
- 'OU for Roles')
-
-# NOTE(vish): mapping with these flags is necessary because we're going
-# to tie in to an existing ldap schema
-flags.DEFINE_string('ldap_cloudadmin',
- 'cn=cloudadmins,ou=Groups,dc=example,dc=com', 'cn for Cloud Admins')
-flags.DEFINE_string('ldap_itsec',
- 'cn=itsec,ou=Groups,dc=example,dc=com', 'cn for ItSec')
-flags.DEFINE_string('ldap_sysadmin',
- 'cn=sysadmins,ou=Groups,dc=example,dc=com', 'cn for Sysadmins')
-flags.DEFINE_string('ldap_netadmin',
- 'cn=netadmins,ou=Groups,dc=example,dc=com', 'cn for NetAdmins')
-flags.DEFINE_string('ldap_developer',
- 'cn=developers,ou=Groups,dc=example,dc=com', 'cn for Developers')
-
-# NOTE(vish): a user with one of these roles will be a superuser and
-# have access to all api commands
-flags.DEFINE_list('superuser_roles', ['cloudadmin'],
- 'roles that ignore rbac checking completely')
-
-# NOTE(vish): a user with one of these roles will have it for every
-# project, even if he or she is not a member of the project
-flags.DEFINE_list('global_roles', ['cloudadmin', 'itsec'],
- 'roles that apply to all projects')
-
-flags.DEFINE_string('credentials_template',
- utils.abspath('auth/novarc.template'),
- 'Template for creating users rc file')
-flags.DEFINE_string('vpn_client_template',
- utils.abspath('cloudpipe/client.ovpn.template'),
- 'Template for creating users vpn file')
-flags.DEFINE_string('credential_key_file', 'pk.pem',
- 'Filename of private key in credentials zip')
-flags.DEFINE_string('credential_cert_file', 'cert.pem',
- 'Filename of certificate in credentials zip')
-flags.DEFINE_string('credential_rc_file', 'novarc',
- 'Filename of rc in credentials zip')
-
-flags.DEFINE_integer('vpn_start_port', 1000,
- 'Start port for the cloudpipe VPN servers')
-flags.DEFINE_integer('vpn_end_port', 2000,
- 'End port for the cloudpipe VPN servers')
-
-flags.DEFINE_string('credential_cert_subject',
- '/C=US/ST=California/L=MountainView/O=AnsoLabs/'
- 'OU=NovaDev/CN=%s-%s',
- 'Subject for certificate for users')
-
-flags.DEFINE_string('vpn_ip', '127.0.0.1',
- 'Public IP for the cloudpipe VPN servers')
-
-
-class AuthBase(object):
- @classmethod
- def safe_id(cls, obj):
- """Safe get object id.
-
- This method will return the id of the object if the object
- is of this class, otherwise it will return the original object.
- This allows methods to accept objects or ids as paramaters.
-
- """
- if isinstance(obj, cls):
- return obj.id
- else:
- return obj
-
-
-class User(AuthBase):
- """id and name are currently the same"""
- def __init__(self, id, name, access, secret, admin):
- self.id = id
- self.name = name
- self.access = access
- self.secret = secret
- self.admin = admin
-
- def is_superuser(self):
- """allows user to bypass rbac completely"""
- if self.admin:
- return True
- for role in FLAGS.superuser_roles:
- if self.has_role(role):
- return True
-
- def is_admin(self):
- """allows user to see objects from all projects"""
- if self.is_superuser():
- return True
- for role in FLAGS.global_roles:
- if self.has_role(role):
- return True
-
- def has_role(self, role):
- return UserManager.instance().has_role(self, role)
-
- def add_role(self, role):
- return UserManager.instance().add_role(self, role)
-
- def remove_role(self, role):
- return UserManager.instance().remove_role(self, role)
-
- def is_project_member(self, project):
- return UserManager.instance().is_project_member(self, project)
-
- def is_project_manager(self, project):
- return UserManager.instance().is_project_manager(self, project)
-
- def generate_rc(self, project=None):
- if project is None:
- project = self.id
- rc = open(FLAGS.credentials_template).read()
- rc = rc % { 'access': self.access,
- 'project': project,
- 'secret': self.secret,
- 'ec2': FLAGS.ec2_url,
- 's3': 'http://%s:%s' % (FLAGS.s3_host, FLAGS.s3_port),
- 'nova': FLAGS.ca_file,
- 'cert': FLAGS.credential_cert_file,
- 'key': FLAGS.credential_key_file,
- }
- return rc
-
- def generate_key_pair(self, name):
- return UserManager.instance().generate_key_pair(self.id, name)
-
- def create_key_pair(self, name, public_key, fingerprint):
- return UserManager.instance().create_key_pair(self.id,
- name,
- public_key,
- fingerprint)
-
- def get_key_pair(self, name):
- return UserManager.instance().get_key_pair(self.id, name)
-
- def delete_key_pair(self, name):
- return UserManager.instance().delete_key_pair(self.id, name)
-
- def get_key_pairs(self):
- return UserManager.instance().get_key_pairs(self.id)
-
- def __repr__(self):
- return "User('%s', '%s', '%s', '%s', %s)" % (
- self.id, self.name, self.access, self.secret, self.admin)
-
-
-class KeyPair(AuthBase):
- def __init__(self, id, owner_id, public_key, fingerprint):
- self.id = id
- self.name = id
- self.owner_id = owner_id
- self.public_key = public_key
- self.fingerprint = fingerprint
-
- def delete(self):
- return UserManager.instance().delete_key_pair(self.owner, self.name)
-
- def __repr__(self):
- return "KeyPair('%s', '%s', '%s', '%s')" % (
- self.id, self.owner_id, self.public_key, self.fingerprint)
-
-
-class Group(AuthBase):
- """id and name are currently the same"""
- def __init__(self, id, description = None, member_ids = None):
- self.id = id
- self.name = id
- self.description = description
- self.member_ids = member_ids
-
- def has_member(self, user):
- return User.safe_id(user) in self.member_ids
-
- def __repr__(self):
- return "Group('%s', '%s', %s)" % (
- self.id, self.description, self.member_ids)
-
-
-class Project(Group):
- def __init__(self, id, project_manager_id, description, member_ids):
- self.project_manager_id = project_manager_id
- super(Project, self).__init__(id, description, member_ids)
-
- @property
- def project_manager(self):
- return UserManager.instance().get_user(self.project_manager_id)
-
- def has_manager(self, user):
- return User.safe_id(user) == self.project_manager_id
-
- def add_role(self, user, role):
- return UserManager.instance().add_role(user, role, self)
-
- def remove_role(self, user, role):
- return UserManager.instance().remove_role(user, role, self)
-
- def has_role(self, user, role):
- return UserManager.instance().has_role(user, role, self)
-
- @property
- def vpn_ip(self):
- return Vpn(self.id).ip
-
- @property
- def vpn_port(self):
- return Vpn(self.id).port
-
- def get_credentials(self, user):
- if not isinstance(user, User):
- user = UserManager.instance().get_user(user)
- rc = user.generate_rc(self.id)
- private_key, signed_cert = self.generate_x509_cert(user)
-
- configfile = open(FLAGS.vpn_client_template,"r")
- s = string.Template(configfile.read())
- configfile.close()
- config = s.substitute(keyfile=FLAGS.credential_key_file,
- certfile=FLAGS.credential_cert_file,
- ip=self.vpn_ip,
- port=self.vpn_port)
-
- tmpdir = tempfile.mkdtemp()
- zf = os.path.join(tmpdir, "temp.zip")
- zippy = zipfile.ZipFile(zf, 'w')
- zippy.writestr(FLAGS.credential_rc_file, rc)
- zippy.writestr(FLAGS.credential_key_file, private_key)
- zippy.writestr(FLAGS.credential_cert_file, signed_cert)
- zippy.writestr("nebula-client.conf", config)
- zippy.writestr(FLAGS.ca_file, crypto.fetch_ca(self.id))
- zippy.close()
- with open(zf, 'rb') as f:
- buffer = f.read()
-
- shutil.rmtree(tmpdir)
- return buffer
-
- def generate_x509_cert(self, user):
- return UserManager.instance().generate_x509_cert(user, self)
-
- def __repr__(self):
- return "Project('%s', '%s', '%s', %s)" % (
- self.id, self.project_manager_id,
- self.description, self.member_ids)
-
-
-class NoMorePorts(exception.Error):
- pass
-
-
-class Vpn(datastore.BasicModel):
- def __init__(self, project_id):
- self.project_id = project_id
- super(Vpn, self).__init__()
-
- @property
- def identifier(self):
- return self.project_id
-
- @classmethod
- def create(cls, project_id):
- # TODO(vish): get list of vpn ips from redis
- port = cls.find_free_port_for_ip(FLAGS.vpn_ip)
- vpn = cls(project_id)
- # save ip for project
- vpn['project'] = project_id
- vpn['ip'] = FLAGS.vpn_ip
- vpn['port'] = port
- vpn.save()
- return vpn
-
- @classmethod
- def find_free_port_for_ip(cls, ip):
- # TODO(vish): these redis commands should be generalized and
- # placed into a base class. Conceptually, it is
- # similar to an association, but we are just
- # storing a set of values instead of keys that
- # should be turned into objects.
- redis = datastore.Redis.instance()
- key = 'ip:%s:ports' % ip
- # TODO(vish): these ports should be allocated through an admin
- # command instead of a flag
- if (not redis.exists(key) and
- not redis.exists(cls._redis_association_name('ip', ip))):
- for i in range(FLAGS.vpn_start_port, FLAGS.vpn_end_port + 1):
- redis.sadd(key, i)
-
- port = redis.spop(key)
- if not port:
- raise NoMorePorts()
- return port
-
- @classmethod
- def num_ports_for_ip(cls, ip):
- return datastore.Redis.instance().scard('ip:%s:ports' % ip)
-
- @property
- def ip(self):
- return self['ip']
-
- @property
- def port(self):
- return int(self['port'])
-
- def save(self):
- self.associate_with('ip', self.ip)
- super(Vpn, self).save()
-
- def destroy(self):
- self.unassociate_with('ip', self.ip)
- datastore.Redis.instance().sadd('ip:%s:ports' % self.ip, self.port)
- super(Vpn, self).destroy()
-
-
-class UserManager(object):
- def __init__(self):
- if hasattr(self.__class__, '_instance'):
- raise Exception('Attempted to instantiate singleton')
-
- @classmethod
- def instance(cls):
- if not hasattr(cls, '_instance'):
- inst = UserManager()
- cls._instance = inst
- if FLAGS.fake_users:
- try:
- inst.create_user('fake', 'fake', 'fake')
- except: pass
- try:
- inst.create_user('user', 'user', 'user')
- except: pass
- try:
- inst.create_user('admin', 'admin', 'admin', True)
- except: pass
- return cls._instance
-
- def authenticate(self, access, signature, params, verb='GET',
- server_string='127.0.0.1:8773', path='/',
- verify_signature=True):
- # TODO: Check for valid timestamp
- (access_key, sep, project_name) = access.partition(':')
-
- user = self.get_user_from_access_key(access_key)
- if user == None:
- raise exception.NotFound('No user found for access key %s' %
- access_key)
- if project_name is '':
- project_name = user.name
-
- project = self.get_project(project_name)
- if project == None:
- raise exception.NotFound('No project called %s could be found' %
- project_name)
- if not user.is_admin() and not project.has_member(user):
- raise exception.NotFound('User %s is not a member of project %s' %
- (user.id, project.id))
- if verify_signature:
- # NOTE(vish): hmac can't handle unicode, so encode ensures that
- # secret isn't unicode
- expected_signature = signer.Signer(user.secret.encode()).generate(
- params, verb, server_string, path)
- logging.debug('user.secret: %s', user.secret)
- logging.debug('expected_signature: %s', expected_signature)
- logging.debug('signature: %s', signature)
- if signature != expected_signature:
- raise exception.NotAuthorized('Signature does not match')
- return (user, project)
-
- def has_role(self, user, role, project=None):
- with LDAPWrapper() as conn:
- if role == 'projectmanager':
- if not project:
- raise exception.Error("Must specify project")
- return self.is_project_manager(user, project)
-
- global_role = conn.has_role(User.safe_id(user),
- role,
- None)
- if not global_role:
- return global_role
-
- if not project or role in FLAGS.global_roles:
- return global_role
-
- return conn.has_role(User.safe_id(user),
- role,
- Project.safe_id(project))
-
- def add_role(self, user, role, project=None):
- with LDAPWrapper() as conn:
- return conn.add_role(User.safe_id(user), role,
- Project.safe_id(project))
-
- def remove_role(self, user, role, project=None):
- with LDAPWrapper() as conn:
- return conn.remove_role(User.safe_id(user), role,
- Project.safe_id(project))
-
- def create_project(self, name, manager_user,
- description=None, member_users=None):
- if member_users:
- member_users = [User.safe_id(u) for u in member_users]
- # NOTE(vish): try to associate a vpn ip and port first because
- # if it throws an exception, we save having to
- # create and destroy a project
- Vpn.create(name)
- with LDAPWrapper() as conn:
- return conn.create_project(name,
- User.safe_id(manager_user),
- description,
- member_users)
-
-
- def get_projects(self):
- with LDAPWrapper() as conn:
- return conn.find_projects()
-
-
- def get_project(self, project):
- with LDAPWrapper() as conn:
- return conn.find_project(Project.safe_id(project))
-
- def add_to_project(self, user, project):
- with LDAPWrapper() as conn:
- return conn.add_to_project(User.safe_id(user),
- Project.safe_id(project))
-
- def is_project_manager(self, user, project):
- if not isinstance(project, Project):
- project = self.get_project(project)
- return project.has_manager(user)
-
- def is_project_member(self, user, project):
- if isinstance(project, Project):
- return project.has_member(user)
- else:
- with LDAPWrapper() as conn:
- return conn.is_in_project(User.safe_id(user), project)
-
- def remove_from_project(self, user, project):
- with LDAPWrapper() as conn:
- return conn.remove_from_project(User.safe_id(user),
- Project.safe_id(project))
-
- def delete_project(self, project):
- with LDAPWrapper() as conn:
- return conn.delete_project(Project.safe_id(project))
-
- def get_user(self, uid):
- with LDAPWrapper() as conn:
- return conn.find_user(uid)
-
- def get_user_from_access_key(self, access_key):
- with LDAPWrapper() as conn:
- return conn.find_user_by_access_key(access_key)
-
- def get_users(self):
- with LDAPWrapper() as conn:
- return conn.find_users()
-
- def create_user(self, user, access=None, secret=None,
- admin=False, create_project=True):
- if access == None: access = str(uuid.uuid4())
- if secret == None: secret = str(uuid.uuid4())
- with LDAPWrapper() as conn:
- user = User.safe_id(user)
- result = conn.create_user(user, access, secret, admin)
- if create_project:
- # NOTE(vish): if the project creation fails, we delete
- # the user and return an exception
- try:
- conn.create_project(user, user, user)
- except Exception:
- with LDAPWrapper() as conn:
- conn.delete_user(user)
- raise
- return result
-
- def delete_user(self, user, delete_project=True):
- with LDAPWrapper() as conn:
- user = User.safe_id(user)
- if delete_project:
- try:
- conn.delete_project(user)
- except exception.NotFound:
- pass
- conn.delete_user(user)
-
- def generate_key_pair(self, user, key_name):
- # generating key pair is slow so delay generation
- # until after check
- user = User.safe_id(user)
- with LDAPWrapper() as conn:
- if not conn.user_exists(user):
- raise exception.NotFound("User %s doesn't exist" % user)
- if conn.key_pair_exists(user, key_name):
- raise exception.Duplicate("The keypair %s already exists"
- % key_name)
- private_key, public_key, fingerprint = crypto.generate_key_pair()
- self.create_key_pair(User.safe_id(user), key_name,
- public_key, fingerprint)
- return private_key, fingerprint
-
- def create_key_pair(self, user, key_name, public_key, fingerprint):
- with LDAPWrapper() as conn:
- return conn.create_key_pair(User.safe_id(user), key_name,
- public_key, fingerprint)
-
- def get_key_pair(self, user, key_name):
- with LDAPWrapper() as conn:
- return conn.find_key_pair(User.safe_id(user), key_name)
-
- def get_key_pairs(self, user):
- with LDAPWrapper() as conn:
- return conn.find_key_pairs(User.safe_id(user))
-
- def delete_key_pair(self, user, key_name):
- with LDAPWrapper() as conn:
- conn.delete_key_pair(User.safe_id(user), key_name)
-
- def generate_x509_cert(self, user, project):
- (private_key, csr) = crypto.generate_x509_cert(
- self.__cert_subject(User.safe_id(user)))
- # TODO - This should be async call back to the cloud controller
- signed_cert = crypto.sign_csr(csr, Project.safe_id(project))
- return (private_key, signed_cert)
-
- def __cert_subject(self, uid):
- # FIXME(ja) - this should be pulled from a global configuration
- return FLAGS.credential_cert_subject % (uid, utils.isotime())
-
-
-class LDAPWrapper(object):
- def __init__(self):
- self.user = FLAGS.user_dn
- self.passwd = FLAGS.ldap_password
-
- def __enter__(self):
- self.connect()
- return self
-
- def __exit__(self, type, value, traceback):
- self.conn.unbind_s()
- return False
-
- def connect(self):
- """ connect to ldap as admin user """
- if FLAGS.fake_users:
- self.NO_SUCH_OBJECT = fakeldap.NO_SUCH_OBJECT
- self.OBJECT_CLASS_VIOLATION = fakeldap.OBJECT_CLASS_VIOLATION
- self.conn = fakeldap.initialize(FLAGS.ldap_url)
- else:
- self.NO_SUCH_OBJECT = ldap.NO_SUCH_OBJECT
- self.OBJECT_CLASS_VIOLATION = ldap.OBJECT_CLASS_VIOLATION
- self.conn = ldap.initialize(FLAGS.ldap_url)
- self.conn.simple_bind_s(self.user, self.passwd)
-
- def find_object(self, dn, query = None):
- objects = self.find_objects(dn, query)
- if len(objects) == 0:
- return None
- return objects[0]
-
- def find_dns(self, dn, query=None):
- try:
- res = self.conn.search_s(dn, ldap.SCOPE_SUBTREE, query)
- except self.NO_SUCH_OBJECT:
- return []
- # just return the DNs
- return [dn for dn, attributes in res]
-
- def find_objects(self, dn, query = None):
- try:
- res = self.conn.search_s(dn, ldap.SCOPE_SUBTREE, query)
- except self.NO_SUCH_OBJECT:
- return []
- # just return the attributes
- return [attributes for dn, attributes in res]
-
- def find_users(self):
- attrs = self.find_objects(FLAGS.user_ldap_subtree,
- '(objectclass=novaUser)')
- return [self.__to_user(attr) for attr in attrs]
-
- def find_key_pairs(self, uid):
- attrs = self.find_objects(self.__uid_to_dn(uid),
- '(objectclass=novaKeyPair)')
- return [self.__to_key_pair(uid, attr) for attr in attrs]
-
- def find_projects(self):
- attrs = self.find_objects(FLAGS.project_ldap_subtree,
- '(objectclass=novaProject)')
- return [self.__to_project(attr) for attr in attrs]
-
- def find_roles(self, tree):
- attrs = self.find_objects(tree,
- '(&(objectclass=groupOfNames)(!(objectclass=novaProject)))')
- return [self.__to_group(attr) for attr in attrs]
-
- def find_group_dns_with_member(self, tree, uid):
- dns = self.find_dns(tree,
- '(&(objectclass=groupOfNames)(member=%s))' %
- self.__uid_to_dn(uid))
- return dns
-
- def find_user(self, uid):
- attr = self.find_object(self.__uid_to_dn(uid),
- '(objectclass=novaUser)')
- return self.__to_user(attr)
-
- def find_key_pair(self, uid, key_name):
- dn = 'cn=%s,%s' % (key_name,
- self.__uid_to_dn(uid))
- attr = self.find_object(dn, '(objectclass=novaKeyPair)')
- return self.__to_key_pair(uid, attr)
-
- def find_group(self, dn):
- """uses dn directly instead of custructing it from name"""
- attr = self.find_object(dn, '(objectclass=groupOfNames)')
- return self.__to_group(attr)
-
- def find_project(self, name):
- dn = 'cn=%s,%s' % (name,
- FLAGS.project_ldap_subtree)
- attr = self.find_object(dn, '(objectclass=novaProject)')
- return self.__to_project(attr)
-
- def user_exists(self, name):
- return self.find_user(name) != None
-
- def key_pair_exists(self, uid, key_name):
- return self.find_key_pair(uid, key_name) != None
-
- def project_exists(self, name):
- return self.find_project(name) != None
-
- def group_exists(self, dn):
- return self.find_group(dn) != None
-
- def delete_key_pairs(self, uid):
- keys = self.find_key_pairs(uid)
- if keys != None:
- for key in keys:
- self.delete_key_pair(uid, key.name)
-
- def create_user(self, name, access_key, secret_key, is_admin):
- if self.user_exists(name):
- raise exception.Duplicate("LDAP user %s already exists" % name)
- attr = [
- ('objectclass', ['person',
- 'organizationalPerson',
- 'inetOrgPerson',
- 'novaUser']),
- ('ou', [FLAGS.user_unit]),
- ('uid', [name]),
- ('sn', [name]),
- ('cn', [name]),
- ('secretKey', [secret_key]),
- ('accessKey', [access_key]),
- ('isAdmin', [str(is_admin).upper()]),
- ]
- self.conn.add_s(self.__uid_to_dn(name), attr)
- return self.__to_user(dict(attr))
-
- def create_project(self, name, manager_uid,
- description=None, member_uids=None):
- if self.project_exists(name):
- raise exception.Duplicate("Project can't be created because "
- "project %s already exists" % name)
- if not self.user_exists(manager_uid):
- raise exception.NotFound("Project can't be created because "
- "manager %s doesn't exist" % manager_uid)
- manager_dn = self.__uid_to_dn(manager_uid)
- # description is a required attribute
- if description is None:
- description = name
- members = []
- if member_uids != None:
- for member_uid in member_uids:
- if not self.user_exists(member_uid):
- raise exception.NotFound("Project can't be created "
- "because user %s doesn't exist" % member_uid)
- members.append(self.__uid_to_dn(member_uid))
- # always add the manager as a member because members is required
- if not manager_dn in members:
- members.append(manager_dn)
- attr = [
- ('objectclass', ['novaProject']),
- ('cn', [name]),
- ('description', [description]),
- ('projectManager', [manager_dn]),
- ('member', members)
- ]
- self.conn.add_s('cn=%s,%s' % (name, FLAGS.project_ldap_subtree), attr)
- return self.__to_project(dict(attr))
-
- def add_to_project(self, uid, project_id):
- dn = 'cn=%s,%s' % (project_id, FLAGS.project_ldap_subtree)
- return self.add_to_group(uid, dn)
-
- def remove_from_project(self, uid, project_id):
- dn = 'cn=%s,%s' % (project_id, FLAGS.project_ldap_subtree)
- return self.remove_from_group(uid, dn)
-
- def is_in_project(self, uid, project_id):
- dn = 'cn=%s,%s' % (project_id, FLAGS.project_ldap_subtree)
- return self.is_in_group(uid, dn)
-
- def __role_to_dn(self, role, project_id=None):
- if project_id == None:
- return FLAGS.__getitem__("ldap_%s" % role).value
- else:
- return 'cn=%s,cn=%s,%s' % (role,
- project_id,
- FLAGS.project_ldap_subtree)
-
- def __create_group(self, group_dn, name, uid,
- description, member_uids = None):
- if self.group_exists(group_dn):
- raise exception.Duplicate("Group can't be created because "
- "group %s already exists" % name)
- members = []
- if member_uids != None:
- for member_uid in member_uids:
- if not self.user_exists(member_uid):
- raise exception.NotFound("Group can't be created "
- "because user %s doesn't exist" % member_uid)
- members.append(self.__uid_to_dn(member_uid))
- dn = self.__uid_to_dn(uid)
- if not dn in members:
- members.append(dn)
- attr = [
- ('objectclass', ['groupOfNames']),
- ('cn', [name]),
- ('description', [description]),
- ('member', members)
- ]
- self.conn.add_s(group_dn, attr)
- return self.__to_group(dict(attr))
-
- def has_role(self, uid, role, project_id=None):
- role_dn = self.__role_to_dn(role, project_id)
- return self.is_in_group(uid, role_dn)
-
- def add_role(self, uid, role, project_id=None):
- role_dn = self.__role_to_dn(role, project_id)
- if not self.group_exists(role_dn):
- # create the role if it doesn't exist
- description = '%s role for %s' % (role, project_id)
- self.__create_group(role_dn, role, uid, description)
- else:
- return self.add_to_group(uid, role_dn)
-
- def remove_role(self, uid, role, project_id=None):
- role_dn = self.__role_to_dn(role, project_id)
- return self.remove_from_group(uid, role_dn)
-
- def is_in_group(self, uid, group_dn):
- if not self.user_exists(uid):
- raise exception.NotFound("User %s can't be searched in group "
- "becuase the user doesn't exist" % (uid,))
- if not self.group_exists(group_dn):
- return False
- res = self.find_object(group_dn,
- '(member=%s)' % self.__uid_to_dn(uid))
- return res != None
-
- def add_to_group(self, uid, group_dn):
- if not self.user_exists(uid):
- raise exception.NotFound("User %s can't be added to the group "
- "becuase the user doesn't exist" % (uid,))
- if not self.group_exists(group_dn):
- raise exception.NotFound("The group at dn %s doesn't exist" %
- (group_dn,))
- if self.is_in_group(uid, group_dn):
- raise exception.Duplicate("User %s is already a member of "
- "the group %s" % (uid, group_dn))
- attr = [
- (ldap.MOD_ADD, 'member', self.__uid_to_dn(uid))
- ]
- self.conn.modify_s(group_dn, attr)
-
- def remove_from_group(self, uid, group_dn):
- if not self.group_exists(group_dn):
- raise exception.NotFound("The group at dn %s doesn't exist" %
- (group_dn,))
- if not self.user_exists(uid):
- raise exception.NotFound("User %s can't be removed from the "
- "group because the user doesn't exist" % (uid,))
- if not self.is_in_group(uid, group_dn):
- raise exception.NotFound("User %s is not a member of the group" %
- (uid,))
- self._safe_remove_from_group(group_dn, uid)
-
- def _safe_remove_from_group(self, group_dn, uid):
- # FIXME(vish): what if deleted user is a project manager?
- attr = [(ldap.MOD_DELETE, 'member', self.__uid_to_dn(uid))]
- try:
- self.conn.modify_s(group_dn, attr)
- except self.OBJECT_CLASS_VIOLATION:
- logging.debug("Attempted to remove the last member of a group. "
- "Deleting the group at %s instead." % group_dn )
- self.delete_group(group_dn)
-
- def remove_from_all(self, uid):
- if not self.user_exists(uid):
- raise exception.NotFound("User %s can't be removed from all "
- "because the user doesn't exist" % (uid,))
- dn = self.__uid_to_dn(uid)
- role_dns = self.find_group_dns_with_member(
- FLAGS.role_ldap_subtree, uid)
- for role_dn in role_dns:
- self._safe_remove_from_group(role_dn, uid)
- project_dns = self.find_group_dns_with_member(
- FLAGS.project_ldap_subtree, uid)
- for project_dn in project_dns:
- self._safe_remove_from_group(project_dn, uid)
-
- def create_key_pair(self, uid, key_name, public_key, fingerprint):
- """create's a public key in the directory underneath the user"""
- # TODO(vish): possibly refactor this to store keys in their own ou
- # and put dn reference in the user object
- attr = [
- ('objectclass', ['novaKeyPair']),
- ('cn', [key_name]),
- ('sshPublicKey', [public_key]),
- ('keyFingerprint', [fingerprint]),
- ]
- self.conn.add_s('cn=%s,%s' % (key_name,
- self.__uid_to_dn(uid)),
- attr)
- return self.__to_key_pair(uid, dict(attr))
-
- def find_user_by_access_key(self, access):
- query = '(accessKey=%s)' % access
- dn = FLAGS.user_ldap_subtree
- return self.__to_user(self.find_object(dn, query))
-
- def delete_user(self, uid):
- if not self.user_exists(uid):
- raise exception.NotFound("User %s doesn't exist" % uid)
- self.delete_key_pairs(uid)
- self.remove_from_all(uid)
- self.conn.delete_s('uid=%s,%s' % (uid,
- FLAGS.user_ldap_subtree))
-
- def delete_key_pair(self, uid, key_name):
- if not self.key_pair_exists(uid, key_name):
- raise exception.NotFound("Key Pair %s doesn't exist for user %s" %
- (key_name, uid))
- self.conn.delete_s('cn=%s,uid=%s,%s' % (key_name, uid,
- FLAGS.user_ldap_subtree))
-
- def delete_group(self, group_dn):
- if not self.group_exists(group_dn):
- raise exception.NotFound("Group at dn %s doesn't exist" % group_dn)
- self.conn.delete_s(group_dn)
-
- def delete_roles(self, project_dn):
- roles = self.find_roles(project_dn)
- for role in roles:
- self.delete_group('cn=%s,%s' % (role.id, project_dn))
-
- def delete_project(self, name):
- project_dn = 'cn=%s,%s' % (name, FLAGS.project_ldap_subtree)
- self.delete_roles(project_dn)
- self.delete_group(project_dn)
-
- def __to_user(self, attr):
- if attr == None:
- return None
- return User(
- id = attr['uid'][0],
- name = attr['cn'][0],
- access = attr['accessKey'][0],
- secret = attr['secretKey'][0],
- admin = (attr['isAdmin'][0] == 'TRUE')
- )
-
- def __to_key_pair(self, owner, attr):
- if attr == None:
- return None
- return KeyPair(
- id = attr['cn'][0],
- owner_id = owner,
- public_key = attr['sshPublicKey'][0],
- fingerprint = attr['keyFingerprint'][0],
- )
-
- def __to_group(self, attr):
- if attr == None:
- return None
- member_dns = attr.get('member', [])
- return Group(
- id = attr['cn'][0],
- description = attr.get('description', [None])[0],
- member_ids = [self.__dn_to_uid(x) for x in member_dns]
- )
-
- def __to_project(self, attr):
- if attr == None:
- return None
- member_dns = attr.get('member', [])
- return Project(
- id = attr['cn'][0],
- project_manager_id = self.__dn_to_uid(attr['projectManager'][0]),
- description = attr.get('description', [None])[0],
- member_ids = [self.__dn_to_uid(x) for x in member_dns]
- )
-
- def __dn_to_uid(self, dn):
- return dn.split(',')[0].split('=')[1]
-
- def __uid_to_dn(self, dn):
- return 'uid=%s,%s' % (dn, FLAGS.user_ldap_subtree)
diff --git a/nova/cloudpipe/api.py b/nova/cloudpipe/api.py
index a5f78a16d9..0bffe9aa34 100644
--- a/nova/cloudpipe/api.py
+++ b/nova/cloudpipe/api.py
@@ -25,7 +25,7 @@ import tornado.web
import urllib
from nova import crypto
-from nova.auth import users
+from nova.auth import manager
_log = logging.getLogger("api")
diff --git a/nova/cloudpipe/pipelib.py b/nova/cloudpipe/pipelib.py
index 63f7ae2223..5b0ed34713 100644
--- a/nova/cloudpipe/pipelib.py
+++ b/nova/cloudpipe/pipelib.py
@@ -31,7 +31,7 @@ import zipfile
from nova import exception
from nova import flags
from nova import utils
-from nova.auth import users
+from nova.auth import manager
from nova.endpoint import api
@@ -44,7 +44,7 @@ flags.DEFINE_string('boot_script_template',
class CloudPipe(object):
def __init__(self, cloud_controller):
self.controller = cloud_controller
- self.manager = users.UserManager.instance()
+ self.manager = manager.AuthManager()
def launch_vpn_instance(self, project_id):
logging.debug( "Launching VPN for %s" % (project_id))
diff --git a/nova/compute/linux_net.py b/nova/compute/linux_net.py
index 48e07da664..861ce779bb 100644
--- a/nova/compute/linux_net.py
+++ b/nova/compute/linux_net.py
@@ -29,7 +29,7 @@ from nova import flags
FLAGS=flags.FLAGS
flags.DEFINE_string('dhcpbridge_flagfile',
- '/etc/nova-dhcpbridge.conf',
+ '/etc/nova/nova-dhcpbridge.conf',
'location of flagfile for dhcpbridge')
def execute(cmd, addl_env=None):
diff --git a/nova/compute/network.py b/nova/compute/network.py
index 43011f6968..b5b3c3b5dc 100644
--- a/nova/compute/network.py
+++ b/nova/compute/network.py
@@ -29,7 +29,7 @@ from nova import datastore
from nova import exception
from nova import flags
from nova import utils
-from nova.auth import users
+from nova.auth import manager
from nova.compute import exception as compute_exception
from nova.compute import linux_net
@@ -210,11 +210,11 @@ class BaseNetwork(datastore.BasicModel):
@property
def user(self):
- return users.UserManager.instance().get_user(self['user_id'])
+ return manager.AuthManager().get_user(self['user_id'])
@property
def project(self):
- return users.UserManager.instance().get_project(self['project_id'])
+ return manager.AuthManager().get_project(self['project_id'])
@property
def _hosts_key(self):
@@ -516,7 +516,7 @@ def get_vlan_for_project(project_id):
if not known_vlans.has_key(vstr):
return Vlan.create(project_id, vnum)
old_project_id = known_vlans[vstr]
- if not users.UserManager.instance().get_project(old_project_id):
+ if not manager.AuthManager().get_project(old_project_id):
vlan = Vlan.lookup(old_project_id)
if vlan:
# NOTE(todd): This doesn't check for vlan id match, because
@@ -542,7 +542,7 @@ def get_network_by_interface(iface, security_group='default'):
def get_network_by_address(address):
logging.debug("Get Network By Address: %s" % address)
- for project in users.UserManager.instance().get_projects():
+ for project in manager.AuthManager().get_projects():
net = get_project_network(project.id)
if address in net.assigned:
logging.debug("Found %s in %s" % (address, project.id))
@@ -582,7 +582,7 @@ def get_project_network(project_id, security_group='default'):
""" get a project's private network, allocating one if needed """
# TODO(todd): It looks goofy to get a project from a UserManager.
# Refactor to still use the LDAP backend, but not User specific.
- project = users.UserManager.instance().get_project(project_id)
+ project = manager.AuthManager().get_project(project_id)
if not project:
raise exception.Error("Project %s doesn't exist, uhoh." %
project_id)
@@ -592,5 +592,5 @@ def get_project_network(project_id, security_group='default'):
def restart_nets():
""" Ensure the network for each user is enabled"""
- for project in users.UserManager.instance().get_projects():
+ for project in manager.AuthManager().get_projects():
get_project_network(project.id).express()
diff --git a/nova/compute/service.py b/nova/compute/service.py
index 02e35baa26..9998dc6c38 100644
--- a/nova/compute/service.py
+++ b/nova/compute/service.py
@@ -25,11 +25,13 @@ Compute Service:
"""
import base64
+import boto.utils
import json
import logging
import os
import shutil
import sys
+import time
from twisted.internet import defer
from twisted.internet import task
@@ -45,6 +47,7 @@ from nova import flags
from nova import process
from nova import service
from nova import utils
+from nova.auth import signer, manager
from nova.compute import disk
from nova.compute import model
from nova.compute import network
@@ -450,9 +453,25 @@ class Instance(object):
def _fetch_s3_image(self, image, path):
url = _image_url('%s/image' % image)
- d = process.simple_execute(
- 'curl --silent %s -o %s' % (url, path))
- return d
+
+ # This should probably move somewhere else, like e.g. a download_as
+ # method on User objects and at the same time get rewritten to use
+ # twisted web client.
+ headers = {}
+ headers['Date'] = time.strftime("%a, %d %b %Y %H:%M:%S GMT", time.gmtime())
+
+ user_id = self.datamodel['user_id']
+ user = manager.AuthManager().get_user(user_id)
+ uri = '/' + url.partition('/')[2]
+ auth = signer.Signer(user.secret.encode()).s3_authorization(headers, 'GET', uri)
+ headers['Authorization'] = 'AWS %s:%s' % (user.access, auth)
+
+ cmd = ['/usr/bin/curl', '--silent', url]
+ for (k,v) in headers.iteritems():
+ cmd += ['-H', '%s: %s' % (k,v)]
+
+ cmd += ['-o', path]
+ return process.SharedPool().execute(executable=cmd[0], args=cmd[1:])
def _fetch_local_image(self, image, path):
source = _image_path('%s/image' % image)
diff --git a/nova/endpoint/admin.py b/nova/endpoint/admin.py
index b97a6727f4..55a8e4238f 100644
--- a/nova/endpoint/admin.py
+++ b/nova/endpoint/admin.py
@@ -22,7 +22,7 @@ Admin API controller, exposed through http via the api worker.
import base64
-from nova.auth import users
+from nova.auth import manager
from nova.compute import model
def user_dict(user, base64_file=None):
@@ -69,18 +69,18 @@ class AdminController(object):
@admin_only
def describe_user(self, _context, name, **_kwargs):
"""Returns user data, including access and secret keys."""
- return user_dict(users.UserManager.instance().get_user(name))
+ return user_dict(manager.AuthManager().get_user(name))
@admin_only
def describe_users(self, _context, **_kwargs):
"""Returns all users - should be changed to deal with a list."""
return {'userSet':
- [user_dict(u) for u in users.UserManager.instance().get_users()] }
+ [user_dict(u) for u in manager.AuthManager().get_users()] }
@admin_only
def register_user(self, _context, name, **_kwargs):
"""Creates a new user, and returns generated credentials."""
- return user_dict(users.UserManager.instance().create_user(name))
+ return user_dict(manager.AuthManager().create_user(name))
@admin_only
def deregister_user(self, _context, name, **_kwargs):
@@ -88,7 +88,7 @@ class AdminController(object):
Should throw an exception if the user has instances,
volumes, or buckets remaining.
"""
- users.UserManager.instance().delete_user(name)
+ manager.AuthManager().delete_user(name)
return True
@@ -100,8 +100,8 @@ class AdminController(object):
"""
if project is None:
project = name
- project = users.UserManager.instance().get_project(project)
- user = users.UserManager.instance().get_user(name)
+ project = manager.AuthManager().get_project(project)
+ user = manager.AuthManager().get_user(name)
return user_dict(user, base64.b64encode(project.get_credentials(user)))
@admin_only
diff --git a/nova/endpoint/api.py b/nova/endpoint/api.py
index 79a2aaddbd..78a18b9ea0 100755
--- a/nova/endpoint/api.py
+++ b/nova/endpoint/api.py
@@ -35,7 +35,7 @@ from nova import crypto
from nova import exception
from nova import flags
from nova import utils
-from nova.auth import users
+from nova.auth import manager
import nova.cloudpipe.api
from nova.endpoint import cloud
@@ -266,7 +266,7 @@ class APIRequestHandler(tornado.web.RequestHandler):
# Authenticate the request.
try:
- (user, project) = users.UserManager.instance().authenticate(
+ (user, project) = manager.AuthManager().authenticate(
access,
signature,
auth_params,
diff --git a/nova/endpoint/cloud.py b/nova/endpoint/cloud.py
index 97a7b5a389..76ca353208 100644
--- a/nova/endpoint/cloud.py
+++ b/nova/endpoint/cloud.py
@@ -34,7 +34,7 @@ from nova import flags
from nova import rpc
from nova import utils
from nova.auth import rbac
-from nova.auth import users
+from nova.auth import manager
from nova.compute import model
from nova.compute import network
from nova.compute import service as compute_service
@@ -47,9 +47,9 @@ FLAGS = flags.FLAGS
flags.DEFINE_string('cloud_topic', 'cloud', 'the topic clouds listen on')
def _gen_key(user_id, key_name):
- """ Tuck this into UserManager """
+ """ Tuck this into AuthManager """
try:
- manager = users.UserManager.instance()
+ manager = manager.AuthManager()
private_key, fingerprint = manager.generate_key_pair(user_id, key_name)
except Exception as ex:
return {'exception': ex}
diff --git a/nova/endpoint/rackspace.py b/nova/endpoint/rackspace.py
index 08e435c5d5..de05ba2da9 100644
--- a/nova/endpoint/rackspace.py
+++ b/nova/endpoint/rackspace.py
@@ -34,7 +34,7 @@ from nova import exception
from nova import flags
from nova import rpc
from nova import utils
-from nova.auth import users
+from nova.auth import manager
from nova.compute import model
from nova.compute import network
from nova.endpoint import images
@@ -77,11 +77,11 @@ class Api(object):
def build_context(self, env):
rv = {}
if env.has_key("HTTP_X_AUTH_TOKEN"):
- rv['user'] = users.UserManager.instance().get_user_from_access_key(
+ rv['user'] = manager.AuthManager().get_user_from_access_key(
env['HTTP_X_AUTH_TOKEN']
)
if rv['user']:
- rv['project'] = users.UserManager.instance().get_project(
+ rv['project'] = manager.AuthManager().get_project(
rv['user'].name
)
return rv
diff --git a/nova/flags.py b/nova/flags.py
index ffb395f13b..ec1390fdd0 100644
--- a/nova/flags.py
+++ b/nova/flags.py
@@ -48,7 +48,6 @@ DEFINE_bool('fake_libvirt', False,
DEFINE_bool('verbose', False, 'show debug output')
DEFINE_boolean('fake_rabbit', False, 'use a fake rabbit')
DEFINE_bool('fake_network', False, 'should we use fake network devices and addresses')
-DEFINE_bool('fake_users', False, 'use fake users')
DEFINE_string('rabbit_host', 'localhost', 'rabbit host')
DEFINE_integer('rabbit_port', 5672, 'rabbit port')
DEFINE_string('rabbit_userid', 'guest', 'rabbit userid')
diff --git a/nova/objectstore/handler.py b/nova/objectstore/handler.py
index ae3ffa0ebf..999581c651 100644
--- a/nova/objectstore/handler.py
+++ b/nova/objectstore/handler.py
@@ -47,12 +47,12 @@ import urllib
from twisted.application import internet, service
from twisted.web.resource import Resource
-from twisted.web import server, static
+from twisted.web import server, static, error
from nova import exception
from nova import flags
-from nova.auth import users
+from nova.auth import manager
from nova.endpoint import api
from nova.objectstore import bucket
from nova.objectstore import image
@@ -107,10 +107,14 @@ def get_context(request):
if not authorization_header:
raise exception.NotAuthorized
access, sep, secret = authorization_header.split(' ')[1].rpartition(':')
- um = users.UserManager.instance()
- print 'um %s' % um
- (user, project) = um.authenticate(access, secret, {}, request.method, request.host, request.uri, False)
- # FIXME: check signature here!
+ (user, project) = manager.AuthManager().authenticate(access,
+ secret,
+ {},
+ request.method,
+ request.getRequestHostname(),
+ request.uri,
+ headers=request.getAllHeaders(),
+ check_type='s3')
return api.APIRequestContext(None, user, project)
except exception.Error as ex:
logging.debug("Authentication Failure: %s" % ex)
@@ -120,15 +124,15 @@ class S3(Resource):
"""Implementation of an S3-like storage server based on local files."""
def getChild(self, name, request):
request.context = get_context(request)
-
if name == '':
return self
elif name == '_images':
- return ImageResource()
+ return ImagesResource()
else:
return BucketResource(name)
def render_GET(self, request):
+ logging.debug('List of buckets requested')
buckets = [b for b in bucket.Bucket.all() if b.is_authorized(request.context)]
render_xml(request, {"ListAllMyBucketsResult": {
@@ -150,7 +154,10 @@ class BucketResource(Resource):
def render_GET(self, request):
logging.debug("List keys for bucket %s" % (self.name))
- bucket_object = bucket.Bucket(self.name)
+ try:
+ bucket_object = bucket.Bucket(self.name)
+ except exception.NotFound, e:
+ return error.NoResource(message="No such bucket").render(request)
if not bucket_object.is_authorized(request.context):
raise exception.NotAuthorized
@@ -166,13 +173,10 @@ class BucketResource(Resource):
def render_PUT(self, request):
logging.debug("Creating bucket %s" % (self.name))
- try:
- print 'user is %s' % request.context
- except Exception as e:
- logging.exception(e)
logging.debug("calling bucket.Bucket.create(%r, %r)" % (self.name, request.context))
bucket.Bucket.create(self.name, request.context)
- return ''
+ request.finish()
+ return server.NOT_DONE_YET
def render_DELETE(self, request):
logging.debug("Deleting bucket %s" % (self.name))
@@ -230,13 +234,19 @@ class ObjectResource(Resource):
class ImageResource(Resource):
isLeaf = True
+ def __init__(self, name):
+ Resource.__init__(self)
+ self.img = image.Image(name)
+
+ def render_GET(self, request):
+ return static.File(self.img.image_path, defaultType='application/octet-stream').render_GET(request)
+
+class ImagesResource(Resource):
def getChild(self, name, request):
if name == '':
return self
else:
- request.setHeader("Content-Type", "application/octet-stream")
- img = image.Image(name)
- return static.File(img.image_path)
+ return ImageResource(name)
def render_GET(self, request):
""" returns a json listing of all images
@@ -298,9 +308,13 @@ class ImageResource(Resource):
request.setResponseCode(204)
return ''
-def get_application():
+def get_site():
root = S3()
- factory = server.Site(root)
+ site = server.Site(root)
+ return site
+
+def get_application():
+ factory = get_site()
application = service.Application("objectstore")
objectStoreService = internet.TCPServer(FLAGS.s3_port, factory)
objectStoreService.setServiceParent(application)
diff --git a/nova/tests/access_unittest.py b/nova/tests/access_unittest.py
index 8500dd0cbd..832a4b2796 100644
--- a/nova/tests/access_unittest.py
+++ b/nova/tests/access_unittest.py
@@ -22,7 +22,7 @@ import logging
from nova import exception
from nova import flags
from nova import test
-from nova.auth.users import UserManager
+from nova.auth import manager
from nova.auth import rbac
@@ -35,7 +35,7 @@ class AccessTestCase(test.BaseTestCase):
super(AccessTestCase, self).setUp()
FLAGS.fake_libvirt = True
FLAGS.fake_storage = True
- um = UserManager.instance()
+ um = manager.AuthManager()
# Make test users
try:
self.testadmin = um.create_user('testadmin')
@@ -79,7 +79,7 @@ class AccessTestCase(test.BaseTestCase):
#user is set in each test
def tearDown(self):
- um = UserManager.instance()
+ um = manager.AuthManager()
# Delete the test project
um.delete_project('testproj')
# Delete the test user
diff --git a/nova/tests/api_unittest.py b/nova/tests/api_unittest.py
index e5e2afe263..9d072866c0 100644
--- a/nova/tests/api_unittest.py
+++ b/nova/tests/api_unittest.py
@@ -26,7 +26,7 @@ from twisted.internet import defer
from nova import flags
from nova import test
-from nova.auth import users
+from nova.auth import manager
from nova.endpoint import api
from nova.endpoint import cloud
@@ -43,7 +43,11 @@ def boto_to_tornado(method, path, headers, data, host, connection=None):
connection should be a FakeTornadoHttpConnection instance
"""
- headers = httpserver.HTTPHeaders()
+ try:
+ headers = httpserver.HTTPHeaders()
+ except AttributeError:
+ from tornado import httputil
+ headers = httputil.HTTPHeaders()
for k, v in headers.iteritems():
headers[k] = v
@@ -150,7 +154,7 @@ class ApiEc2TestCase(test.BaseTestCase):
def setUp(self):
super(ApiEc2TestCase, self).setUp()
- self.users = users.UserManager.instance()
+ self.manager = manager.AuthManager()
self.cloud = cloud.CloudController()
self.host = '127.0.0.1'
@@ -175,25 +179,22 @@ class ApiEc2TestCase(test.BaseTestCase):
def test_describe_instances(self):
self.expect_http()
self.mox.ReplayAll()
- try:
- self.users.create_user('fake', 'fake', 'fake')
- except Exception, _err:
- pass # User may already exist
+ user = self.manager.create_user('fake', 'fake', 'fake')
+ project = self.manager.create_project('fake', 'fake', 'fake')
self.assertEqual(self.ec2.get_all_instances(), [])
- self.users.delete_user('fake')
+ self.manager.delete_project(project)
+ self.manager.delete_user(user)
def test_get_all_key_pairs(self):
self.expect_http()
self.mox.ReplayAll()
keyname = "".join(random.choice("sdiuisudfsdcnpaqwertasd") for x in range(random.randint(4, 8)))
- try:
- self.users.create_user('fake', 'fake', 'fake')
- except Exception, _err:
- pass # User may already exist
- self.users.generate_key_pair('fake', keyname)
+ user = self.manager.create_user('fake', 'fake', 'fake')
+ project = self.manager.create_project('fake', 'fake', 'fake')
+ self.manager.generate_key_pair(user.id, keyname)
rv = self.ec2.get_all_key_pairs()
self.assertTrue(filter(lambda k: k.name == keyname, rv))
- self.users.delete_user('fake')
-
+ self.manager.delete_project(project)
+ self.manager.delete_user(user)
diff --git a/nova/tests/users_unittest.py b/nova/tests/auth_unittest.py
index 3017210750..0cd377b704 100644
--- a/nova/tests/users_unittest.py
+++ b/nova/tests/auth_unittest.py
@@ -25,41 +25,41 @@ import unittest
from nova import crypto
from nova import flags
from nova import test
-from nova.auth import users
+from nova.auth import manager
from nova.endpoint import cloud
FLAGS = flags.FLAGS
-class UserTestCase(test.BaseTestCase):
+class AuthTestCase(test.BaseTestCase):
flush_db = False
def setUp(self):
- super(UserTestCase, self).setUp()
+ super(AuthTestCase, self).setUp()
self.flags(fake_libvirt=True,
fake_storage=True)
- self.users = users.UserManager.instance()
+ self.manager = manager.AuthManager()
def test_001_can_create_users(self):
- self.users.create_user('test1', 'access', 'secret')
- self.users.create_user('test2')
+ self.manager.create_user('test1', 'access', 'secret')
+ self.manager.create_user('test2')
def test_002_can_get_user(self):
- user = self.users.get_user('test1')
+ user = self.manager.get_user('test1')
def test_003_can_retreive_properties(self):
- user = self.users.get_user('test1')
+ user = self.manager.get_user('test1')
self.assertEqual('test1', user.id)
self.assertEqual('access', user.access)
self.assertEqual('secret', user.secret)
def test_004_signature_is_valid(self):
- #self.assertTrue(self.users.authenticate( **boto.generate_url ... ? ? ? ))
+ #self.assertTrue(self.manager.authenticate( **boto.generate_url ... ? ? ? ))
pass
#raise NotImplementedError
def test_005_can_get_credentials(self):
return
- credentials = self.users.get_user('test1').get_credentials()
+ credentials = self.manager.get_user('test1').get_credentials()
self.assertEqual(credentials,
'export EC2_ACCESS_KEY="access"\n' +
'export EC2_SECRET_KEY="secret"\n' +
@@ -68,14 +68,14 @@ class UserTestCase(test.BaseTestCase):
'export EC2_USER_ID="test1"\n')
def test_006_test_key_storage(self):
- user = self.users.get_user('test1')
+ user = self.manager.get_user('test1')
user.create_key_pair('public', 'key', 'fingerprint')
key = user.get_key_pair('public')
self.assertEqual('key', key.public_key)
self.assertEqual('fingerprint', key.fingerprint)
def test_007_test_key_generation(self):
- user = self.users.get_user('test1')
+ user = self.manager.get_user('test1')
private_key, fingerprint = user.generate_key_pair('public2')
key = RSA.load_key_string(private_key, callback=lambda: None)
bio = BIO.MemoryBuffer()
@@ -87,71 +87,71 @@ class UserTestCase(test.BaseTestCase):
converted.split(" ")[1].strip())
def test_008_can_list_key_pairs(self):
- keys = self.users.get_user('test1').get_key_pairs()
+ keys = self.manager.get_user('test1').get_key_pairs()
self.assertTrue(filter(lambda k: k.name == 'public', keys))
self.assertTrue(filter(lambda k: k.name == 'public2', keys))
def test_009_can_delete_key_pair(self):
- self.users.get_user('test1').delete_key_pair('public')
- keys = self.users.get_user('test1').get_key_pairs()
+ self.manager.get_user('test1').delete_key_pair('public')
+ keys = self.manager.get_user('test1').get_key_pairs()
self.assertFalse(filter(lambda k: k.name == 'public', keys))
def test_010_can_list_users(self):
- users = self.users.get_users()
+ users = self.manager.get_users()
logging.warn(users)
self.assertTrue(filter(lambda u: u.id == 'test1', users))
def test_101_can_add_user_role(self):
- self.assertFalse(self.users.has_role('test1', 'itsec'))
- self.users.add_role('test1', 'itsec')
- self.assertTrue(self.users.has_role('test1', 'itsec'))
+ self.assertFalse(self.manager.has_role('test1', 'itsec'))
+ self.manager.add_role('test1', 'itsec')
+ self.assertTrue(self.manager.has_role('test1', 'itsec'))
def test_199_can_remove_user_role(self):
- self.assertTrue(self.users.has_role('test1', 'itsec'))
- self.users.remove_role('test1', 'itsec')
- self.assertFalse(self.users.has_role('test1', 'itsec'))
+ self.assertTrue(self.manager.has_role('test1', 'itsec'))
+ self.manager.remove_role('test1', 'itsec')
+ self.assertFalse(self.manager.has_role('test1', 'itsec'))
def test_201_can_create_project(self):
- project = self.users.create_project('testproj', 'test1', 'A test project', ['test1'])
- self.assertTrue(filter(lambda p: p.name == 'testproj', self.users.get_projects()))
+ project = self.manager.create_project('testproj', 'test1', 'A test project', ['test1'])
+ self.assertTrue(filter(lambda p: p.name == 'testproj', self.manager.get_projects()))
self.assertEqual(project.name, 'testproj')
self.assertEqual(project.description, 'A test project')
self.assertEqual(project.project_manager_id, 'test1')
self.assertTrue(project.has_member('test1'))
def test_202_user1_is_project_member(self):
- self.assertTrue(self.users.get_user('test1').is_project_member('testproj'))
+ self.assertTrue(self.manager.get_user('test1').is_project_member('testproj'))
def test_203_user2_is_not_project_member(self):
- self.assertFalse(self.users.get_user('test2').is_project_member('testproj'))
+ self.assertFalse(self.manager.get_user('test2').is_project_member('testproj'))
def test_204_user1_is_project_manager(self):
- self.assertTrue(self.users.get_user('test1').is_project_manager('testproj'))
+ self.assertTrue(self.manager.get_user('test1').is_project_manager('testproj'))
def test_205_user2_is_not_project_manager(self):
- self.assertFalse(self.users.get_user('test2').is_project_manager('testproj'))
+ self.assertFalse(self.manager.get_user('test2').is_project_manager('testproj'))
def test_206_can_add_user_to_project(self):
- self.users.add_to_project('test2', 'testproj')
- self.assertTrue(self.users.get_project('testproj').has_member('test2'))
+ self.manager.add_to_project('test2', 'testproj')
+ self.assertTrue(self.manager.get_project('testproj').has_member('test2'))
def test_208_can_remove_user_from_project(self):
- self.users.remove_from_project('test2', 'testproj')
- self.assertFalse(self.users.get_project('testproj').has_member('test2'))
+ self.manager.remove_from_project('test2', 'testproj')
+ self.assertFalse(self.manager.get_project('testproj').has_member('test2'))
def test_209_can_generate_x509(self):
# MUST HAVE RUN CLOUD SETUP BY NOW
self.cloud = cloud.CloudController()
self.cloud.setup()
- private_key, signed_cert_string = self.users.get_project('testproj').generate_x509_cert('test1')
- logging.debug(signed_cert_string)
+ _key, cert_str = self.manager._generate_x509_cert('test1', 'testproj')
+ logging.debug(cert_str)
# Need to verify that it's signed by the right intermediate CA
full_chain = crypto.fetch_ca(project_id='testproj', chain=True)
int_cert = crypto.fetch_ca(project_id='testproj', chain=False)
cloud_cert = crypto.fetch_ca()
logging.debug("CA chain:\n\n =====\n%s\n\n=====" % full_chain)
- signed_cert = X509.load_cert_string(signed_cert_string)
+ signed_cert = X509.load_cert_string(cert_str)
chain_cert = X509.load_cert_string(full_chain)
int_cert = X509.load_cert_string(int_cert)
cloud_cert = X509.load_cert_string(cloud_cert)
@@ -164,42 +164,45 @@ class UserTestCase(test.BaseTestCase):
self.assertFalse(signed_cert.verify(cloud_cert.get_pubkey()))
def test_210_can_add_project_role(self):
- project = self.users.get_project('testproj')
+ project = self.manager.get_project('testproj')
self.assertFalse(project.has_role('test1', 'sysadmin'))
- self.users.add_role('test1', 'sysadmin')
+ self.manager.add_role('test1', 'sysadmin')
self.assertFalse(project.has_role('test1', 'sysadmin'))
project.add_role('test1', 'sysadmin')
self.assertTrue(project.has_role('test1', 'sysadmin'))
def test_211_can_remove_project_role(self):
- project = self.users.get_project('testproj')
+ project = self.manager.get_project('testproj')
self.assertTrue(project.has_role('test1', 'sysadmin'))
project.remove_role('test1', 'sysadmin')
self.assertFalse(project.has_role('test1', 'sysadmin'))
- self.users.remove_role('test1', 'sysadmin')
+ self.manager.remove_role('test1', 'sysadmin')
self.assertFalse(project.has_role('test1', 'sysadmin'))
def test_212_vpn_ip_and_port_looks_valid(self):
- project = self.users.get_project('testproj')
+ project = self.manager.get_project('testproj')
self.assert_(project.vpn_ip)
self.assert_(project.vpn_port >= FLAGS.vpn_start_port)
self.assert_(project.vpn_port <= FLAGS.vpn_end_port)
def test_213_too_many_vpns(self):
- for i in xrange(users.Vpn.num_ports_for_ip(FLAGS.vpn_ip)):
- users.Vpn.create("vpnuser%s" % i)
- self.assertRaises(users.NoMorePorts, users.Vpn.create, "boom")
+ vpns = []
+ for i in xrange(manager.Vpn.num_ports_for_ip(FLAGS.vpn_ip)):
+ vpns.append(manager.Vpn.create("vpnuser%s" % i))
+ self.assertRaises(manager.NoMorePorts, manager.Vpn.create, "boom")
+ for vpn in vpns:
+ vpn.destroy()
def test_299_can_delete_project(self):
- self.users.delete_project('testproj')
- self.assertFalse(filter(lambda p: p.name == 'testproj', self.users.get_projects()))
+ self.manager.delete_project('testproj')
+ self.assertFalse(filter(lambda p: p.name == 'testproj', self.manager.get_projects()))
def test_999_can_delete_users(self):
- self.users.delete_user('test1')
- users = self.users.get_users()
+ self.manager.delete_user('test1')
+ users = self.manager.get_users()
self.assertFalse(filter(lambda u: u.id == 'test1', users))
- self.users.delete_user('test2')
- self.assertEqual(self.users.get_user('test2'), None)
+ self.manager.delete_user('test2')
+ self.assertEqual(self.manager.get_user('test2'), None)
if __name__ == "__main__":
diff --git a/nova/tests/cloud_unittest.py b/nova/tests/cloud_unittest.py
index 128188b0d2..344085cc0c 100644
--- a/nova/tests/cloud_unittest.py
+++ b/nova/tests/cloud_unittest.py
@@ -27,7 +27,7 @@ from xml.etree import ElementTree
from nova import flags
from nova import rpc
from nova import test
-from nova.auth import users
+from nova.auth import manager
from nova.compute import service
from nova.endpoint import api
from nova.endpoint import cloud
@@ -40,8 +40,7 @@ class CloudTestCase(test.BaseTestCase):
def setUp(self):
super(CloudTestCase, self).setUp()
self.flags(fake_libvirt=True,
- fake_storage=True,
- fake_users=True)
+ fake_storage=True)
self.conn = rpc.Connection.instance()
logging.getLogger().setLevel(logging.DEBUG)
@@ -61,15 +60,15 @@ class CloudTestCase(test.BaseTestCase):
self.injected.append(self.compute_consumer.attach_to_tornado(self.ioloop))
try:
- users.UserManager.instance().create_user('admin', 'admin', 'admin')
+ manager.AuthManager().create_user('admin', 'admin', 'admin')
except: pass
- admin = users.UserManager.instance().get_user('admin')
- project = users.UserManager.instance().create_project('proj', 'admin', 'proj')
+ admin = manager.AuthManager().get_user('admin')
+ project = manager.AuthManager().create_project('proj', 'admin', 'proj')
self.context = api.APIRequestContext(handler=None,project=project,user=admin)
def tearDown(self):
- users.UserManager.instance().delete_project('proj')
- users.UserManager.instance().delete_user('admin')
+ manager.AuthManager().delete_project('proj')
+ manager.AuthManager().delete_user('admin')
def test_console_output(self):
if FLAGS.fake_libvirt:
diff --git a/nova/tests/compute_unittest.py b/nova/tests/compute_unittest.py
index b70260c256..5e909abc8f 100644
--- a/nova/tests/compute_unittest.py
+++ b/nova/tests/compute_unittest.py
@@ -58,8 +58,7 @@ class ComputeConnectionTestCase(test.TrialTestCase):
logging.getLogger().setLevel(logging.DEBUG)
super(ComputeConnectionTestCase, self).setUp()
self.flags(fake_libvirt=True,
- fake_storage=True,
- fake_users=True)
+ fake_storage=True)
self.compute = service.ComputeService()
def create_instance(self):
diff --git a/nova/tests/fake_flags.py b/nova/tests/fake_flags.py
index d32f40d8f9..304f248416 100644
--- a/nova/tests/fake_flags.py
+++ b/nova/tests/fake_flags.py
@@ -24,5 +24,5 @@ FLAGS.fake_libvirt = True
FLAGS.fake_storage = True
FLAGS.fake_rabbit = True
FLAGS.fake_network = True
-FLAGS.fake_users = True
+FLAGS.auth_driver = 'nova.auth.ldapdriver.FakeLdapDriver'
FLAGS.verbose = True
diff --git a/nova/tests/model_unittest.py b/nova/tests/model_unittest.py
index f84b6d11c5..34d573854f 100644
--- a/nova/tests/model_unittest.py
+++ b/nova/tests/model_unittest.py
@@ -34,8 +34,7 @@ class ModelTestCase(test.TrialTestCase):
def setUp(self):
super(ModelTestCase, self).setUp()
self.flags(fake_libvirt=True,
- fake_storage=True,
- fake_users=True)
+ fake_storage=True)
def tearDown(self):
model.Instance('i-test').destroy()
diff --git a/nova/tests/network_unittest.py b/nova/tests/network_unittest.py
index a1d1789e2f..a8dba835af 100644
--- a/nova/tests/network_unittest.py
+++ b/nova/tests/network_unittest.py
@@ -23,7 +23,7 @@ import logging
from nova import flags
from nova import test
from nova import utils
-from nova.auth import users
+from nova.auth import manager
from nova.compute import network
from nova.compute.exception import NoMoreAddresses
@@ -32,66 +32,71 @@ FLAGS = flags.FLAGS
class NetworkTestCase(test.TrialTestCase):
def setUp(self):
super(NetworkTestCase, self).setUp()
+ # NOTE(vish): if you change these flags, make sure to change the
+ # flags in the corresponding section in nova-dhcpbridge
self.flags(fake_libvirt=True,
fake_storage=True,
fake_network=True,
+ auth_driver='nova.auth.ldapdriver.FakeLdapDriver',
network_size=32)
logging.getLogger().setLevel(logging.DEBUG)
- self.manager = users.UserManager.instance()
+ self.manager = manager.AuthManager()
self.dnsmasq = FakeDNSMasq()
- try:
- self.manager.create_user('netuser', 'netuser', 'netuser')
- except: pass
+ self.user = self.manager.create_user('netuser', 'netuser', 'netuser')
+ self.projects = []
+ self.projects.append(self.manager.create_project('netuser',
+ 'netuser',
+ 'netuser'))
for i in range(0, 6):
name = 'project%s' % i
- if not self.manager.get_project(name):
- self.manager.create_project(name, 'netuser', name)
+ self.projects.append(self.manager.create_project(name,
+ 'netuser',
+ name))
self.network = network.PublicNetworkController()
def tearDown(self):
super(NetworkTestCase, self).tearDown()
- for i in range(0, 6):
- name = 'project%s' % i
- self.manager.delete_project(name)
- self.manager.delete_user('netuser')
+ for project in self.projects:
+ self.manager.delete_project(project)
+ self.manager.delete_user(self.user)
def test_public_network_allocation(self):
pubnet = IPy.IP(flags.FLAGS.public_range)
- address = self.network.allocate_ip("netuser", "project0", "public")
+ address = self.network.allocate_ip(self.user.id, self.projects[0].id, "public")
self.assertTrue(IPy.IP(address) in pubnet)
self.assertTrue(IPy.IP(address) in self.network.network)
def test_allocate_deallocate_ip(self):
address = network.allocate_ip(
- "netuser", "project0", utils.generate_mac())
+ self.user.id, self.projects[0].id, utils.generate_mac())
logging.debug("Was allocated %s" % (address))
- net = network.get_project_network("project0", "default")
- self.assertEqual(True, is_in_project(address, "project0"))
+ net = network.get_project_network(self.projects[0].id, "default")
+ self.assertEqual(True, is_in_project(address, self.projects[0].id))
mac = utils.generate_mac()
hostname = "test-host"
self.dnsmasq.issue_ip(mac, address, hostname, net.bridge_name)
rv = network.deallocate_ip(address)
# Doesn't go away until it's dhcp released
- self.assertEqual(True, is_in_project(address, "project0"))
+ self.assertEqual(True, is_in_project(address, self.projects[0].id))
self.dnsmasq.release_ip(mac, address, hostname, net.bridge_name)
- self.assertEqual(False, is_in_project(address, "project0"))
+ self.assertEqual(False, is_in_project(address, self.projects[0].id))
def test_range_allocation(self):
mac = utils.generate_mac()
secondmac = utils.generate_mac()
hostname = "test-host"
address = network.allocate_ip(
- "netuser", "project0", mac)
+ self.user.id, self.projects[0].id, mac)
secondaddress = network.allocate_ip(
- "netuser", "project1", secondmac)
- net = network.get_project_network("project0", "default")
- secondnet = network.get_project_network("project1", "default")
+ self.user, self.projects[1].id, secondmac)
+ net = network.get_project_network(self.projects[0].id, "default")
+ secondnet = network.get_project_network(self.projects[1].id, "default")
- self.assertEqual(True, is_in_project(address, "project0"))
- self.assertEqual(True, is_in_project(secondaddress, "project1"))
- self.assertEqual(False, is_in_project(address, "project1"))
+ self.assertEqual(True, is_in_project(address, self.projects[0].id))
+ self.assertEqual(True, is_in_project(secondaddress, self.projects[1].id))
+ self.assertEqual(False, is_in_project(address, self.projects[1].id))
# Addresses are allocated before they're issued
self.dnsmasq.issue_ip(mac, address, hostname, net.bridge_name)
@@ -100,34 +105,34 @@ class NetworkTestCase(test.TrialTestCase):
rv = network.deallocate_ip(address)
self.dnsmasq.release_ip(mac, address, hostname, net.bridge_name)
- self.assertEqual(False, is_in_project(address, "project0"))
+ self.assertEqual(False, is_in_project(address, self.projects[0].id))
# First address release shouldn't affect the second
- self.assertEqual(True, is_in_project(secondaddress, "project1"))
+ self.assertEqual(True, is_in_project(secondaddress, self.projects[1].id))
rv = network.deallocate_ip(secondaddress)
self.dnsmasq.release_ip(secondmac, secondaddress,
hostname, secondnet.bridge_name)
- self.assertEqual(False, is_in_project(secondaddress, "project1"))
+ self.assertEqual(False, is_in_project(secondaddress, self.projects[1].id))
def test_subnet_edge(self):
- secondaddress = network.allocate_ip("netuser", "project0",
+ secondaddress = network.allocate_ip(self.user.id, self.projects[0].id,
utils.generate_mac())
hostname = "toomany-hosts"
- for project in range(1,5):
- project_id = "project%s" % (project)
+ for i in range(1,5):
+ project_id = self.projects[i].id
mac = utils.generate_mac()
mac2 = utils.generate_mac()
mac3 = utils.generate_mac()
address = network.allocate_ip(
- "netuser", project_id, mac)
+ self.user, project_id, mac)
address2 = network.allocate_ip(
- "netuser", project_id, mac2)
+ self.user, project_id, mac2)
address3 = network.allocate_ip(
- "netuser", project_id, mac3)
- self.assertEqual(False, is_in_project(address, "project0"))
- self.assertEqual(False, is_in_project(address2, "project0"))
- self.assertEqual(False, is_in_project(address3, "project0"))
+ self.user, project_id, mac3)
+ self.assertEqual(False, is_in_project(address, self.projects[0].id))
+ self.assertEqual(False, is_in_project(address2, self.projects[0].id))
+ self.assertEqual(False, is_in_project(address3, self.projects[0].id))
rv = network.deallocate_ip(address)
rv = network.deallocate_ip(address2)
rv = network.deallocate_ip(address3)
@@ -135,7 +140,7 @@ class NetworkTestCase(test.TrialTestCase):
self.dnsmasq.release_ip(mac, address, hostname, net.bridge_name)
self.dnsmasq.release_ip(mac2, address2, hostname, net.bridge_name)
self.dnsmasq.release_ip(mac3, address3, hostname, net.bridge_name)
- net = network.get_project_network("project0", "default")
+ net = network.get_project_network(self.projects[0].id, "default")
rv = network.deallocate_ip(secondaddress)
self.dnsmasq.release_ip(mac, secondaddress, hostname, net.bridge_name)
@@ -153,34 +158,36 @@ class NetworkTestCase(test.TrialTestCase):
environment's setup.
Network size is set in test fixture's setUp method.
-
+
There are FLAGS.cnt_vpn_clients addresses reserved for VPN (NUM_RESERVED_VPN_IPS)
And there are NUM_STATIC_IPS that are always reserved by Nova for the necessary
services (gateway, CloudPipe, etc)
- So we should get flags.network_size - (NUM_STATIC_IPS +
- NUM_PREALLOCATED_IPS +
+ So we should get flags.network_size - (NUM_STATIC_IPS +
+ NUM_PREALLOCATED_IPS +
NUM_RESERVED_VPN_IPS)
usable addresses
"""
- net = network.get_project_network("project0", "default")
+ net = network.get_project_network(self.projects[0].id, "default")
# Determine expected number of available IP addresses
num_static_ips = net.num_static_ips
num_preallocated_ips = len(net.hosts.keys())
num_reserved_vpn_ips = flags.FLAGS.cnt_vpn_clients
- num_available_ips = flags.FLAGS.network_size - (num_static_ips + num_preallocated_ips + num_reserved_vpn_ips)
+ num_available_ips = flags.FLAGS.network_size - (num_static_ips +
+ num_preallocated_ips +
+ num_reserved_vpn_ips)
hostname = "toomany-hosts"
macs = {}
addresses = {}
for i in range(0, (num_available_ips - 1)):
macs[i] = utils.generate_mac()
- addresses[i] = network.allocate_ip("netuser", "project0", macs[i])
+ addresses[i] = network.allocate_ip(self.user.id, self.projects[0].id, macs[i])
self.dnsmasq.issue_ip(macs[i], addresses[i], hostname, net.bridge_name)
- self.assertRaises(NoMoreAddresses, network.allocate_ip, "netuser", "project0", utils.generate_mac())
+ self.assertRaises(NoMoreAddresses, network.allocate_ip, self.user.id, self.projects[0].id, utils.generate_mac())
for i in range(0, (num_available_ips - 1)):
rv = network.deallocate_ip(addresses[i])
diff --git a/nova/tests/objectstore_unittest.py b/nova/tests/objectstore_unittest.py
index 8ae1f6e781..c90120a6ec 100644
--- a/nova/tests/objectstore_unittest.py
+++ b/nova/tests/objectstore_unittest.py
@@ -16,6 +16,7 @@
# License for the specific language governing permissions and limitations
# under the License.
+import boto
import glob
import hashlib
import logging
@@ -26,9 +27,13 @@ import tempfile
from nova import flags
from nova import objectstore
from nova import test
-from nova.auth import users
+from nova.auth import manager
+from nova.objectstore.handler import S3
from nova.exception import NotEmpty, NotFound, NotAuthorized
+from boto.s3.connection import S3Connection, OrdinaryCallingFormat
+from twisted.internet import reactor, threads, defer
+from twisted.web import http, server
FLAGS = flags.FLAGS
@@ -52,13 +57,12 @@ os.makedirs(os.path.join(oss_tempdir, 'buckets'))
class ObjectStoreTestCase(test.BaseTestCase):
def setUp(self):
super(ObjectStoreTestCase, self).setUp()
- self.flags(fake_users=True,
- buckets_path=os.path.join(oss_tempdir, 'buckets'),
+ self.flags(buckets_path=os.path.join(oss_tempdir, 'buckets'),
images_path=os.path.join(oss_tempdir, 'images'),
ca_path=os.path.join(os.path.dirname(__file__), 'CA'))
logging.getLogger().setLevel(logging.DEBUG)
- self.um = users.UserManager.instance()
+ self.um = manager.AuthManager()
try:
self.um.create_user('user1')
except: pass
@@ -157,3 +161,107 @@ class ObjectStoreTestCase(test.BaseTestCase):
self.context.user = self.um.get_user('user2')
self.context.project = self.um.get_project('proj2')
self.assertFalse(my_img.is_authorized(self.context))
+
+
+class TestHTTPChannel(http.HTTPChannel):
+ # Otherwise we end up with an unclean reactor
+ def checkPersistence(self, _, __):
+ return False
+
+
+class TestSite(server.Site):
+ protocol = TestHTTPChannel
+
+
+class S3APITestCase(test.TrialTestCase):
+ def setUp(self):
+ super(S3APITestCase, self).setUp()
+
+ FLAGS.auth_driver='nova.auth.ldapdriver.FakeLdapDriver',
+ FLAGS.buckets_path = os.path.join(oss_tempdir, 'buckets')
+
+ self.um = manager.AuthManager()
+ self.admin_user = self.um.create_user('admin', admin=True)
+ self.admin_project = self.um.create_project('admin', self.admin_user)
+
+ shutil.rmtree(FLAGS.buckets_path)
+ os.mkdir(FLAGS.buckets_path)
+
+ root = S3()
+ self.site = TestSite(root)
+ self.listening_port = reactor.listenTCP(0, self.site, interface='127.0.0.1')
+ self.tcp_port = self.listening_port.getHost().port
+
+
+ if not boto.config.has_section('Boto'):
+ boto.config.add_section('Boto')
+ boto.config.set('Boto', 'num_retries', '0')
+ self.conn = S3Connection(aws_access_key_id=self.admin_user.access,
+ aws_secret_access_key=self.admin_user.secret,
+ host='127.0.0.1',
+ port=self.tcp_port,
+ is_secure=False,
+ calling_format=OrdinaryCallingFormat())
+
+ # Don't attempt to reuse connections
+ def get_http_connection(host, is_secure):
+ return self.conn.new_http_connection(host, is_secure)
+ self.conn.get_http_connection = get_http_connection
+
+ def _ensure_empty_list(self, l):
+ self.assertEquals(len(l), 0, "List was not empty")
+ return True
+
+ def _ensure_only_bucket(self, l, name):
+ self.assertEquals(len(l), 1, "List didn't have exactly one element in it")
+ self.assertEquals(l[0].name, name, "Wrong name")
+
+ def test_000_list_buckets(self):
+ d = threads.deferToThread(self.conn.get_all_buckets)
+ d.addCallback(self._ensure_empty_list)
+ return d
+
+ def test_001_create_and_delete_bucket(self):
+ bucket_name = 'testbucket'
+
+ d = threads.deferToThread(self.conn.create_bucket, bucket_name)
+ d.addCallback(lambda _:threads.deferToThread(self.conn.get_all_buckets))
+
+ def ensure_only_bucket(l, name):
+ self.assertEquals(len(l), 1, "List didn't have exactly one element in it")
+ self.assertEquals(l[0].name, name, "Wrong name")
+ d.addCallback(ensure_only_bucket, bucket_name)
+
+ d.addCallback(lambda _:threads.deferToThread(self.conn.delete_bucket, bucket_name))
+ d.addCallback(lambda _:threads.deferToThread(self.conn.get_all_buckets))
+ d.addCallback(self._ensure_empty_list)
+ return d
+
+ def test_002_create_bucket_and_key_and_delete_key_again(self):
+ bucket_name = 'testbucket'
+ key_name = 'somekey'
+ key_contents = 'somekey'
+
+ d = threads.deferToThread(self.conn.create_bucket, bucket_name)
+ d.addCallback(lambda b:threads.deferToThread(b.new_key, key_name))
+ d.addCallback(lambda k:threads.deferToThread(k.set_contents_from_string, key_contents))
+ def ensure_key_contents(bucket_name, key_name, contents):
+ bucket = self.conn.get_bucket(bucket_name)
+ key = bucket.get_key(key_name)
+ self.assertEquals(key.get_contents_as_string(), contents, "Bad contents")
+ d.addCallback(lambda _:threads.deferToThread(ensure_key_contents, bucket_name, key_name, key_contents))
+ def delete_key(bucket_name, key_name):
+ bucket = self.conn.get_bucket(bucket_name)
+ key = bucket.get_key(key_name)
+ key.delete()
+ d.addCallback(lambda _:threads.deferToThread(delete_key, bucket_name, key_name))
+ d.addCallback(lambda _:threads.deferToThread(self.conn.get_bucket, bucket_name))
+ d.addCallback(lambda b:threads.deferToThread(b.get_all_keys))
+ d.addCallback(self._ensure_empty_list)
+ return d
+
+ def tearDown(self):
+ self.um.delete_user('admin')
+ self.um.delete_project('admin')
+ return defer.DeferredList([defer.maybeDeferred(self.listening_port.stopListening)])
+ super(S3APITestCase, self).tearDown()
diff --git a/nova/tests/real_flags.py b/nova/tests/real_flags.py
index 9e106f2276..f054a8f199 100644
--- a/nova/tests/real_flags.py
+++ b/nova/tests/real_flags.py
@@ -24,5 +24,4 @@ FLAGS.fake_libvirt = False
FLAGS.fake_storage = False
FLAGS.fake_rabbit = False
FLAGS.fake_network = False
-FLAGS.fake_users = False
FLAGS.verbose = False
diff --git a/run_tests.py b/run_tests.py
index ae2874f582..5a8966f026 100644
--- a/run_tests.py
+++ b/run_tests.py
@@ -50,6 +50,7 @@ from nova import flags
from nova import twistd
from nova.tests.access_unittest import *
+from nova.tests.auth_unittest import *
from nova.tests.api_unittest import *
from nova.tests.cloud_unittest import *
from nova.tests.compute_unittest import *
@@ -57,7 +58,6 @@ from nova.tests.model_unittest import *
from nova.tests.network_unittest import *
from nova.tests.objectstore_unittest import *
from nova.tests.process_unittest import *
-from nova.tests.users_unittest import *
from nova.tests.validator_unittest import *
from nova.tests.volume_unittest import *
diff --git a/tools/install_venv.py b/tools/install_venv.py
new file mode 100644
index 0000000000..0b35fc8e9f
--- /dev/null
+++ b/tools/install_venv.py
@@ -0,0 +1,94 @@
+"""
+Installation script for Nova's development virtualenv
+"""
+
+import os
+import subprocess
+import sys
+
+
+ROOT = os.path.dirname(os.path.dirname(__file__))
+VENV = os.path.join(ROOT, '.nova-venv')
+PIP_REQUIRES = os.path.join(ROOT, 'tools', 'pip-requires')
+TWISTED_NOVA='http://nova.openstack.org/Twisted-10.0.0Nova.tar.gz'
+
+
+def die(message, *args):
+ print >>sys.stderr, message % args
+ sys.exit(1)
+
+
+def run_command(cmd, redirect_output=True, error_ok=False):
+ # Useful for debugging:
+ #print >>sys.stderr, ' '.join(cmd)
+ if redirect_output:
+ stdout = subprocess.PIPE
+ else:
+ stdout = None
+
+ proc = subprocess.Popen(cmd, stdout=stdout)
+ output = proc.communicate()[0]
+ if not error_ok and proc.returncode != 0:
+ die('Command "%s" failed.\n%s', ' '.join(cmd), output)
+ return output
+
+
+def check_dependencies():
+ """Make sure pip and virtualenv are on the path."""
+ print 'Checking for pip...',
+ if not run_command(['which', 'pip']).strip():
+ die('ERROR: pip not found.\n\nNova development requires pip,'
+ ' please install it using your favorite package management tool')
+ print 'done.'
+
+ print 'Checking for virtualenv...',
+ if not run_command(['which', 'virtualenv']).strip():
+ die('ERROR: virtualenv not found.\n\nNova development requires virtualenv,'
+ ' please install it using your favorite package management tool')
+ print 'done.'
+
+
+def create_virtualenv(venv=VENV):
+ print 'Creating venv...',
+ run_command(['virtualenv', '-q', '--no-site-packages', VENV])
+ print 'done.'
+
+
+def install_dependencies(venv=VENV):
+ print 'Installing dependencies with pip (this can take a while)...'
+ run_command(['pip', 'install', '-E', venv, '-r', PIP_REQUIRES],
+ redirect_output=False)
+ run_command(['pip', 'install', '-E', venv, TWISTED_NOVA],
+ redirect_output=False)
+
+
+def print_help():
+ help = """
+ Nova development environment setup is complete.
+
+ Nova development uses virtualenv to track and manage Python dependencies
+ while in development and testing.
+
+ To activate the Nova virtualenv for the extent of your current shell session
+ you can run:
+
+ $ source .nova-venv/bin/activate
+
+ Or, if you prefer, you can run commands in the virtualenv on a case by case
+ basis by running:
+
+ $ tools/with_venv.sh <your command>
+
+ Also, make test will automatically use the virtualenv.
+ """
+ print help
+
+
+def main(argv):
+ check_dependencies()
+ create_virtualenv()
+ install_dependencies()
+ print_help()
+
+if __name__ == '__main__':
+ main(sys.argv)
diff --git a/tools/pip-requires b/tools/pip-requires
new file mode 100644
index 0000000000..4eb47ca2b0
--- /dev/null
+++ b/tools/pip-requires
@@ -0,0 +1,15 @@
+IPy==0.70
+M2Crypto==0.20.2
+amqplib==0.6.1
+anyjson==0.2.4
+boto==2.0b1
+carrot==0.10.5
+lockfile==0.8
+python-daemon==1.5.5
+python-gflags==1.3
+redis==2.0.0
+tornado==1.0
+wsgiref==0.1.2
+zope.interface==3.6.1
+mox==0.5.0
+-f http://pymox.googlecode.com/files/mox-0.5.0.tar.gz
diff --git a/tools/with_venv.sh b/tools/with_venv.sh
new file mode 100755
index 0000000000..99d1ac18ff
--- /dev/null
+++ b/tools/with_venv.sh
@@ -0,0 +1,4 @@
+#!/bin/bash
+TOOLS=`dirname $0`
+VENV=$TOOLS/../.nova-venv
+source $VENV/bin/activate && $@