diff options
| author | Kevin Benton <blak111@gmail.com> | 2014-10-16 21:27:47 -0700 |
|---|---|---|
| committer | Kevin Benton <kevinbenton@buttewifi.com> | 2014-10-22 09:46:54 +0000 |
| commit | 25c828007d62c0114a0e3eb4c4c17b93cf7b7481 (patch) | |
| tree | 47b793f4e7816d3b2f85d56ca810e5569850084d | |
| parent | 830142e6923ff5fa8303afc22b0b61c39a374fe8 (diff) | |
| download | neutron-25c828007d62c0114a0e3eb4c4c17b93cf7b7481.tar.gz | |
Optimize query in _select_dhcp_ips_for_network_ids
Only query the DB for relevant columns instead of
all of the port columns.
Partial-Bug: #1373851
Change-Id: I32cd4a0bc6799ce77cea13188676308e3e641d19
(cherry picked from commit 8d430a7f2e903dda06d8d75d6abcd63423c4c0a1)
| -rw-r--r-- | neutron/db/securitygroups_rpc_base.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/neutron/db/securitygroups_rpc_base.py b/neutron/db/securitygroups_rpc_base.py index 1dda6bb469..a72b994917 100644 --- a/neutron/db/securitygroups_rpc_base.py +++ b/neutron/db/securitygroups_rpc_base.py @@ -269,7 +269,8 @@ class SecurityGroupServerRpcMixin(sg_db.SecurityGroupDbMixin): def _select_dhcp_ips_for_network_ids(self, context, network_ids): if not network_ids: return {} - query = context.session.query(models_v2.Port, + query = context.session.query(models_v2.Port.mac_address, + models_v2.Port.network_id, models_v2.IPAllocation.ip_address) query = query.join(models_v2.IPAllocation) query = query.filter(models_v2.Port.network_id.in_(network_ids)) @@ -280,14 +281,13 @@ class SecurityGroupServerRpcMixin(sg_db.SecurityGroupDbMixin): for network_id in network_ids: ips[network_id] = [] - for port, ip in query: + for mac_address, network_id, ip in query: if (netaddr.IPAddress(ip).version == 6 and not netaddr.IPAddress(ip).is_link_local()): - mac_address = port['mac_address'] ip = str(ipv6.get_ipv6_addr_by_EUI64(q_const.IPV6_LLA_PREFIX, mac_address)) - if ip not in ips[port['network_id']]: - ips[port['network_id']].append(ip) + if ip not in ips[network_id]: + ips[network_id].append(ip) return ips |