summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Handle MissingAttributeError when using OOB inspections to fetch MACsbugfix/21.0Jacob Anders2023-05-093-1/+29
| | | | | | | | | | | Currently, if an attempt is made to fetch MAC address information using OOB inspection on a Redfish-managed node and EthernetInterfaces attribute is missing on the node, inspection fails due to a MissingAttributeError exception being raised by sushy. This change adds catching and handling this exception. Change-Id: I6f16da05e19c7efc966128fdf79f13546f51b5a6 (cherry picked from commit f10958a542dd58ff301c386ce0981ec218e9eef6)
* Do not move nodes to CLEAN FAILED with empty last_errorDmitry Tantsur2023-03-029-27/+80
| | | | | | | | | | | | | | | | | | | | When cleaning fails, we power off the node, unless it has been running a clean step already. This happens when aborting cleaning or on a boot failure. This change makes sure that the power action does not wipe the last_error field, resulting in a node with provision_state=CLEANFAIL and last_error=None for several seconds. I've hit this in Metal3. Also when aborting cleaning, make sure last_error is set during the transition to CLEANFAIL, not when the clean up thread starts running. While here, make sure to log the current step in all cases, not only when aborting a non-abortable step. Change-Id: Id21dd7eb44dad149661ebe2d75a9b030aa70526f Story: #2010603 Task: #47476 (cherry picked from commit 9a0fa631ca53b40f4dc1877a73e65ded8ac37616)
* Merge "Align iRMC driver with Ironic's default boot_mode" into bugfix/21.0Zuul2023-02-204-17/+40
|\
| * Align iRMC driver with Ironic's default boot_modeVanou Ishii2022-12-084-17/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | This commit modifies iRMC driver to use ironic.conf [deploy] default_boot_mode as default value of boot_mode. Before this commit, iRMC driver assumes Legacy BIOS as default boot_mode and value of default_boot_mode doesn't have any effect on iRMC driver's behavior. Story: 2010381 Task: 46643 Change-Id: Ic5a235785a1a2bb37fef38bd3a86f40125acb3d9 (cherry picked from commit 071cf9b2dd2233509c3cdb8261c0ee7b391e6b2c)
* | Merge "Fix selinux context of published image hardlink" into bugfix/21.0Zuul2023-02-013-12/+52
|\ \
| * | Fix selinux context of published image hardlinkRiccardo Pittau2023-01-193-12/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | If the published image is a hardlink, the source selinux context is preserved. This could cause access denied when retrieving the image using its URL. Change-Id: I550dac9d055ec30ec11530f18a675cf9e16063b5 (cherry picked from commit c05c09fd3ac7ed2c3a5dd13a602e3ae70dfb8734)
* | | Merge "Remove reno job" into bugfix/21.0Zuul2023-01-311-1/+0
|\ \ \
| * | | Remove reno jobRiccardo Pittau2023-01-271-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | It does not make sense to run it on bugfix branches Change-Id: Iace2ff14b1443b0bb6d96d942eff91c5f583a6c1
* | | | Move and fix reno config for releasenotes jobJay Faulkner2023-01-272-4/+5
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In its current place, reno config changes will not cause build-openstack-releasenotes job to run, which means changes can land to that config without being tested. Yikes! Also fixes error in regexp which was preventing this from actually fixing the build-openstack-releasenotes job. Co-Authored-By: Adam McArthur <adam@mcaq.me> Change-Id: I4d46ba06ada1afb5fd1c63db5850a1983e502a6c (cherry picked from commit fbe22b23bc3f1c89822e17417747378c9449ebeb)
* | | Pin tox to version lower than 4Riccardo Pittau2023-01-191-1/+2
|/ / | | | | | | | | | | This branch is based on zed where tox version is lower than 4 Change-Id: Ic4db815d08d286f210863a1b979e4a9fd5fa82bb
* | Fixes for tox 4.0Jay Faulkner2022-12-151-2/+7
|/ | | | | | Formatting changes in config file required for tox 4.0. Change-Id: I84202ac10e9195647162f0b5737ebb610ef1ef93
* Merge "Add support auth protocols for iRMC" into bugfix/21.0Zuul2022-11-146-11/+39
|\
| * Add support auth protocols for iRMCShukun Song2022-10-246-11/+39
| | | | | | | | | | | | | | | | | | | | This patch adds new snmpv3 auth protocols to irmc which are supported from irmc s6. Change-id: Id2fca59bebb0745e6b16caaaa7838d1f1a2717e1 Story: 2010309 Task: 46353 (cherry picked from commit 233c6408389be5f3e271b46154943bc744e0290e)
* | Fix the invalid glance client testDmitry Tantsur2022-11-094-16/+30
|/ | | | | | | | | | | | It relied on mocking tenacity.retry, but it's executed on class initialization. Depending on the ordering, it may do nothing or it may replace ImageService.call with a mock. Instead, add a new tenacity helper that loads an option in runtime. As a nice side effect, [glance]num_retries is now mutable. Change-Id: I2e02231d294997e824db77c998ef8d352fa69075 (cherry picked from commit cab51a9fcc022f2e4bb634277dd20e90e2dc78f7)
* Pin bugfix 21.0 ci jobs to zedRiccardo Pittau2022-09-262-6/+94
| | | | Change-Id: I0d362c163ac0f5e53cfdfa58c051dfde00d4d344
* Correct Image properties lookup for pathsJulia Kreger2022-09-203-92/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | The image lookup process, when handed a path attempts to issue a HEAD request against the path and gets a response which is devoid of details like a content length or any properties. This is expected behavior, however if we have a path, we also know we don't need to explicitly attempt to make an HTTP HEAD request in an attempt to match the glance ``kernel_id`` -> ``kernel`` and similar value population behavior. Also removes an invalid test which was written before the overall method was fully understood. And fixes the default fallback for kickstart template configuration, so that it uses a URL instead of a direct file path. And fix logic in the handling of image property result set, where the code previously assumed a ``stage2`` ramdisk was always required, and based other cleanup upon that. Change-Id: I589e9586d1279604a743746952aeabbc483825df (cherry picked from commit 4d653ac225a26dd83e81477f9d1152fe385c64aa)
* Merge "Redfish: Consider password part of the session cache" into bugfix/21.0Zuul2022-09-164-23/+111
|\
| * Redfish: Consider password part of the session cacheJulia Kreger2022-09-064-23/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, when a password change occured in ironic, the session would not be invalidated, and this, in theory, could lead to all sorts of issues with the old password still being re-used for authentication. In a large environment where credentials for BMCs may not be centralized, this can quickly lead to repeated account lockout experiences for the BMC service account. Anyhow, now we consider it in tracking the sessions, so when the saved password is changed, a new session is established, and the old session is eventually expired out of the cache. Change-Id: I49e1907b89a9096aa043424b205e7bd390ed1a2f (cherry picked from commit c2ba869040f535e4bb83481d1fe9468e7e6991d8)
* | Fix compatibility with oslo.db 12.1.0Stephen Finucane2022-09-081-1/+3
|/ | | | | | | | | | | | | oslo.db 12.1.0 has changed the default value for the 'autocommit' parameter of 'LegacyEngineFacade' from 'True' to 'False'. This is a necessary step to ensure compatibility with SQLAlchemy 2.0. However, we are currently relying on the autocommit behavior and need changes to explicitly manage sessions. Until that happens, we need to override the default. Change-Id: I9e095d810ff5398920e8ffd4f2f089d9b8d29335 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> (cherry picked from commit 74795abf2ff972b2b848eee98426bcdfee2a9c20)
* Improve error message heuristics with jsonschema>=4.8Dmitry Tantsur2022-08-303-11/+23
| | | | | | | | | | | | | | | | Before version 4.8, jsonschema did some wild guessing when producing error messages for schemas with several equivalent subschemas. In version 4.8 it is no longer done, causing error messages that are more correct but also more generic. This change restores guessing the potential root cause without claiming that it's the only possible root cause. Also the traits schema is simplified to make it less ambiguous. See https://github.com/python-jsonschema/jsonschema/issues/991 for details. Change-Id: Ia75cecd2bfbc602b8b2b85bdda20fdc04c5eadf4 (cherry picked from commit 62f9c61ae6657227fd1f5dbc86c59a22b6bac28f)
* redfish: fixes usage of ValueDisplayNameDmitry Tantsur2022-08-263-8/+18
| | | | | | | It's spelled this way, not DisplayValueName. Change-Id: I170d78bdb7ed0f6c36a80a9f2ceb9629f44394ed (cherry picked from commit 9f1f58c6af3aabcb3ae56e5f7b292f07e81e2864)
* Update .gitreview for bugfix/21.0OpenStack Release Bot2022-08-181-0/+1
| | | | Change-Id: Iea0b33e84c17e357d3ddf1b383979d3454f92b11
* Merge "Do not reboot into nowhere after BIOS settings with fast-track"21.0.0Zuul2022-08-174-24/+43
|\
| * Do not reboot into nowhere after BIOS settings with fast-trackDmitry Tantsur2022-08-154-24/+43
| | | | | | | | | | | | | | | | | | Currently, the prepare_ramdisk implementation of the redfish-virtual-media boot interface skips configuring an ISO in fast-track mode. When rebooting after BIOS/RAID settings changes, we need to enforce the correct ISO configuration. Change-Id: Ibdfe0775065f3b27478305dd18929a291df3ee3c
* | Ironic Release 21.0Iury Gregory Melo Ferreira2022-08-172-0/+25
| | | | | | | | | | | | | | This commit bumps the release_mappings to 21.0 to be used in the bugfix branch Change-Id: I2bde869dfb05eb8d9baf035686833980d79e69ef
* | Fix releasenotes before release 21.0Iury Gregory Melo Ferreira2022-08-173-3/+3
| | | | | | | | Change-Id: I347a9a29607268b3e423906fa406b6a7f127bdd0
* | Merge "Document driver_info external_http_url"Zuul2022-08-151-0/+11
|\ \
| * | Document driver_info external_http_urlIury Gregory Melo Ferreira2022-08-111-0/+11
| | | | | | | | | | | | | | | | | | | | | This commit adds documentation about driver_info[external_http_url] Follow-up If6a117a756b7d2a04251792f88c2ee412a040b28 Change-Id: Ia4787c27ed4c53f4ecb911eb0f9d77ea455c25f3
* | | Merge "Override external_http_url at node level"Zuul2022-08-154-9/+107
|\ \ \ | |/ /
| * | Override external_http_url at node levelIury Gregory Melo Ferreira2022-08-104-9/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds support to specify the URL to be used to publish the node image when using virtual media. The option is available under `driver_info['external_http_url']`, if set this value has priority over the values in the configuration file ([deploy]/external_http_url and [deploy]/http_url) Story: 2010221 Task: 45970 Change-Id: If6a117a756b7d2a04251792f88c2ee412a040b28
* | | anaconda: ks liveimg = instance_info/image_infoRuby Loo2022-08-111-3/+5
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | Fix typo. For anaconda deploy interface, ironic sets the kickstart 'liveimg' command with the URL from the ironic node's instance_info's "image_url" value [1], and that "image_url" value is added by ironic code, using the "image_info" value. We don't have code that uses any "liveimg_url" value. [1] https://opendev.org/openstack/ironic/src/commit/ 3d3a67daf7d2969d8da691d12351ab5bb32eca80/ironic/common/ pxe_utils.py#L1003 Change-Id: Ic8ce5fa83768c2632eb190cd87dbf81062c7083a
* | Merge "Fix iRMC driver to use certification file in HTTPS"Zuul2022-08-106-3/+156
|\ \
| * | Fix iRMC driver to use certification file in HTTPSVanou Ishii2022-08-086-3/+156
| |/ | | | | | | | | | | | | | | | | | | | | | | This patch modifies iRMC driver to use certification file when it connects to iRMC via HTTPS Depends-On: https://review.opendev.org/c/openstack/ironic/+/852250 Change-Id: If69ce1cf2789d9d60fb8e544596cf7d29eab514d Co-authored-by: Kobayashi Daisuke <kobayashi.da-06@fujitsu.com> Co-authored-by: Song Shukun <song.shukun@jp.fujitsu.com> Story: 2009801 Task: 44345
* | Merge "Log successful clean up in image cache"Zuul2022-08-101-0/+11
|\ \
| * | Log successful clean up in image cacheDmitry Tantsur2022-08-091-0/+11
| | | | | | | | | | | | Change-Id: I6c53192b69a7b433b2758aa9374cd10b20191af7
* | | Merge "Modify test code to avoid CONF modification affection"Zuul2022-08-099-133/+132
|\ \ \
| * | | Modify test code to avoid CONF modification affectionVanou Ishii2022-08-099-133/+132
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Few unit tests change attribute of CONF variable via Python assignment. This changes attribute of CONF, which is instance of XxxOpt class defined in oslo_config, to Python literal value. This affects result of another unit test. To avoid this, we should change attribute of CONF variable with set_override method. Change-Id: I4bd8b1b4ea974834f1149fcaa79de85d24f5f7d1 Story: 2010214 Task: 45956 Depends-On: https://review.opendev.org/c/openstack/ironic/+/852253
* | | Merge "Update raid_type handling for Redfish raid_config"Zuul2022-08-092-1/+28
|\ \ \
| * | | Update raid_type handling for Redfish raid_configAija Jauntēva2022-08-082-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix indentation for case when raid_type is missing. Generally, it is not expected that raid_type will be missing, this is done as a precaution as raid_type was introduced in Redfish 1.3.1. Now log warning that raid_type is missing, thus cannot update raid_config correctly. Followup to I753c4b00c0a64bcdc89c9bc0afd46f1211f7847b Change-Id: Id66b87309dd26a2a165b35ac1d81580e4605d629
* | | | Merge "Change molds option to appropriate class"Zuul2022-08-091-2/+2
|\ \ \ \
| * | | | Change molds option to appropriate classVanou Ishii2022-08-051-2/+2
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At current, retry_attempt & retry_interval in ironic.conf [molds] is instance of StrOpt. However it should be IntOpt class. If it remains to StrOpt class, tenacity.retry wrapper in common/molds.py will fail with TypeError. Change-Id: Iafedf2ec0326009585c1cac251ecae65c9e666ac Story: 2010215 Task: 45957
* | | | Merge "Fix pxe image lookups"Zuul2022-08-083-6/+77
|\ \ \ \ | |_|/ / |/| | |
| * | | Fix pxe image lookupsJulia Kreger2022-08-043-6/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Image lookups in the PXE interface, for anaconda specific code, were previously hard coded to try and invoke use of glance if needed. Except, not everything is glance. Change-Id: I8791623be95e7e47739ee051753de97eb0e5e2a3
* | | | Merge "Finally remove support for netboot and the boot_option capability"Zuul2022-08-0539-1577/+168
|\ \ \ \ | |/ / / |/| | |
| * | | Finally remove support for netboot and the boot_option capabilityDmitry Tantsur2022-08-0239-1577/+168
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instance network boot (not to be confused with ramdisk, iSCSI or anaconda deploy methods) is insecure, underused and difficult to maintain. This change removes a lot of related code from Ironic. The so called "netboot fallback" is still supported for legacy boot when boot device management is not available or is unreliable. Change-Id: Ia8510e4acac6dec0a1e4f5cb0e07008548a00c52
* | | | Merge "Stop documenting netboot and the boot_option capability"Zuul2022-08-0411-315/+25
|\ \ \ \ | |/ / /
| * | | Stop documenting netboot and the boot_option capabilityDmitry Tantsur2022-08-0111-315/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Both will be removed soon. The documentation change is separated to reduce the size of the final patch. Change-Id: If4b9b0d095500101ca71a453d71ad95252dd8c0c
* | | | Merge "Exit ipxe script if enable_netboot_fallback failed"Zuul2022-08-0313-9/+33
|\ \ \ \
| * | | | Exit ipxe script if enable_netboot_fallback failedDerek Higgins2022-08-0113-9/+33
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sanboot trick to boot from local disk does not work on all hardware. If it fails exit 0 from the iPxe script so that boot continues on the next device which may be the local disk. Story: #2009258 Task: #43470 Change-Id: I1b6303a987a102dfbfd233334395321c25a55212
* | | | Merge "Enable the ramdisk deploy by default"Zuul2022-08-035-6/+11
|\ \ \ \ | | |/ / | |/| |
View Lorry Controller Status