summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Merge "Fix restricted allocation creation for old policy defaults"Zuul2021-12-073-16/+34
|\ \ \ \
| * | | | Fix restricted allocation creation for old policy defaultsTzu-Mainn Chen2021-10-253-16/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The logic for restricted allocation creation checks that the user is not trying to create an allocation with an owner other than themselves. However the logic as it stands will always fail, as it does not check if the user actually set an allocation owner. Change-Id: I780d8e88f9319dc37ab56309bddbfb6b5f3c9d13
* | | | | Merge "Avoid RPC notify_conductor_resume_{deploy,clean} in agent_base"Zuul2021-12-075-146/+177
|\ \ \ \ \
| * | | | | Avoid RPC notify_conductor_resume_{deploy,clean} in agent_baseDmitry Tantsur2021-12-065-146/+177
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we use an RPC call to the conductor itself to proceed to the next clean or deploy step. This is unnecessary and requires temporary lifting the lock, potentially causing race conditions. This change makes the agent code use continue_node_{deploy,clean} directly. The drivers still need updating, it will be done later. Story: #2008167 Task: #40922 Change-Id: If4763d542029b9021432425532f24a0228f04c25
* | | | | | Merge "Refactor common configuration bits from service commands"Zuul2021-12-077-39/+39
|\ \ \ \ \ \ | | |_|_|/ / | |/| | | |
| * | | | | Refactor common configuration bits from service commandsDmitry Tantsur2021-12-017-39/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The prepare_service call from ironic.common.service is changed to also configure guru meditation and profiler. A new call prepare_command is provided for the cases it's not required. Change-Id: I5b9b7b7bc827c8bcda06e9a967deae8577ad87f4
* | | | | | Merge "Add missing mode setting on pxe created directories"Zuul2021-12-073-68/+61
|\ \ \ \ \ \
| * | | | | | Add missing mode setting on pxe created directoriesSteve Baker2021-12-063-68/+61
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two calls to fileutils.ensure_tree were missing the follow-up chmod for CONF.pxe.dir_permission. This is fixed with a local ensure_tree function which creates the directory with the appropriate mode. The configuration help for the permissions attributes clarify that the system default umask is masked out on the supplied value. Change-Id: I124d2ba09b0fc78b284c1ae871ca5a16fc44b8c9
* | | | | | Merge "Trivial: minor follow-up to redfish fix"Zuul2021-12-071-3/+3
|\ \ \ \ \ \
| * | | | | | Trivial: minor follow-up to redfish fixJulia Kreger2021-12-061-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Just fixing two incidents of received being incorrectly spelled and adjusting the attribute error message slightly, in part because it is an entire error, and not just a single missing attribute. Change-Id: Ia59f774c9340e3a6fa63418afedf12098c709052
* | | | | | | Merge "Prepare for bugfix release"Zuul2021-12-068-31/+34
|\ \ \ \ \ \ \
| * | | | | | | Prepare for bugfix releaseRiccardo Pittau2021-12-068-31/+34
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | Change-Id: I8b4900831bd4828f61926c92d4c53f818a8a087a
* | | | | | | Merge "Remove redfish cache entry upon errors"Zuul2021-12-063-1/+111
|\ \ \ \ \ \ \ | | |/ / / / / | |/| | | | |
| * | | | | | Remove redfish cache entry upon errorsJulia Kreger2021-12-023-1/+111
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some transient errors can ultimately cause the client to need to be completely restarted due to cached connection data. Ironic now explicitly removes the cache entry when a sushy AccessError or python AttributeError is detected originating from the library. This will now result in the prior cached connection object to be discarded, and upon the next attempt to interact with the same node, a new connection will be launched. This will result in new sessions being created, but in all likelihood the prior session had already timed out or had been administratively removed. Sushy's code, as of https://review.opendev.org/c/openstack/sushy/+/820076 will raise SessionService lookup access errors as AccessErrors. Prior to that change, they should have been raised as AttributeError as the previous call sould have returned None to be used as an object. Change-Id: Icc6e5dd74d9f15e679a7e764fe49238ed6b8dc1e Story: 2009719 Task: 44107
* | | | | | Merge "Trivial: log current state when continuing cleaning"Zuul2021-12-062-5/+9
|\ \ \ \ \ \
| * | | | | | Trivial: log current state when continuing cleaningDmitry Tantsur2021-12-062-5/+9
| | |/ / / / | |/| | | | | | | | | | | | | | | | Change-Id: I02a8ed6802fffee071e94be3c0cab2382b7e60ca
* | | | | | Merge "Install isolinux on devstack"Zuul2021-12-061-7/+2
|\ \ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Install isolinux on devstackDmitry Tantsur2021-12-031-7/+2
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is required for virtual media BIOS booting. Clean up old bindep tags. Change-Id: I345e5b5287594e62ac7a8abb4de3add242120dfd
* | | | | Fix markup syntaxPierre Riteau2021-12-031-1/+1
|/ / / / | | | | | | | | | | | | Change-Id: I760fefba13c72e89cb39f932a9edeeb32703d55f
* | | | Merge "Remove isfile check from place_loaders_for_boot"Zuul2021-11-292-34/+24
|\ \ \ \ | |/ / / |/| | |
| * | | Remove isfile check from place_loaders_for_bootSteve Baker2021-11-262-34/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | isfile will return False for reasons other than the file being missing (such as a permission denied due to /boot/efi being only root readable). Having the isfile check prevents the actual reason from being logged. This change removes the isfile check so that the error can be triggered and logged in the copy2 call. Change-Id: I1d855a7d7c97cabb83cdb3efc284a00bd65d4d5f
* | | | Merge "Remove default option from create iso image"Zuul2021-11-262-2/+2
|\ \ \ \
| * | | | Remove default option from create iso imageRiccardo Pittau2021-11-252-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | THe -cache-inodes is already default on UNIX like operating systems and it's not safe on other systems that do not have unique inode numbers. Change-Id: I90b77b3a2056a7e627351d2d9e824def868a7b8b
* | | | | Merge "Add a unit test job with Sushy from source"Zuul2021-11-262-0/+26
|\ \ \ \ \
| * | | | | Add a unit test job with Sushy from sourceDmitry Tantsur2021-11-252-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The final goal is to run it on sushy itself to make sure there are no regressions. Change-Id: I6f4bee9a3fa439b1477c41c82304652a801ea55e
* | | | | | Merge "Do not assume sushy constants are strings - part 2"Zuul2021-11-262-4/+5
|\ \ \ \ \ \ | |/ / / / /
| * | | | | Do not assume sushy constants are strings - part 2Dmitry Tantsur2021-11-252-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I42a314dd4d338b169fc5fb9be375ef004e153eac
* | | | | | Merge "Add an option to create inspector-compatible boot.ipxe"Zuul2021-11-267-5/+90
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | Add an option to create inspector-compatible boot.ipxeDmitry Tantsur2021-11-157-5/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the default boot.ipxe is not suitable for ironic-inspector in a standalone configuration. This change adds a new option [pxe]ipxe_fallback_script that makes boot.ipxe fall back to the provided script. Story: #2009294 Task: #43982 Change-Id: Id5547885e75beafb4423e9e2056c79c54b286275
* | | | | | Merge "Enable iPXE boot interface by default"Zuul2021-11-252-1/+11
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | Enable iPXE boot interface by defaultDmitry Tantsur2021-11-082-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | iPXE is the recommended boot method (when virtual media is not available). Now that a pre-built binary is available for AARCH64, there are very few reasons to use plain PXE over it. Change-Id: Iedd70ac2ec0a59c531f5c811b4f5c65a2aafff4d
* | | | | | Updating yoga tested python versions in classifierGhanshyam Mann2021-11-241-2/+1
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Yoga testing runtime has been updated with py38 and py39 as voting and removed the py36 testing. Unit tests update are handled by the job template change in openstack-zuul-job and you can see the updated jobs running in gate. - https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/818609 this commit updates the tested py versions in setup.cfg classifier. [1] https://governance.openstack.org/tc/reference/runtimes/yoga.html Change-Id: Ie527ea6ed8820c3f9dcca5c875c428288070263b
* | | | | Merge "Clarify driver load error message"Zuul2021-11-241-1/+2
|\ \ \ \ \
| * | | | | Clarify driver load error messageJulia Kreger2021-11-231-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The NoValidDefaultForInterface exception is a little misleading in that if one doesn't have the base interface enabled, and they attempt to enable a hardware type which requires or only supports disabled interfaces, they will also get an exeption. The reality is we need to suggest for them to look at enabling the interfaces before looking at the default interface overrides, because logically the brain jumps to setting a default before checking the interface settings. Change-Id: I50d4381e11da96cb7ae0ee8cbda18534380bd471
* | | | | | Merge "Enable Redfish by default"Zuul2021-11-237-155/+17
|\ \ \ \ \ \ | |/ / / / / |/| / / / / | |/ / / /
| * | | | Enable Redfish by defaultDmitry Tantsur2021-11-057-155/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Redfish has become an established technology with growing popularity. By enabling it by default we make it easier for operators to use Ironic, especially its advanced features, out of box. Bump stevedore to match sushy. Change-Id: I94dd4066ac598a7e5c2e0812e1ff286de5d164a2
* | | | | Merge "Add platform:rpm shim, grub packages to bindep"Zuul2021-11-231-0/+2
|\ \ \ \ \
| * | | | | Add platform:rpm shim, grub packages to bindepSteve Baker2021-10-281-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These already exist for platform:dpkg Change-Id: I074b5d3f338d908e6d028163d01f0863395ecbfe
* | | | | | Merge "Create node get_interface method"Zuul2021-11-2211-13/+36
|\ \ \ \ \ \
| * | | | | | Create node get_interface methodTzu-Mainn Chen2021-11-0811-13/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A node's interface can be temporarily overriden in instance_info. However, some parts of the Ironic code still used a node's interface attribute directly. This change adds a node get_interface method and updates various parts of the Ironic code to use it. Change-Id: Ifdaa21383f71b501bccb6cf8fe80e5b34661b6ae
* | | | | | | Merge "Use default test dir"Zuul2021-11-221-1/+0
|\ \ \ \ \ \ \
| * | | | | | | Use default test dirRiccardo Pittau2021-11-191-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test dir is already defined in .stestr.conf Change-Id: I0d620ac5e9f7eeaae86243a9235f431a9114804b
* | | | | | | | Merge "Fix some of the SRBAC tests"Zuul2021-11-221-20/+19
|\ \ \ \ \ \ \ \
| * | | | | | | | Fix some of the SRBAC testsJulia Kreger2021-11-181-20/+19
| | |_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In all of the copying/pasting/repeating, some misalignments between labels/parameters utilized for the RBAC tests occured. Nothing serious, everything seems to be just fine. Change-Id: Ib0ded5a53e586e10006b066241f4b4a92bb2c463
* | | | | | | | Merge "Stop relying on explicit values of Redfish constants"Zuul2021-11-224-22/+51
|\ \ \ \ \ \ \ \
| * | | | | | | | Stop relying on explicit values of Redfish constantsDmitry Tantsur2021-11-104-22/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are a few places in unit tests where we rely on Redfish constants having well-known values. Use constants themselves instead. An even more problematic place is _set_boot_device: it relies on storing Redfish constants in driver_internal_info. With the future switch to enums, it will no longer be possible. Use Ironic constants and provide a compatibility layer. Change-Id: I8e075f808e013afd778dd7cdc0927fe339309b70
* | | | | | | | | CI: Fix devstack plugin with RBAC changesJulia Kreger2021-11-192-19/+24
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes a neutron call to be project scoped as system scoped can't create a resource and, and removes the unset which no longer makes sense now that I86ffa9cd52454f1c1c72d29b3a0e0caa3e44b829 has merged removing the legacy vars from devstack. Also renames intenral use setting of OS_CLOUD to IRONIC_OS_CLOUD as some services were still working with system scope or some sort of mixed state occuring previously as some of the environment variables were present still, however they have been removed from devstack. This change *does* explicitly set an OS_CLOUD variable as well on the base ironic job. This is because things like grenade for Xena will expect the variable to be present. Depends-On: https://review.opendev.org/c/openstack/devstack/+/818449 Change-Id: I912527d7396a9c6d8ee7e90f0c3fd84461d443c1
* | | | | | | | Merge "Reduce the number of small functions in pxe_utils"Zuul2021-11-172-97/+35
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | |
| * | | | | | | Reduce the number of small functions in pxe_utilsDmitry Tantsur2021-11-152-97/+35
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This module contains a lot of trivial single-line functions that make reading it unnecessarily complicated. This change removes some of them. Change-Id: Ie26c011b5ed3cb406c5cc4e2f50bbbf622d3a8c8
* | | | | | | Merge "[iRMC] Convert the type of irmc_port to int"Zuul2021-11-163-1/+9
|\ \ \ \ \ \ \