diff options
| author | Aija Jauntēva <aija.jaunteva@dell.com> | 2022-08-08 06:15:35 -0400 |
|---|---|---|
| committer | Aija Jauntēva <aija.jaunteva@dell.com> | 2022-08-10 06:33:33 -0400 |
| commit | 5171205cebb20c4224066f976f1216d2568932be (patch) | |
| tree | a2e57e816f6630734d50e78ddc274b1ac083c8da /ironic/tests/unit/drivers/modules/redfish/test_raid.py | |
| parent | 501cd3a54da305f13acd8d328e23cd14d458e7c1 (diff) | |
| download | ironic-5171205cebb20c4224066f976f1216d2568932be.tar.gz | |
Update raid_type handling for Redfish raid_config
Fix indentation for case when raid_type is missing.
Generally, it is not expected that raid_type will be
missing, this is done as a precaution as raid_type
was introduced in Redfish 1.3.1. Now log warning
that raid_type is missing, thus cannot update
raid_config correctly.
Followup to I753c4b00c0a64bcdc89c9bc0afd46f1211f7847b
Change-Id: Id66b87309dd26a2a165b35ac1d81580e4605d629
(cherry picked from commit 3a621e3983eb2eb1d013d687acc3f5981cdfbc64)
Diffstat (limited to 'ironic/tests/unit/drivers/modules/redfish/test_raid.py')
| -rw-r--r-- | ironic/tests/unit/drivers/modules/redfish/test_raid.py | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/ironic/tests/unit/drivers/modules/redfish/test_raid.py b/ironic/tests/unit/drivers/modules/redfish/test_raid.py index b2d3a0a0e..dfb3c1473 100644 --- a/ironic/tests/unit/drivers/modules/redfish/test_raid.py +++ b/ironic/tests/unit/drivers/modules/redfish/test_raid.py @@ -1483,3 +1483,22 @@ class RedfishRAIDTestCase(db_base.DbTestCase): mock_reboot.assert_not_called() # Not yet updated as in progress self.assertEqual({}, task.node.raid_config) + + @mock.patch.object(redfish_raid, 'LOG', autospec=True) + def test_update_raid_config_missing_raid_type( + self, mock_log, mock_get_system): + volumes = [ + _mock_volume( + '1', raid_type=None, + capacity_bytes=100 * units.Gi), + _mock_volume( + '2', raid_type=None, + capacity_bytes=500 * units.Gi)] + self.mock_storage.volumes.get_members.return_value = volumes + mock_get_system.return_value.storage.get_members.return_value = [ + self.mock_storage] + + redfish_raid.update_raid_config(self.node) + + self.assertEqual([], self.node.raid_config['logical_disks']) + mock_log.warning.assert_called_once() |