summaryrefslogtreecommitdiff
path: root/ironic/tests/unit/api/controllers/v1/test_node.py
diff options
context:
space:
mode:
authorDmitry Tantsur <dtantsur@protonmail.com>2022-01-24 18:33:22 +0100
committerDmitry Tantsur <dtantsur@protonmail.com>2022-02-03 17:30:30 +0000
commitf5615dc815f80c3830a7ddfe341856533223dff5 (patch)
tree4526c9f7da06e01b68595ce752f4cd59b2562ce1 /ironic/tests/unit/api/controllers/v1/test_node.py
parentf15ae9689dba28b08778bf24ba77f88f57d4ec48 (diff)
downloadironic-f5615dc815f80c3830a7ddfe341856533223dff5.tar.gz
Fix resource_url in the remaining resources
Node history was particularly affected: limit was not converted from string to integer, so "next" link was never added. Add some safeguards to the generic API code. Change-Id: I1328e2f07621bf7e39b96eb4a7ddb66c9a2b65bb (cherry picked from commit 55144d3bd262be35c7a034fea083c3ed73fd63d8)
Diffstat (limited to 'ironic/tests/unit/api/controllers/v1/test_node.py')
-rw-r--r--ironic/tests/unit/api/controllers/v1/test_node.py10
1 files changed, 10 insertions, 0 deletions
diff --git a/ironic/tests/unit/api/controllers/v1/test_node.py b/ironic/tests/unit/api/controllers/v1/test_node.py
index ee957178c..3c913834e 100644
--- a/ironic/tests/unit/api/controllers/v1/test_node.py
+++ b/ironic/tests/unit/api/controllers/v1/test_node.py
@@ -7841,6 +7841,10 @@ class TestNodeHistory(test_api_base.BaseApiTest):
self.assertEqual(1, len(entries))
result_uuid = entries[0]['uuid']
self.assertEqual(self.event1.uuid, result_uuid)
+ self.assertIn('next', ret)
+ self.assertIn('nodes/%s/history' % self.node.uuid, ret['next'])
+ self.assertIn('limit=1', ret['next'])
+ self.assertIn('marker=%s' % result_uuid, ret['next'])
# Second request
ret = self.get_json('/nodes/%s/history?limit=1&marker=%s' %
(self.node.uuid, result_uuid),
@@ -7850,6 +7854,9 @@ class TestNodeHistory(test_api_base.BaseApiTest):
self.assertEqual(1, len(entries))
result_uuid = entries[0]['uuid']
self.assertEqual(self.event2.uuid, result_uuid)
+ self.assertIn('nodes/%s/history' % self.node.uuid, ret['next'])
+ self.assertIn('limit=1', ret['next'])
+ self.assertIn('marker=%s' % result_uuid, ret['next'])
# Third request
ret = self.get_json('/nodes/%s/history?limit=1&marker=%s' %
(self.node.uuid, result_uuid),
@@ -7859,3 +7866,6 @@ class TestNodeHistory(test_api_base.BaseApiTest):
self.assertEqual(1, len(entries))
result_uuid = entries[0]['uuid']
self.assertEqual(self.event3.uuid, result_uuid)
+ self.assertIn('nodes/%s/history' % self.node.uuid, ret['next'])
+ self.assertIn('limit=1', ret['next'])
+ self.assertIn('marker=%s' % result_uuid, ret['next'])