diff options
| author | Yushiro FURUKAWA <y.furukawa_2@jp.fujitsu.com> | 2020-09-08 23:54:45 +0900 |
|---|---|---|
| committer | Yushiro FURUKAWA <y.furukawa_2@jp.fujitsu.com> | 2020-09-29 13:00:52 +0000 |
| commit | 0e399f750ad88823c4d8c6355b70f23d98797ee8 (patch) | |
| tree | fa0f6a34a2cfe81f319aa65a82690fc06eb9d19f /ironic/drivers/modules/irmc | |
| parent | 2151d660d2156c5f75986fbebe2fc7f35b0de81b (diff) | |
| download | ironic-0e399f750ad88823c4d8c6355b70f23d98797ee8.tar.gz | |
Fix handling OctetString for pysnmp
This commit fixes getting MAC address while inspection for iRMC driver.
To remove ord() in retrieving MAC address, it can avoid the following
exception:
TypeError: ord() expected string of length 1, but int found
Also, this commit sets the following type of mock for UT. So, I add
'pysnmp'[1] into test-requirements.txt and lower-constraints.txt.
* pysnmp.proto.rfc1902.OctetString
* pysnmp.proto.rfc1902.Integer32
[1] https://bit.ly/3bDeTCH
Change-Id: I1e013a93854e01a7060e1fc48aac091e7e9b74cb
Diffstat (limited to 'ironic/drivers/modules/irmc')
| -rw-r--r-- | ironic/drivers/modules/irmc/inspect.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ironic/drivers/modules/irmc/inspect.py b/ironic/drivers/modules/irmc/inspect.py index 87b8fb928..4e148ee5c 100644 --- a/ironic/drivers/modules/irmc/inspect.py +++ b/ironic/drivers/modules/irmc/inspect.py @@ -110,7 +110,7 @@ def _get_mac_addresses(node): d_info['irmc_snmp_security']) node_classes = snmp_client.get_next(NODE_CLASS_OID) - mac_addresses = [':'.join(['%02x' % ord(x) for x in mac]) + mac_addresses = [':'.join(['%02x' % x for x in mac]) for mac in snmp_client.get_next(MAC_ADDRESS_OID)] return [a for c, a in zip(node_classes, mac_addresses) |