diff options
| author | Steve Baker <sbaker@redhat.com> | 2021-11-19 15:10:48 +1300 |
|---|---|---|
| committer | Steve Baker <sbaker@redhat.com> | 2022-01-05 16:05:46 +1300 |
| commit | b66d371fd6c32513bd1028333b00f2c1315e67d0 (patch) | |
| tree | 5d1c17c376deb836b3489da0761dc0f5252f6b1b /ironic/drivers/modules/irmc/management.py | |
| parent | c2d98c2294979114c702b2a662a768af0c29fadf (diff) | |
| download | ironic-b66d371fd6c32513bd1028333b00f2c1315e67d0.tar.gz | |
Use driver_internal_info methods for other drivers
This change switches the rest of the driver classes to using
set_driver_internal_info, del_driver_internal_info,
timestamp_driver_internal_info node methods for modifying
driver_internal_info.
This completes the switchover to using these methods, outside of unit
tests there should be no direct modifying of driver_internal_info
values.
Change-Id: I17772a3274f09ee02390cc6e941ca302f396a03c
Diffstat (limited to 'ironic/drivers/modules/irmc/management.py')
| -rw-r--r-- | ironic/drivers/modules/irmc/management.py | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/ironic/drivers/modules/irmc/management.py b/ironic/drivers/modules/irmc/management.py index 99a719a15..079ae9e44 100644 --- a/ironic/drivers/modules/irmc/management.py +++ b/ironic/drivers/modules/irmc/management.py @@ -139,9 +139,8 @@ def backup_bios_config(task): error=e) # Save bios config into the driver_internal_info - internal_info = task.node.driver_internal_info - internal_info['irmc_bios_config'] = result['bios_config'] - task.node.driver_internal_info = internal_info + task.node.set_driver_internal_info('irmc_bios_config', + result['bios_config']) task.node.save() LOG.info('BIOS config is backed up successfully for node %s', @@ -170,14 +169,12 @@ def _restore_bios_config(task): def _remove_bios_config(task, reboot_flag=False): """Remove backup bios config from the node.""" - internal_info = task.node.driver_internal_info - internal_info.pop('irmc_bios_config', None) + task.node.del_driver_internal_info('irmc_bios_config') # NOTE(tiendc): If reboot flag is raised, then the BM will # reboot and cause a bug if the next clean step is in-band. # See https://storyboard.openstack.org/#!/story/2002731 if reboot_flag: - internal_info['cleaning_reboot'] = True - task.node.driver_internal_info = internal_info + task.node.set_driver_internal_info('cleaning_reboot', True) task.node.save() irmc_info = irmc_common.parse_driver_info(task.node) |