diff options
| author | Vanou Ishii <ishii.vanou@fujitsu.com> | 2022-10-25 04:09:46 -0400 |
|---|---|---|
| committer | Vanou Ishii <ishii.vanou@fujitsu.com> | 2022-11-06 21:55:58 -0500 |
| commit | 2200f931de0d2515397781a8c7db66c636d2b297 (patch) | |
| tree | c37bd097b3c5001966f5eed2470aa2389cfa90e6 | |
| parent | d930dcd322aec436f93c818746c65d5c204d2f56 (diff) | |
| download | ironic-2200f931de0d2515397781a8c7db66c636d2b297.tar.gz | |
Change boot_interface order of iRMC driver
This change aligns the boot interface order of the irmc
hardware type to match the other hardware type interface
order lists.
This change is a result of an operator reporting inconsistent
behavior of ironic when they are adding nodes using the irmc
hardware type, where they would default to use the "irmc-pxe" boot
interface, where as the other interfaces would end up defaulting
to "ipxe".
Change-Id: I017c6560f9de884eefb2c1925321380cc1c721e2
| -rw-r--r-- | ironic/drivers/irmc.py | 4 | ||||
| -rw-r--r-- | releasenotes/notes/irmc-change-boot-interface-order-e76f5018da116a90.yaml | 26 |
2 files changed, 28 insertions, 2 deletions
diff --git a/ironic/drivers/irmc.py b/ironic/drivers/irmc.py index f3c2d7c65..50bb9114d 100644 --- a/ironic/drivers/irmc.py +++ b/ironic/drivers/irmc.py @@ -48,8 +48,8 @@ class IRMCHardware(generic.GenericHardware): """List of supported boot interfaces.""" # NOTE: Support for pxe boot is deprecated, and will be # removed from the list in the future. - return [boot.IRMCVirtualMediaBoot, boot.IRMCPXEBoot, - ipxe.iPXEBoot, pxe.PXEBoot] + return [boot.IRMCVirtualMediaBoot, ipxe.iPXEBoot, + boot.IRMCPXEBoot, pxe.PXEBoot] @property def supported_console_interfaces(self): diff --git a/releasenotes/notes/irmc-change-boot-interface-order-e76f5018da116a90.yaml b/releasenotes/notes/irmc-change-boot-interface-order-e76f5018da116a90.yaml new file mode 100644 index 000000000..3ad35a07c --- /dev/null +++ b/releasenotes/notes/irmc-change-boot-interface-order-e76f5018da116a90.yaml @@ -0,0 +1,26 @@ +--- +fixes: + - | + Fixes the default boot interface order for the ``irmc`` hardware type + where previously it would prefer ``irmc-pxe`` over ``ipxe``. This + created inconsistencies for operators using multiple hardware types, + where both interfaces were enabled in the deployment. +upgrade: + - | + Operators who are upgrading should be aware that a bug was discovered + with the automatic selection of ``boot_interface`` for users of the + ``irmc`` hardware types. This was an inconsistency, resulting in + ``irmc-pxe`` being selected instead of ``ipxe`` if these boot + interfaces were enabled. Depending on the local configuration, + this may, or may not have happened and will remain static on + preexisting baremetal nodes. Some users may have been relying upon + this incorrect behavior by having mis-alligned defaults by trying to + use the ``irmc-pxe`` interface for ``ipxe``. Users wishing to continue + this usage as it was previously will need to explicitly set a + ``boot_interface`` value to either ``pxe`` or ``irmc-pxe``, depending + on the local configuration. Most operators have leveraged the default + examples, and thus did not explicitly encounter this condition. + Operators explicitly wishing to use ``pxe`` boot interfaces with + the ``ipxe`` templates and defaults set to override the defaults + for ``ironic.conf`` will need to either continue to leverage default + override configurations in their ``ironic.conf`` file. |