diff options
| author | Dmitry Tantsur <dtantsur@protonmail.com> | 2020-07-30 11:38:16 +0200 |
|---|---|---|
| committer | Dmitry Tantsur <dtantsur@protonmail.com> | 2020-07-30 11:38:16 +0200 |
| commit | 040523ad1066a77f19134df129275938bee45d04 (patch) | |
| tree | 9d86b4a275ac5abe00e474ab8c3999461ac33a61 | |
| parent | ebae6a40f1131f2b4602e7deddd2a8bd6382ae22 (diff) | |
| download | ironic-040523ad1066a77f19134df129275938bee45d04.tar.gz | |
Log the traceback of unexpected errors when verifying power credentials
Otherwise some issues can be hard to debug.
Change-Id: I2da14e488b9abeee4028c0986778ddae39a9dde0
| -rw-r--r-- | ironic/conductor/manager.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/ironic/conductor/manager.py b/ironic/conductor/manager.py index ef7debbe0..c8a7a2b20 100644 --- a/ironic/conductor/manager.py +++ b/ironic/conductor/manager.py @@ -1228,6 +1228,8 @@ class ConductorManager(base_manager.BaseConductorManager): error = (_('Failed to validate power driver interface for node ' '%(node)s. Error: %(msg)s') % {'node': node.uuid, 'msg': e}) + log_traceback = not isinstance(e, exception.IronicException) + LOG.error(error, exc_info=log_traceback) else: try: power_state = task.driver.power.get_power_state(task) @@ -1235,6 +1237,8 @@ class ConductorManager(base_manager.BaseConductorManager): error = (_('Failed to get power state for node ' '%(node)s. Error: %(msg)s') % {'node': node.uuid, 'msg': e}) + log_traceback = not isinstance(e, exception.IronicException) + LOG.error(error, exc_info=log_traceback) if error is None: if power_state != node.power_state: @@ -1246,7 +1250,6 @@ class ConductorManager(base_manager.BaseConductorManager): else: task.process_event('done') else: - LOG.error(error) node.last_error = error task.process_event('fail') |