summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Consume tempest-horizon from PyPI releasequeens-eolstable/queensAkihiro Motoki2021-02-181-3/+1
| | | | | | | | | | | tempest-horizon has been retired (at least in the project-config level), so we cannot specify openstack/tempest-horizon in required-projects. Instead we need to install tempest-horizon from PyPI. The similar approach is adopted in stable/stein [1]. [1] https://review.opendev.org/c/openstack/horizon/+/771740 Change-Id: I80d67384a643362746c2e037da539503a8095d7b
* Merge "Fix open redirect" into stable/queensZuul2020-12-263-3/+42
|\
| * Fix open redirectRadomir Dopieralski2020-12-183-3/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure the "next" URL is in the same origin as Horizon before redirecting to it. Conflicts: horizon/test/unit/workflows/test_workflows.py Adapted to work with Django before 1.11 which only has a host argument, instead of allowed_hosts for django.utils.http.is_safe_url(). Change-Id: I06b2bfc8e3638591615547780c3fa34b0abe19f6 Closes-bug: #1865026 (cherry picked from commit 252467100f75587e18df9c43ed5802ee8f0017fa) (cherry picked from commit baa370f84332ad41502daea29a551705696f4421) (cherry picked from commit 6c208edf323ced07b15ec4bc3879bddb91d398bc)
* | Fix horizon-nodejs jobsAndreas Jaeger2020-12-182-1/+44
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | Tox is not anymore pre-installed on the OpenDev CI images. The file package.json needs tox, install it to fix the job. Install it via a pre-run playbook so that this is run in addition to all of the playbooks of the parent. Note for the reviewer in stable/stein we run nodejs-4 jobs as runtime. I have cherry-pick this change from master which run nodejs-10 job but simliar changes fixes the nodejs-4 jobs So I have added pre-run playbook for nodejs-4 job as well. Note in stable/rocky: We used nodejs4-jobs from openstack-zuul-jobs which consumes npm jobs from zuul-jobs. We would like to install tox in the 'pre-run' phase in each npm job, so this commit borrows the npm job definitions in stable/stein including the cherry-picked commit. Conflicts: .zuul.yaml Resolved automatically. Change-Id: Icf82fa96f7d90453f78cf564c847682a286ed575 (cherry picked from commit 7cd0debebe1a300a96f8d0f21626793be0a0bc41) (cherry picked from commit 8da0dcd21200cc851e57de4dfa46c3c838c73c3c) (cherry picked from commit 8f8ed624082613b7f249e94afab4e50202b22a1d)
* Gate fix: use tempest-horizon 0.2.0 explicitlyAkihiro Motoki2020-05-161-0/+1
| | | | | | | | | | | tempest-horizon master no longer support python 2.7, but the tempest job in stable/rocky (and older) runs with python 2.7. tempest-horizon 0.2.0 is the last release with python 2.7, so we need to use the version explicitly. Change-Id: Ia5ae3aa2b024f554eb8c068b9cc271998db6f909 Closes-Bug: #1874171 (cherry picked from commit 569e06f230ef3a0f9adfa518a96370224dbdf996)
* Merge "Avoid forced logout when 403 error encountered" into stable/queensZuul2020-04-164-15/+17
|\
| * Avoid forced logout when 403 error encounteredGloria Gu2020-01-174-15/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this change when a 403 error was encountered, such as failure to have the permission to perform an operation, the user would get logged out from UI pages written in the AngularJS framework. For example, if an admin user lacks the get_project permission and tries to access the images page, project->compute->images, the 403 will forcibly log out the user. This change keeps the user logged in when a 403 error is encountered and displays an error message. The change only affects AngularJS pages. Change-Id: I10a6eeb96dd1418449e1d15b1a3869cd4de9cafa Closes-bug: #1840844 (cherry picked from commit ab0e96df9506fb6f1783e0ee79b63934dabe0cbe) (cherry picked from commit 81740d310f7078a10435ecbeb3e7a31bc62c7497)
* | Merge "Fix typo in publicize_image policy name" into stable/queensZuul2020-03-212-1/+12
|\ \
| * | Fix typo in publicize_image policy nameIvan Kolodyazhny2020-01-172-1/+12
| |/ | | | | | | | | | | | | | | | | | | | | This patch is not cherry-picked from stable/train because if was fixed in a scope of a new feature implementation with https://review.opendev.org/#/c/602468/ commit. Change-Id: I519e15afc975e6da2afb9c72a05448541572bd10 Closes-Bug: 1859041 (cherry picked from commit fe61f2358a6e16ea462630747180b83337eb5b55) (cherry picked from commit ed23eb60d4674e7d50f9f13cc926d3e3bb4f1121)
* | Ensure python versionsAkihiro Motoki2020-01-111-1/+15
|/ | | | | | | | | It looks like better to specify basepython for all tox envs. As of the queens release, we use python 2.7 by default. http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010957.html Change-Id: I586d1f63039b71f2ec757b06eb32a30a52705568
* Fix deleting port from port details pageTatiana Ovchinnikova2019-12-041-1/+2
| | | | | | | | | This patch fixes "Delete port" button at the port details page: Project -> Network -> Networks -> <network name> -> Ports -> <port name> Change-Id: I84f4da9c84d75c458b54bd456cbc7b92b303ba81 Closes-Bug: #1854514 (cherry picked from commit 18020e30b67efa9e67d061c317804a6f800b74c7)
* Fix quoting in zuul for tempest pluginsIvan Kolodyazhny2019-12-041-1/+1
| | | | | | | | | | | | Something has changed and the quoting used in the zuul jobs configuration no longer works. This patch removes the excess quoting. Conflicts: .zuul.yaml Change-Id: I4c6c3b1d0e0c38c8130440c2b6c162fd65532179 (cherry picked from commit e17325dd3bcedffe0b1a96c02b00e918d191a743)
* Merge "Fix listing security groups when no rules" into stable/queensqueens-em13.0.3Zuul2019-10-094-4/+19
|\
| * Fix listing security groups when no rulesAkihiro Motoki2019-10-034-4/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When listing security groups in the dashboard and one or more security groups had no rules it failed because python throws a KeyError. This commit changes the neutron API wrapper in horizon to ensure ensure rule information in SG always exists. Closes-Bug: #1840465 Co-Authored-By: Tobias Urdin <tobias.urdin@binero.se> Change-Id: I6e05a7dc6b6655514ee2bff6bd327da86f13900a (cherry picked from commit cdb191ec83f86dffade56be07ca53077d7c78b14) (cherry picked from commit 205c4465cdf8112779e8eb5f1618dcfc1b11e305)
* | Merge "Add Allowed Address Pair/Delete buttons are only visible to admin" ↵Zuul2019-10-093-0/+248
|\ \ | |/ |/| | | into stable/queens
| * Add Allowed Address Pair/Delete buttons are only visible to adminShilpa Devharakar2019-09-263-0/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initially In Queens, when logging into Horizon in context of a _member_ in any project, the "Add Allowed Address Pair" and "Delete" buttons in "Network" -> "Networks" -> <select a network> -> "Ports" -> <select a port> -> "Allowed Address Pairs" are not visible. When accessing the same panel in context of a project where the user has the admin role, the "Add" and "Delete" button is visible and functional. This patch fixes the above issue by updating the policy_target. Conflicts: openstack_dashboard/dashboards/admin/networks/ports/tests.py openstack_dashboard/dashboards/project/networks/ports/tests.py Change-Id: Ia7db6c2881c72580a156eb97b11bb51f295cfbce Closes-Bug: #1794421 (cherry picked from commit 87b57dfe7113da09715d5613ab9c91c15a75c189)
* | Allow creating ICMPV6 rulesRadomir Dopieralski2019-09-271-0/+31
|/ | | | | | | | | | | | | | | | Right now, even if we specify a ::/0 (or other IPv6) CIDR in an ICMP rule, Horizon sets 'icmp' as the ip_protocol of that rule but neutron expects 'ipv6-icmp' which is the right ip_protocol for ICMPv6. This results in that rule never matching anything. This change makes Horizon set the ip_protocol to ipv6-icmp when the CIDR is an IPv6 one, and icmp when it's IPv4. Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I1f68e1e5a3e073e38ac258de5ed9c43f8acb04e9 Closes-Bug: #1652619 (cherry picked from commit d5dcf1be93d9bb26bda7b375e41f03dd297888bb) (cherry picked from commit 7a5ed4b688c7f69ce63ef600611947e08e14bcd0)
* Fix image description fieldVladislav Kuzmin2019-07-083-2/+8
| | | | | | | | | | Nothing changed when edit image description on Angularized panel. This patch fixes it. Change-Id: I29fb643bfa9b648ad24fcb9888c658a5a52e4bcc Closes-Bug: #1779879 Closes-Bug: #1777834 (cherry picked from commit 08e0f38c843816660e2b2930c7c6ee5c0435b4a3)
* Merge "Complete angular translation extract pattern" into stable/queensZuul2019-05-272-3/+21
|\
| * Complete angular translation extract patternfrancotseng2019-05-122-3/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | Currently AngularGettextHTMLParser parses translations of form {$ 'content' | translate $}. However, there is another form in projects' html files: {$ ::'content' | translate $}. This commit fine-tunes the filter_regex and related handle_xxx functions to extract both forms of translations. Closes-Bug: #1824644 Change-Id: I7129a13d046b699328b77267ae4936d31af8144c (cherry picked from commit 5de40b3f397f812d5236a274b22515b18118015c)
* | OpenDev Migration Patch13.0.2OpenDev Sysadmins2019-04-192-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
* | Not implicitly set vol_device_name to vdaEric Desrochers2019-04-012-19/+0
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using a scsi decorated image with: hw_disk_bus='scsi' hw_scsi_model='virtio-scsi' This solve the case where an instance is launched with 'image' selected as boot source with a new volume. This will result in /dev/vda instead of /dev/sda as it should. Not specifying device name in setFinalSpecBootImageToVolume() leaves the decision to nova to determine it. Example: ------- VM boot volume without scsi meta data decoration: Attached To 0a0cd660-7ce3-4033-9983-2e1099edc5f0 on /dev/vda VM boot volume with scsi meta data decoration: Attached To 91f50dbc-8bdf-4293-84ea-fc5df27b5ee4 on /dev/sda -------- Note: This commit doesn't address cases for where instances are launched using existing volume and snapshot, this will involve more work to migrate the code from BDMv1 to BDMv2. Closes-Bug #1560965 Change-Id: I9d114c2c2e6736a8f1a8092afa568f930b656f09 (cherry picked from commit 79a4c3bd1aac1473f0d524d98c4cb96475cde498)
* Imported Translations from ZanataOpenStack Proposal Bot2019-03-292-6/+18
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I922e35dc6524e71bc0036d4d042e30fa16deb001
* network topology: handle port AZ correctlyAkihiro Motoki2019-03-221-2/+3
| | | | | | | | | | | | | | | | | Previously d3 version of the network topology view handles ports with device_owner 'compute:nova' and 'compute:None' specially. This leads to the situtaion that neutron ports with non-default AZ are not shown properly. There is no reason to handle neutron ports with the default AZ differently. What we would like to do is just to classify neutron ports attached to nova servers. This commit changes the logic to check device_owner of ports have a prefix 'compute:'. Note that we also need to check if device_owner is a string before checking the prefix. Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d Closes-Bug: #1820260 (cherry picked from commit ffbe0e2f2f96556f4476ea3873af1bc628c879ca)
* Merge "Don't use check_for_language in the user settings form" into ↵Zuul2019-03-111-3/+2
|\ | | | | | | stable/queens
| * Don't use check_for_language in the user settings formRadomir Dopieralski2019-03-071-3/+2
| | | | | | | | | | | | | | | | That function is buggy and can't handle the Chinese language codes. Closes-Bug: #1818639 Change-Id: I6ea03949f3ad6db82f5965de3fa028a84edf6cf3 (cherry picked from commit 6372a689e20252e4a18a59a6ded8841bfa5ed004)
* | Use correct cinder API version for tenant_absolute_limitsAkihiro Motoki2019-03-063-4/+23
|/ | | | | | | | | | | | | | To verify resource usages when updating project quotas, project_id query parameter needs to be supported in tenant_absolute_limits in the cinder API. This is supported in 3.39 or later in the cinder API. API vesions shipped with released versions (pike, queens and rocky) are selected as verified versions. Change-Id: If5fc190988cf173387da2b66be23db9134310692 Closes-Bug: #1810309 (cherry picked from commit If5fc190988cf173387da2b66be23db9134310692)
* Imported Translations from ZanataOpenStack Proposal Bot2019-03-011-14/+15
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I176ec7706a04201b0ab9ac4a1b8e239a7fd8b876
* Consistency Group Snapshots detail url is wrongjmoffitt2019-02-031-1/+2
| | | | | | | | | | | | | | | | | | | | The link in the consistency group table for "detail" is a mismatch for the corresponding value in the urls.py file, causing cg snapshots clicks to not load details for the user. This bug was introduced in https://review.openstack.org/#/c/429506 where the link in tables.py was changed from: "horizon:project:volumes:cg_snapshots:cg_snapshot_detail" to "horizon:project:cg_snapshots:detail" the removal of the volumes section of the link was correct for that change, but changing "cg_snapshot_detail" to "detail" broke the details link Change-Id: I7ad8673bad353a234596df16c8e64eec93733934 Closes-Bug: #1813990 (cherry picked from commit 468184bd9754f41c072ee4afc54ca6f9a0de9af5)
* Add Fix django.contrib.auth.middleware monkey patching for APITestCaseIvan Kolodyazhny2019-01-081-0/+1
| | | | | | | | | | | | | | | | | | This patch rollbacks changes in APITestCase introduced in the 0d163613265e036818fe567793a4fc88fe140d4a commit to unblock Horizon plugins gates. Conflicts: openstack_dashboard/test/helpers.py Note(elod.illes): the above mentioned change in APITestCase was backported to queens, so this rollback should be backported, too. Change-Id: I6b2be31568e4aa4273990f9cfa76ca139620c84b Closes-bug: #1806053 Closes-bug: #1805240 (cherry picked from commit de69edd0402146d76c65cec6cc7879c71259fbbf) (cherry picked from commit 85fef71c0dfff3b7f816add638ad2d916a2ffe38)
* Merge "Restores deletion in flat network topology" into stable/queensZuul2019-01-051-3/+3
|\
| * Restores deletion in flat network topologymareklycka2019-01-021-3/+3
| | | | | | | | | | | | | | | | - Removes an inappropriate condition for the device deletion button Change-Id: I0a4c7dd5782524a875bf208d4ea63ac6df4a62b4 Closes-Bug: 1781911 (cherry picked from commit a42a56f495568de4d2136530129825f4e27377b1)
* | Fix images minimum ram and disk default valuesYves-Gwenael Bourhis2018-12-211-2/+2
|/ | | | | | | | | | | When uploading an image, if we do not set a minimum ram and disk size we try to send "None" to glance. We should instead send "0" and glance will calculate the size from the provided image. Change-Id: Ia1aeabcdcf021943ebb7a4e35939c383ac820b19 Closes-Bug: #1809121 (cherry picked from commit 65b21e7f9de7f5a465dd4c5d921ac476d8e1500a)
* Merge "Fix django.contrib.auth.middleware monkey patching" into stable/queensZuul2018-11-238-9/+25
|\
| * Fix django.contrib.auth.middleware monkey patchingMathieu Gagné2018-11-208-9/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "request" attribute is not available in openstack_auth.backend.KeystoneBackend.get_user when session data is restored and it's the first request to happen after a server restart. As stated by the function document, the "request" attribute needs to be monkey-patched by openstack_auth.utils.patch_middleware_get_user for this function to work properly. This should happen in openstack_auth.urls at import time. But there is nowhere in Horizon where this module is imported at startup. It's only introspected by openstack_dashboard.urls due to AUTHENTICATION_URLS setting. Without this monkey-patching, the whole authentication mechanism falls back to "AnonymousUser" and you will get redirected to the login page due to horizon.exceptions.NotAuthenticated being raised by horizon.decorators.require_auth as request.user.is_authenticated will be False. But if a user requests a page under auth/, it will have the side-effect of monkey-patching django.contrib.auth.middleware as expected. This means that once this request is completed, all following requests to pages other than the ones under auth/ will have there sessions properly restored and you will be properly authenticated. Therefore this change introduces a dummy middleware which sole purpose is to perform this monkey-patching as early as possible. There is also some cleanup to get rid of the previous attempts at monkeypatching. Closes-bug: #1764622 [backport specific notice] Queens horizon supports Django 1.8 and 1.11. The key point is Django 2.0 is not supported. Django 2.0 dropped the legacy Django middleware interface and the new interface is not supported in Django 1.8. Thus, this backport changes OpenstackAuthMonkeyPatchMiddleware in openstack_auth/middlware.py to use the legacy middleware interface. Conflicts: openstack_dashboard/settings.py openstack_dashboard/test/helpers.py Change-Id: Ib9912090a87b716e7f5710f6f360b0df168ec2e3 (cherry picked from commit 0d163613265e036818fe567793a4fc88fe140d4a) (cherry picked from commit 8851866aad5b3826f0a3d569405707bffa593c80)
* | Imported Translations from ZanataOpenStack Proposal Bot2018-11-201-5/+5
|/ | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I0f2e0df82a81ec9e8fc345c1c33fdc815498790e
* Imported Translations from ZanataOpenStack Proposal Bot2018-11-081-4/+8
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I15c0be4bac815a3353d36ecddbb8c2114aa59ebb
* Fix documents in doc/source/installardentpark2018-10-213-8/+8
| | | | | | | * Fix release version name(latest->queens) * Fix list number(trivial) Change-Id: I72fc09451b44c9cb18b5eb1f72007242197ce36e
* Add enabled check in Backups panelEdward Hope-Morley2018-09-281-0/+6
| | | | | | | | | If enable_backup is False in OPENSTACK_CINDER_FEATURES then we should not display the backups panel. Change-Id: I276eebf0f11406bf354f5d8bbecef7b244d6d340 Closes-Bug: #1778771 (cherry picked from commit 6c2225bab8b007023e031d829bc72e8e50e6f1df)
* Imported Translations from ZanataOpenStack Proposal Bot2018-09-131-0/+116
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I82ec39c41f52d098a52e413c4f8d41c2c60673bf
* Imported Translations from ZanataOpenStack Proposal Bot2018-09-071-4/+5
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I7e00099dd5fed372bde770c424ee776fa1da9b85
* Imported Translations from ZanataOpenStack Proposal Bot2018-08-281-3/+8
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I2f9883c0e376c677815691652ca646fb492ad0ac
* import zuul job settings from project-configNguyen Hai2018-08-211-0/+9
| | | | | | | | | | | | | | | | | | | | This is a mechanically generated patch to complete step 1 of moving the zuul job settings out of project-config and into each project repository. Because there will be a separate patch on each branch, the branch specifiers for branch-specific jobs have been removed. Because this patch is generated by a script, there may be some cosmetic changes to the layout of the YAML file(s) as the contents are normalized. See the python3-first goal document for details: https://governance.openstack.org/tc/goals/stein/python3-first.html Change-Id: I5d2ade7b7b4a3ce2250e893b941ad81746c00299 Story: #2002586 Task: #24299
* Imported Translations from ZanataOpenStack Proposal Bot2018-08-092-8/+14
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I316b8a77d9168bd41b02d4dbcfd3e5a7e41e2d97
* Imported Translations from ZanataOpenStack Proposal Bot2018-06-203-6/+17
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: I7c9a77a91a53a1130423937abc1f9d45a48361d2
* Merge "Add reserved status key word to horizon" into stable/queensZuul2018-06-182-1/+3
|\
| * Add reserved status key word to horizonLarry GUO2018-06-052-1/+3
| | | | | | | | | | | | | | | | | | | | | | Horizon don't have related change which align with the change in https://review.openstack.org/#/c/330285. With this fix, horizon can work as expected Change-Id: I5940c662a0bec2beaf4863e07f7244311ba51212 Closes-Bug: #1770326 Signed-off-by: GUO Larry <guo1017138@163.com> (cherry picked from commit 4776428cb69c57408745f75bd5c24228e8bdea44)
* | Sort image list by name when launch instanceFeilong Wang2018-06-011-1/+2
|/ | | | | | | | | Just like the flavor sort issue, this is another regression issue when we shift from the legacy launch instance wizard. By default, the image list should be ordered by name. Change-Id: Id619ad531f7e91326694ee90c112d6a7db0d14ad (cherry picked from commit 71c488042958648ba51db96d26be630df9bb9ca6)
* Update RHEL/CentOS horizon install instructionAkihiro Motoki2018-05-301-0/+5
| | | | | | | | | | openstack-dashboard.conf in openstack-dashboard package for RHEL/CentOS does not contain WSGIApplicationGroup configuration which is required to make the dashboard work correctly. Change-Id: Ic62fa29015ec153eada9d5e1ba5c06dab3a5eeca Closes-Bug: #1741354 (cherry picked from commit a180bafb75cd7f2b6c1f1331d5e217229414a04b)
* Imported Translations from ZanataOpenStack Proposal Bot2018-05-231-5/+7
| | | | | | | For more information about this automatic import see: https://docs.openstack.org/i18n/latest/reviewing-translation-import.html Change-Id: Ib7325b6d68921ed6ade53055e6e45be87d8add10
View Lorry Controller Status