summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorJames E. Blair <jeblair@openstack.org>2014-07-08 09:39:03 -0700
committerJames E. Blair <jeblair@openstack.org>2014-07-08 09:50:14 -0700
commit5b302877fc3c6f34d2682770513a5166d8ac9de4 (patch)
tree42d1efd83a767681cacda8e46dd542834a2ea1dd /tools
parent82bf9ee0610c39ae35e7926e6520a8e21db92c00 (diff)
downloadhorizon-5b302877fc3c6f34d2682770513a5166d8ac9de4.tar.gz
Remove requirements style check
This is incorrect and should never have been added. The order of lines in requirements files affects the pip dependency resolver. Therefore, while it's nice to add new packages in alphabetical order, it must not be required. Move pbr to the top of the list as it should always be installed first. Move hacking to the top of the test-requires list. Change-Id: I81f7e75b77baccd12d9660dc009f30f2f2c891bc
Diffstat (limited to 'tools')
-rwxr-xr-xtools/requirements_style_check.sh32
1 files changed, 0 insertions, 32 deletions
diff --git a/tools/requirements_style_check.sh b/tools/requirements_style_check.sh
deleted file mode 100755
index ccbff3bdd..000000000
--- a/tools/requirements_style_check.sh
+++ /dev/null
@@ -1,32 +0,0 @@
-#!/bin/bash
-#
-# Enforce the requirement that dependencies are listed in the input
-# files in alphabetical order.
-
-# FIXME(dhellmann): This doesn't deal with URL requirements very
-# well. We should probably sort those on the egg-name, rather than the
-# full line.
-
-function check_file() {
- typeset f=$1
-
- # We don't care about comment lines.
- grep -v '^#' $f > ${f}.unsorted
- sort -i -f ${f}.unsorted > ${f}.sorted
- diff -c ${f}.unsorted ${f}.sorted
- rc=$?
- rm -f ${f}.sorted ${f}.unsorted
- return $rc
-}
-
-exit_code=0
-for filename in $@
-do
- check_file $filename
- if [ $? -ne 0 ]
- then
- echo "Please list requirements in $filename in alphabetical order" 1>&2
- exit_code=1
- fi
-done
-exit $exit_code