diff options
author | Diana Whitten <hurgleburgler@gmail.com> | 2015-11-13 13:42:45 -0700 |
---|---|---|
committer | Diana Whitten <hurgleburgler@gmail.com> | 2015-12-18 12:28:25 -0700 |
commit | f5f371655e6b406a2cb48ca1a9373ea894519bbc (patch) | |
tree | 79a9e43a06ff28dfa507bfd2e867761eaed36c1b /horizon/templatetags/horizon.py | |
parent | 98cb37d7cee56ab61b5ec1f47dbfdcd89a5daf84 (diff) | |
download | horizon-f5f371655e6b406a2cb48ca1a9373ea894519bbc.tar.gz |
Barcharts now inherit from a Bootstrap Theme
Barcharts were using a complex D3 mechanism to draw very very simple
markup that can be achieved using a simple Bootstrap Stacked Progress
Bar. A templatetag was added to aid in markup reuse.
Also, a 'minifyspace' template helper was also added that enables us
to make templates that have excessive attributes to be more readable,
while not affecting the rendered HTML on the page.
By moving the logic to simple markup, the rendering of the barcharts
are now immediate on the page, instead of requiring Horizon Init
functions to run and draw. This immediate render removes the first
animation on the Quota bars, but it retains animations driven by user
interaction with the forms.
It was hoped that horizon.d3barchart.js could be completely removed,
but it is currently being used by horizon.d3linechart.js. This will
be addressed soon, but was outside of the scope of this patch.
Much of the markup on the Quota pages was cleaned up and made simpler
to use existing style as well as replacing improper usage of <strong>
Summary of Improvements:
* Immediate Render time for Bar Charts
* Bar Charts now Inherit from theme, and use progress bar styles
* 'minifyspace' was added to increase readability to templates
* bs_progress_bar templatetag was added to facilitate code reuse
* Markup for Quota Bar pages refactored
Partially-Implements: blueprint horizon-theme-css-reorg
Partially-Implements: blueprint bootstrap-html-standards
Change-Id: I16a1e3955d3a4fded0f2ea6a87f5e7c2f630185d
Diffstat (limited to 'horizon/templatetags/horizon.py')
-rw-r--r-- | horizon/templatetags/horizon.py | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/horizon/templatetags/horizon.py b/horizon/templatetags/horizon.py index bca67bd45..d2d99b1c3 100644 --- a/horizon/templatetags/horizon.py +++ b/horizon/templatetags/horizon.py @@ -27,6 +27,7 @@ from django.utils.translation import ugettext_lazy as _ from horizon.base import Horizon # noqa from horizon import conf + register = template.Library() @@ -214,9 +215,7 @@ def datepicker_locale(): def minifyspace(parser, token): """Removes whitespace including tab and newline characters. Do not use this if you are using a <pre> tag - Example usage:: - {% minifyspace %} <p> <a title="foo" @@ -225,9 +224,7 @@ def minifyspace(parser, token): </a> </p> {% endminifyspace %} - This example would return this HTML:: - <p><a title="foo" href="foo/">Foo</a></p> """ nodelist = parser.parse(('endminifyspace',)) |