diff options
| author | Jenkins <jenkins@review.openstack.org> | 2016-11-01 18:27:08 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2016-11-01 18:27:08 +0000 |
| commit | 808c90f1d6ad111d1f0d7676d87c8725b50da78a (patch) | |
| tree | 25630b8a3dd2daa33a20d27391620acf09222c43 | |
| parent | 4e144bb8426746a8c32f671dd36bbf94e9a61daa (diff) | |
| parent | cb7f7bca5ebfdd6d750aa69f8413801b0ecc0906 (diff) | |
| download | glance_store-808c90f1d6ad111d1f0d7676d87c8725b50da78a.tar.gz | |
Merge "Always return a sorted list of drivers for configs" into stable/newton
| -rw-r--r-- | glance_store/backend.py | 7 | ||||
| -rw-r--r-- | releasenotes/notes/sorted-drivers-for-configs-a905f07d3bf9c973.yaml | 16 |
2 files changed, 22 insertions, 1 deletions
diff --git a/glance_store/backend.py b/glance_store/backend.py index ba9ac64..8a2505e 100644 --- a/glance_store/backend.py +++ b/glance_store/backend.py @@ -132,7 +132,12 @@ def _list_opts(): driver_opts = [] mgr = extension.ExtensionManager('glance_store.drivers') # NOTE(zhiyan): Handle available drivers entry_points provided - drivers = [ext.name for ext in mgr] + # NOTE(nikhil): Return a sorted list of drivers so that the oslo config + # generator can use that order to keep generating configuration file in a + # consistent manner. If this order is not preserved, in some cases the + # downstream packagers may see a long diff of the changes though not + # relevant as only order has changed. See some more details at bug 1619487. + drivers = sorted([ext.name for ext in mgr]) handled_drivers = [] # Used to handle backwards-compatible entries for store_entry in drivers: driver_cls = _load_store(None, store_entry, False) diff --git a/releasenotes/notes/sorted-drivers-for-configs-a905f07d3bf9c973.yaml b/releasenotes/notes/sorted-drivers-for-configs-a905f07d3bf9c973.yaml new file mode 100644 index 0000000..a50630f --- /dev/null +++ b/releasenotes/notes/sorted-drivers-for-configs-a905f07d3bf9c973.yaml @@ -0,0 +1,16 @@ +--- +prelude: > + Return list of store drivers in sorted order for + generating configs. More info in ``Upgrade Notes`` + and ``Bug Fixes`` section. +upgrade: + - This version of glance_store will result in Glance + generating the configs in a sorted (deterministic) + order. So, preferably store releases on or after this + should be used for generating any new configs if the + mismatched ordering of the configs results in an issue + in your environment. +fixes: + - Bug 1619487 is fixed which was causing random order of + the generation of configs in Glance. See ``upgrade`` + section for more details. |