Make the formatters a private part of the command

python-neutronclient was modifying the formatters set,
but those objects were always meant to be private.
Rename "formatters" to "_formatters" to make that clear.

Change-Id: I993c948384201ef64c6fd0c957fa854bc4eed9d6

2 files changed, 5 insertions, 11 deletions

diff --git a/cliff/display.py b/cliff/display.py
index edea1f3..989b886 100644
--- a/cliff/display.py
+++ b/cliff/display.py
@@ -18,7 +18,7 @@ class DisplayCommandBase(Command):
 
     def __init__(self, app, app_args):
         super(DisplayCommandBase, self).__init__(app, app_args)
-        self.formatters = self._load_formatter_plugins()
+        self._formatters = self._load_formatter_plugins()
 
     @abc.abstractproperty
     def formatter_namespace(self):
@@ -41,7 +41,7 @@ class DisplayCommandBase(Command):
             title='output formatters',
             description='output formatter options',
         )
-        formatter_choices = sorted(self.formatters.names())
+        formatter_choices = sorted(self._formatters.names())
         formatter_default = self.formatter_default
         if formatter_default not in formatter_choices:
             formatter_default = formatter_choices[0]
@@ -61,7 +61,7 @@ class DisplayCommandBase(Command):
             metavar='COLUMN',
             help='specify the column(s) to include, can be repeated',
         )
-        for formatter in self.formatters:
+        for formatter in self._formatters:
             formatter.obj.add_argument_group(parser)
         return parser
 
@@ -76,7 +76,7 @@ class DisplayCommandBase(Command):
         """
 
     def run(self, parsed_args):
-        self.formatter = self.formatters[parsed_args.formatter].obj
+        self.formatter = self._formatters[parsed_args.formatter].obj
         column_names, data = self.take_action(parsed_args)
         self.produce_output(parsed_args, column_names, data)
         return 0
diff --git a/cliff/tests/test_lister.py b/cliff/tests/test_lister.py
index 7d1876f..d3b27b5 100644
--- a/cliff/tests/test_lister.py
+++ b/cliff/tests/test_lister.py
@@ -32,12 +32,6 @@ class ExerciseLister(Lister):
         )
 
 
-#    def run(self, parsed_args):
-#        self.formatter = self.formatters[parsed_args.formatter]
-#        column_names, data = self.take_action(parsed_args)
-#        self.produce_output(parsed_args, column_names, data)
-#        return 0
-
 def test_formatter_args():
     app = mock.Mock()
     test_lister = ExerciseLister(app, [])
@@ -47,7 +41,7 @@ def test_formatter_args():
     parsed_args.formatter = 'test'
 
     test_lister.run(parsed_args)
-    f = test_lister.formatters['test']
+    f = test_lister._formatters['test']
     assert len(f.args) == 1
     args = f.args[0]
     assert args[0] == list(parsed_args.columns)