summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeigo Noha <knoha@redhat.com>2020-07-08 15:54:49 +0900
committerKeigo Noha <knoha@redhat.com>2020-11-16 07:03:27 +0000
commitd56bb6d6f93b0a069663e78c0d72adcb297457cf (patch)
treeecab9f79f7fc1318a826da069ce8bdf68eaa3fe7
parent4f8219af5eb16b3ed6703d6e52c51034d5d4293b (diff)
downloadcinder-d56bb6d6f93b0a069663e78c0d72adcb297457cf.tar.gz
Change default glance_num_retries to 3
Previously, the default value of glance_num_retries is 0. It means that the request to glance is issued only one time. However, other components' client retries the request when it fails. To reduce an unnecessary exception and failure, we should increase the default value to 3. Change-Id: Iff8162c732fb9dc0080e8810b4a5bcaa3ff7e6ca (cherry picked from commit da5a27f7b38708ea7e4e8877a1f247833224a518) (cherry picked from commit 45f2e24cc796dfd999520baf73c020ef4f6f791d)
-rw-r--r--cinder/common/config.py2
-rw-r--r--releasenotes/notes/increase_glance_num_retries-66b455a0729c4535.yaml9
2 files changed, 10 insertions, 1 deletions
diff --git a/cinder/common/config.py b/cinder/common/config.py
index 19418a50a..e4304fa91 100644
--- a/cinder/common/config.py
+++ b/cinder/common/config.py
@@ -174,7 +174,7 @@ image_opts = [
'is not specified it defaults to http.'),
cfg.IntOpt('glance_num_retries',
min=0,
- default=0,
+ default=3,
help='Number retries when downloading an image from glance'),
cfg.BoolOpt('glance_api_insecure',
default=False,
diff --git a/releasenotes/notes/increase_glance_num_retries-66b455a0729c4535.yaml b/releasenotes/notes/increase_glance_num_retries-66b455a0729c4535.yaml
new file mode 100644
index 000000000..14fdadb60
--- /dev/null
+++ b/releasenotes/notes/increase_glance_num_retries-66b455a0729c4535.yaml
@@ -0,0 +1,9 @@
+---
+upgrade:
+ - |
+ The default value of the configuration option, ``glance_num_retries``,
+ has been changed to 3 in this release. Its former value was 0.
+ The option controls how many times to retry a Glance API call
+ in response to a HTTP connection failure, timeout or ServiceUnavailable status.
+ By this change, Cinder can be more resilient to temporary failure and continue
+ the request if a retry succeeds.