diff options
| author | Dina Belova <dbelova@mirantis.com> | 2014-04-29 18:24:25 +0400 |
|---|---|---|
| committer | Dina Belova <dbelova@mirantis.com> | 2014-05-22 15:20:36 +0400 |
| commit | b9d97599e4e77738ad2b41960fc6d75029c4f50e (patch) | |
| tree | e751b75af3546c63bd18888d7c98fad375df79e2 /ceilometer/objectstore/swift.py | |
| parent | 21774ae8cb5b123b7714ac47bb30c697dc9ceb8c (diff) | |
| download | ceilometer-b9d97599e4e77738ad2b41960fc6d75029c4f50e.tar.gz | |
Use None instead of mutables in method params defaults
Mutables in the method params defaults might cause errors and
that's why it's anti-pattern in most of the cases and should be
removed.
Change-Id: Ifb59a16c927a4bc285f7b70fac87f719054020f4
Diffstat (limited to 'ceilometer/objectstore/swift.py')
| -rw-r--r-- | ceilometer/objectstore/swift.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/ceilometer/objectstore/swift.py b/ceilometer/objectstore/swift.py index abfc75c3..99a2b193 100644 --- a/ceilometer/objectstore/swift.py +++ b/ceilometer/objectstore/swift.py @@ -88,7 +88,7 @@ class ObjectsPollster(_Base): """Iterate over all accounts, using keystone. """ - def get_samples(self, manager, cache, resources=[]): + def get_samples(self, manager, cache, resources=None): for tenant, account in self._iter_accounts(manager.keystone, cache): yield sample.Sample( name='storage.objects', @@ -107,7 +107,7 @@ class ObjectsSizePollster(_Base): """Iterate over all accounts, using keystone. """ - def get_samples(self, manager, cache, resources=[]): + def get_samples(self, manager, cache, resources=None): for tenant, account in self._iter_accounts(manager.keystone, cache): yield sample.Sample( name='storage.objects.size', @@ -126,7 +126,7 @@ class ObjectsContainersPollster(_Base): """Iterate over all accounts, using keystone. """ - def get_samples(self, manager, cache, resources=[]): + def get_samples(self, manager, cache, resources=None): for tenant, account in self._iter_accounts(manager.keystone, cache): yield sample.Sample( name='storage.objects.containers', @@ -147,7 +147,7 @@ class ContainersObjectsPollster(_Base): METHOD = 'get' - def get_samples(self, manager, cache, resources=[]): + def get_samples(self, manager, cache, resources=None): for project, account in self._iter_accounts(manager.keystone, cache): containers_info = account[1] for container in containers_info: @@ -170,7 +170,7 @@ class ContainersSizePollster(_Base): METHOD = 'get' - def get_samples(self, manager, cache, resources=[]): + def get_samples(self, manager, cache, resources=None): for project, account in self._iter_accounts(manager.keystone, cache): containers_info = account[1] for container in containers_info: |