summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Caswell <matt@openssl.org>2015-03-12 12:54:44 +0000
committerMatt Caswell <matt@openssl.org>2015-03-17 13:49:31 +0000
commitf4b8760056ebc6d22666652fc34dc9ad8577856c (patch)
tree1a043e753e149c0a05d90c9375bf1509b19b7b2f
parentd3554bff69d97b15fef063bdb0176a0b68021325 (diff)
downloadopenssl-new-f4b8760056ebc6d22666652fc34dc9ad8577856c.tar.gz
Fix memset call in stack.c
The function sk_zero is supposed to zero the elements held within a stack. It uses memset to do this. However it calculates the size of each element as being sizeof(char **) instead of sizeof(char *). This probably doesn't make much practical difference in most cases, but isn't a portable assumption. Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 7132ac830fa08d9a936e011d7c541b0c52115b33)
-rw-r--r--crypto/stack/stack.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/stack/stack.c b/crypto/stack/stack.c
index fbe9d6e756..331f907190 100644
--- a/crypto/stack/stack.c
+++ b/crypto/stack/stack.c
@@ -278,7 +278,7 @@ void sk_zero(_STACK *st)
return;
if (st->num <= 0)
return;
- memset((char *)st->data, 0, sizeof(st->data) * st->num);
+ memset((char *)st->data, 0, sizeof(*st->data) * st->num);
st->num = 0;
}