summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGabriel Scherer <gabriel.scherer@gmail.com>2022-09-06 14:43:24 +0200
committerGabriel Scherer <gabriel.scherer@gmail.com>2022-12-01 22:17:21 +0100
commitd9799d3b5e78ba8f8ba63212edbecc3fb6f45e30 (patch)
treeacbd58bf99897f7edb2a2b1007eaf653412a4344
parentfec3b2375d27a33ed0b0b248aafe51bb3db92271 (diff)
downloadocaml-d9799d3b5e78ba8f8ba63212edbecc3fb6f45e30.tar.gz
test comments
-rw-r--r--testsuite/tests/tool-toplevel/show.ml15
1 files changed, 15 insertions, 0 deletions
diff --git a/testsuite/tests/tool-toplevel/show.ml b/testsuite/tests/tool-toplevel/show.ml
index cff51c1c2b..655d0bfe6b 100644
--- a/testsuite/tests/tool-toplevel/show.ml
+++ b/testsuite/tests/tool-toplevel/show.ml
@@ -135,6 +135,21 @@ module type OrderedType = Set.OrderedType
module type OrderedType = sig type t val compare : t -> t -> int end
|}];;
+(* extra tests after #11533
+
+ The regression in #11533 would only show up when showing values defined
+ outside the current module. Those new tests below test modules and module
+ types from the standard library. To minimize test churn / promotion,
+ we are looking for some that will change as little as possible
+ in the future.
+
+ - For module type it's easy: OrderedType is fixed in stone as
+ changing it would break all code using Set.Make.
+
+ - For modules we use Stdlib.Unit, one of the stdlib modules
+ that is less likely to change very often (there are only
+ so many features you can add to 'unit').
+*)
module U = Stdlib.Unit;;
module type OT = Set.OrderedType;;
[%%expect {|