diff options
| author | julien.pierre.boogz%sun.com <devnull@localhost> | 2009-05-13 22:47:28 +0000 |
|---|---|---|
| committer | julien.pierre.boogz%sun.com <devnull@localhost> | 2009-05-13 22:47:28 +0000 |
| commit | 1bec9e9707902c6dfe15156e90d821ac2c8873a7 (patch) | |
| tree | 483879ab87cf7c2d8fc9ee5889d6eddb9608e03b | |
| parent | e5d8f37ed0bc4f3795579d999b7ba1ef93501b1c (diff) | |
| download | nss-hg-1bec9e9707902c6dfe15156e90d821ac2c8873a7.tar.gz | |
Fix for bug 492385 . Stop crash freeing named CRL entry on shudown. r=nelson
| -rw-r--r-- | security/nss/lib/certdb/crl.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/security/nss/lib/certdb/crl.c b/security/nss/lib/certdb/crl.c index 04927aa31..1cf407098 100644 --- a/security/nss/lib/certdb/crl.c +++ b/security/nss/lib/certdb/crl.c @@ -3136,6 +3136,7 @@ static SECStatus addCRLToCache(CERTCertDBHandle* dbhandle, SECItem* crl, rv = SECFailure; /* no need to keep unused CRL around */ SECITEM_ZfreeItem(entry->crl, PR_TRUE); + entry->crl = NULL; } return rv; } @@ -3206,6 +3207,10 @@ SECStatus cert_CacheCRLByGeneralName(CERTCertDBHandle* dbhandle, SECItem* crl, if (!removed) { rv = SECFailure; + /* leak old entry since we couldn't remove it from the hash table */ + } + else + { rv2 = NamedCRLCacheEntry_Destroy(oldEntry); PORT_Assert(SECSuccess == rv2); } @@ -3249,7 +3254,11 @@ SECStatus cert_CacheCRLByGeneralName(CERTCertDBHandle* dbhandle, SECItem* crl, PORT_Assert(removed); if (!removed) { + /* leak old entry since we couldn't remove it from the hash table */ rv = SECFailure; + } + else + { rv2 = NamedCRLCacheEntry_Destroy(oldEntry); PORT_Assert(SECSuccess == rv2); } |