diff options
author | Juanjo Diaz <juanjo.diazmo@gmail.com> | 2018-05-24 00:27:09 +0300 |
---|---|---|
committer | Juanjo Diaz <juanjo.diazmo@gmail.com> | 2018-05-24 00:27:09 +0300 |
commit | 2b5f94fa6abbdfab4213f91ef04207298f35d2b7 (patch) | |
tree | 6fe320e4dcfe903711650e94530f3f18586e71b8 /tests/test.keyboard.js | |
parent | cdb860ad84957c54747f925cf0d081ac8b53e03a (diff) | |
download | novnc-2b5f94fa6abbdfab4213f91ef04207298f35d2b7.tar.gz |
Prefer const/let over var
Diffstat (limited to 'tests/test.keyboard.js')
-rw-r--r-- | tests/test.keyboard.js | 100 |
1 files changed, 50 insertions, 50 deletions
diff --git a/tests/test.keyboard.js b/tests/test.keyboard.js index 574f88e..3d409fb 100644 --- a/tests/test.keyboard.js +++ b/tests/test.keyboard.js @@ -1,4 +1,4 @@ -var expect = chai.expect; +const expect = chai.expect; import sinon from '../vendor/sinon.js'; @@ -11,8 +11,8 @@ describe('Key Event Handling', function() { // The real KeyboardEvent constructor might not work everywhere we // want to run these tests function keyevent(typeArg, KeyboardEventInit) { - var e = { type: typeArg }; - for (var key in KeyboardEventInit) { + const e = { type: typeArg }; + for (let key in KeyboardEventInit) { e[key] = KeyboardEventInit[key]; } e.stopPropagation = sinon.spy(); @@ -23,7 +23,7 @@ describe('Key Event Handling', function() { describe('Decode Keyboard Events', function() { it('should decode keydown events', function(done) { if (browser.isIE() || browser.isEdge()) this.skip(); - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('KeyA'); @@ -34,8 +34,8 @@ describe('Key Event Handling', function() { }); it('should decode keyup events', function(done) { if (browser.isIE() || browser.isEdge()) this.skip(); - var calls = 0; - var kbd = new Keyboard(document); + let calls = 0; + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('KeyA'); @@ -50,13 +50,13 @@ describe('Key Event Handling', function() { describe('Legacy keypress Events', function() { it('should wait for keypress when needed', function() { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'KeyA', keyCode: 0x41})); expect(kbd.onkeyevent).to.not.have.been.called; }); it('should decode keypress events', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('KeyA'); @@ -67,14 +67,14 @@ describe('Key Event Handling', function() { kbd._handleKeyPress(keyevent('keypress', {code: 'KeyA', charCode: 0x61})); }); it('should ignore keypress with different code', function() { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'KeyA', keyCode: 0x41})); kbd._handleKeyPress(keyevent('keypress', {code: 'KeyB', charCode: 0x61})); expect(kbd.onkeyevent).to.not.have.been.called; }); it('should handle keypress with missing code', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('KeyA'); @@ -85,7 +85,7 @@ describe('Key Event Handling', function() { kbd._handleKeyPress(keyevent('keypress', {charCode: 0x61})); }); it('should guess key if no keypress and numeric key', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x32); expect(code).to.be.equal('Digit2'); @@ -95,7 +95,7 @@ describe('Key Event Handling', function() { kbd._handleKeyDown(keyevent('keydown', {code: 'Digit2', keyCode: 0x32})); }); it('should guess key if no keypress and alpha key', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('KeyA'); @@ -105,7 +105,7 @@ describe('Key Event Handling', function() { kbd._handleKeyDown(keyevent('keydown', {code: 'KeyA', keyCode: 0x41, shiftKey: false})); }); it('should guess key if no keypress and alpha key (with shift)', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x41); expect(code).to.be.equal('KeyA'); @@ -115,7 +115,7 @@ describe('Key Event Handling', function() { kbd._handleKeyDown(keyevent('keydown', {code: 'KeyA', keyCode: 0x41, shiftKey: true})); }); it('should not guess key if no keypress and unknown key', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0); expect(code).to.be.equal('KeyA'); @@ -131,25 +131,25 @@ describe('Key Event Handling', function() { if (browser.isIE() || browser.isEdge()) this.skip(); }); it('should suppress anything with a valid key', function() { - var kbd = new Keyboard(document, {}); - var evt1 = keyevent('keydown', {code: 'KeyA', key: 'a'}); + const kbd = new Keyboard(document, {}); + const evt1 = keyevent('keydown', {code: 'KeyA', key: 'a'}); kbd._handleKeyDown(evt1); expect(evt1.preventDefault).to.have.been.called; - var evt2 = keyevent('keyup', {code: 'KeyA', key: 'a'}); + const evt2 = keyevent('keyup', {code: 'KeyA', key: 'a'}); kbd._handleKeyUp(evt2); expect(evt2.preventDefault).to.have.been.called; }); it('should not suppress keys without key', function() { - var kbd = new Keyboard(document, {}); - var evt = keyevent('keydown', {code: 'KeyA', keyCode: 0x41}); + const kbd = new Keyboard(document, {}); + const evt = keyevent('keydown', {code: 'KeyA', keyCode: 0x41}); kbd._handleKeyDown(evt); expect(evt.preventDefault).to.not.have.been.called; }); it('should suppress the following keypress event', function() { - var kbd = new Keyboard(document, {}); - var evt1 = keyevent('keydown', {code: 'KeyA', keyCode: 0x41}); + const kbd = new Keyboard(document, {}); + const evt1 = keyevent('keydown', {code: 'KeyA', keyCode: 0x41}); kbd._handleKeyDown(evt1); - var evt2 = keyevent('keypress', {code: 'KeyA', charCode: 0x41}); + const evt2 = keyevent('keypress', {code: 'KeyA', charCode: 0x41}); kbd._handleKeyPress(evt2); expect(evt2.preventDefault).to.have.been.called; }); @@ -159,8 +159,8 @@ describe('Key Event Handling', function() { describe('Fake keyup', function() { it('should fake keyup events for virtual keyboards', function(done) { if (browser.isIE() || browser.isEdge()) this.skip(); - var count = 0; - var kbd = new Keyboard(document); + let count = 0; + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { switch (count++) { case 0: @@ -179,7 +179,7 @@ describe('Key Event Handling', function() { }); describe('iOS', function() { - var origNavigator; + let origNavigator; beforeEach(function () { // window.navigator is a protected read-only property in many // environments, so we need to redefine it whilst running these @@ -206,8 +206,8 @@ describe('Key Event Handling', function() { it('should fake keyup events on iOS', function(done) { if (browser.isIE() || browser.isEdge()) this.skip(); - var count = 0; - var kbd = new Keyboard(document); + let count = 0; + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { switch (count++) { case 0: @@ -232,7 +232,7 @@ describe('Key Event Handling', function() { if (browser.isIE() || browser.isEdge()) this.skip(); }); it('should send release using the same keysym as the press', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('KeyA'); @@ -244,8 +244,8 @@ describe('Key Event Handling', function() { kbd._handleKeyUp(keyevent('keyup', {code: 'KeyA', key: 'b'})); }); it('should send the same keysym for multiple presses', function() { - var count = 0; - var kbd = new Keyboard(document); + let count = 0; + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('KeyA'); @@ -257,7 +257,7 @@ describe('Key Event Handling', function() { expect(count).to.be.equal(2); }); it('should do nothing on keyup events if no keys are down', function() { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyUp(keyevent('keyup', {code: 'KeyA', key: 'a'})); expect(kbd.onkeyevent).to.not.have.been.called; @@ -265,7 +265,7 @@ describe('Key Event Handling', function() { describe('Legacy Events', function() { it('should track keys using keyCode if no code', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('Platform65'); @@ -277,7 +277,7 @@ describe('Key Event Handling', function() { kbd._handleKeyUp(keyevent('keyup', {keyCode: 65, key: 'b'})); }); it('should ignore compositing code', function() { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('Unidentified'); @@ -285,7 +285,7 @@ describe('Key Event Handling', function() { kbd._handleKeyDown(keyevent('keydown', {keyCode: 229, key: 'a'})); }); it('should track keys using keyIdentifier if no code', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0x61); expect(code).to.be.equal('Platform65'); @@ -300,7 +300,7 @@ describe('Key Event Handling', function() { }); describe('Shuffle modifiers on macOS', function() { - var origNavigator; + let origNavigator; beforeEach(function () { // window.navigator is a protected read-only property in many // environments, so we need to redefine it whilst running these @@ -326,8 +326,8 @@ describe('Key Event Handling', function() { }); it('should change Alt to AltGraph', function() { - var count = 0; - var kbd = new Keyboard(document); + let count = 0; + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { switch (count++) { case 0: @@ -345,7 +345,7 @@ describe('Key Event Handling', function() { expect(count).to.be.equal(2); }); it('should change left Super to Alt', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0xFFE9); expect(code).to.be.equal('MetaLeft'); @@ -354,7 +354,7 @@ describe('Key Event Handling', function() { kbd._handleKeyDown(keyevent('keydown', {code: 'MetaLeft', key: 'Meta', location: 1})); }); it('should change right Super to left Super', function(done) { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = function(keysym, code, down) { expect(keysym).to.be.equal(0xFFEB); expect(code).to.be.equal('MetaRight'); @@ -365,7 +365,7 @@ describe('Key Event Handling', function() { }); describe('Escape AltGraph on Windows', function() { - var origNavigator; + let origNavigator; beforeEach(function () { // window.navigator is a protected read-only property in many // environments, so we need to redefine it whilst running these @@ -394,14 +394,14 @@ describe('Key Event Handling', function() { }); it('should supress ControlLeft until it knows if it is AltGr', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlLeft', key: 'Control', location: 1})); expect(kbd.onkeyevent).to.not.have.been.called; }); it('should not trigger on repeating ControlLeft', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlLeft', key: 'Control', location: 1})); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlLeft', key: 'Control', location: 1})); @@ -411,7 +411,7 @@ describe('Key Event Handling', function() { }); it('should not supress ControlRight', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlRight', key: 'Control', location: 2})); expect(kbd.onkeyevent).to.have.been.calledOnce; @@ -419,7 +419,7 @@ describe('Key Event Handling', function() { }); it('should release ControlLeft after 100 ms', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlLeft', key: 'Control', location: 1})); expect(kbd.onkeyevent).to.not.have.been.called; @@ -429,7 +429,7 @@ describe('Key Event Handling', function() { }); it('should release ControlLeft on other key press', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlLeft', key: 'Control', location: 1})); expect(kbd.onkeyevent).to.not.have.been.called; @@ -445,7 +445,7 @@ describe('Key Event Handling', function() { }); it('should release ControlLeft on other key release', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'KeyA', key: 'a'})); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlLeft', key: 'Control', location: 1})); @@ -463,7 +463,7 @@ describe('Key Event Handling', function() { }); it('should generate AltGraph for quick Ctrl+Alt sequence', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlLeft', key: 'Control', location: 1, timeStamp: Date.now()})); this.clock.tick(20); @@ -478,7 +478,7 @@ describe('Key Event Handling', function() { }); it('should generate Ctrl, Alt for slow Ctrl+Alt sequence', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'ControlLeft', key: 'Control', location: 1, timeStamp: Date.now()})); this.clock.tick(60); @@ -494,7 +494,7 @@ describe('Key Event Handling', function() { }); it('should pass through single Alt', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'AltRight', key: 'Alt', location: 2})); expect(kbd.onkeyevent).to.have.been.calledOnce; @@ -502,7 +502,7 @@ describe('Key Event Handling', function() { }); it('should pass through single AltGr', function () { - var kbd = new Keyboard(document); + const kbd = new Keyboard(document); kbd.onkeyevent = sinon.spy(); kbd._handleKeyDown(keyevent('keydown', {code: 'AltRight', key: 'AltGraph', location: 2})); expect(kbd.onkeyevent).to.have.been.calledOnce; |