summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* test: update flaky test definitionsorangemocha-LibuvUpdate-FlakyTestsAlexis Campailla2015-03-102-0/+2
| | | | | | test-fs-watch is flaky on OSX. test-dgram-multicast-multi-process is failing with the libuv update to 1.4, but there's is a pending fix in the libuv repo.
* deps: upgrade npm to 2.7.0Forrest L Norvell2015-03-06291-906/+2102
| | | | | | PR: #9347 PR-URL: https://github.com/joyent/node/pull/9347 Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
* net: allow port 0 in connect()cjihrig2015-03-054-33/+97
| | | | | | | | | | | The added validation allows non-negative numbers and numeric strings. All other values result in a thrown exception. Fixes: https://github.com/joyent/node/issues/9194 PR-URL: https://github.com/joyent/node/pull/9268 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@users.noreply.github.com>
* Merge remote-tracking branch 'upstream/v0.10' into v0.12Julien Gilli2015-03-041-1/+1
|\ | | | | | | | | Conflicts: lib/buffer.js
| * buffer: reword Buffer.concat error messageChris Dickinson2015-03-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | this brings the error messaging in line with other node TypeError messages. fixes joyent/node#7766. PR: #8723 PR-URL: https://github.com/joyent/node/pull/8723 Reviewed-By: James M Snell <jasnell@users.noreply.github.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* | deps: upgrade npm to 2.6.1Forrest L Norvell2015-03-03197-305/+1573
| | | | | | | | | | | | | | | | PR: #9297 PR-URL: https://github.com/joyent/node/pull/9297 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* | tests: fix race in test-http-curl-chunk-problemJulien Gilli2015-03-031-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test setups two event listeners: one on a child process' exit event , another for the same child process' stdandard output's 'data' event. The data even listener writes to a stream, and the exit event listener ends it. Because the exit event can be emitted before the data event, there is a chance that something will be written to the stream after it's ended, and that an error is thrown. This change makes the test end the stream in the listener for the child process' standard output's end event, which is guaranteed to be emitted after the last data event, thus avoiding the race. PR: #9301 PR-URL: https://github.com/joyent/node/pull/9301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@users.noreply.github.com> Reviewed-By: Bert Belder <bertbelder@gmail.com>
* | Merge remote-tracking branch 'upstream/v0.10' into v0.12Julien Gilli2015-02-270-0/+0
|\ \ | |/ | | | | | | | | Conflicts: lib/console.js test/simple/test-console.js
| * console: allow Object.prototype fields as labelsJulien Gilli2015-02-172-15/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a backport of 6c3647c38d73f729ce85633a0440cd939d93dea2 from v0.12 to v0.10. Console.prototype.timeEnd() returns NaN if the timer label corresponds to a property on Object.prototype. In v0.12, this was fixed by using Object.create(null) to construct the _times object However, the version of V8 in the v0.10 branch makes this fix not work as expected. In v0.10, this commit changes the _times object into a array of objects of the form: { label: someLabel, time: staringWallClockTime } someLabel can thus be any string, including any string that represents any Object.prototype field. Fixes #9116. PR: #9215 PR-URL: https://github.com/joyent/node/pull/9215 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* | src: fix builtin modules failing with --use-strictJulien Gilli2015-02-274-21/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, lib/_tls_legacy.js and lib/crypto.js cannot be loaded when --use-strict is passed to node. In addition to that, console.trace throws because it uses arguments.callee. This change fixes these issues and adds a test that makes sure every external built-in module can be loaded with require when --use-strict is enabled. Please note that this change does not fix all issues with built-in modules' code running with --use-strict. It is very likely that some code in the built-in modules still fails when passing this flag. However, fixing all code would require us to enable strict mode by default in all builtins modules, which would certainly break existing applications. Fixes #9187. PR: #9237 PR-URL: https://github.com/joyent/node/pull/9237 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* | test: make destroyed-socket-write2.js more robustMichael Dawson2015-02-271-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | test/simple/test-http-destroyed-socket-write2.js validates that you get an appropriate error when trying to write to a request when the response on the other side has been destroyed. The test uses http.request to get a request and then keeps writing to it until either it hits 128 writes or gets the expected error. Since the writes are asynchronous we see that the writes just end up adding events to the event loop, which then later get processed once the connection supporting the request is fully ready. The test is timing dependent and if takes too long for the connection to be made the limit of 128 writes is exceeded and the test fails. The fact that the test allows a number of writes is probably to allow some delay for the connection to be ready for writing. On AIX, in the default configuration using the loopback interface is slower and the test fails because the delay is such that many more writes can be queued up before the connection takes place. If we use the host ip instead of defaulting to the loopback then the test passes. The test needs to be made more robust to delays. Since each write simply enqueues an additional write to the event queue there is probably no point in doing the second write until the first has completed. This patch schedules the next write when the first one completes and allows the test to pass even if it takes longer for the connection to be ready for writing PR-URL: https://github.com/joyent/node/pull/9270 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | doc: add explanations for querystringRobert Kowalski2015-02-251-1/+5
| | | | | | | | | | | | | | | | - add an article: `decode a non-utf8 string` - explain default and fallback behaviour of `querystring.unescape` PR-URL: https://github.com/joyent/node/pull/9259 Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
* | doc: fix default value of opts.decodeURIComponenth7lin2015-02-251-1/+1
| | | | | | | | | | | | | | | | | | | | In the documentation for querystring.parse, the documentation mentions that the default value for options.decodeURIComponent is the decodeURIComponent function, but it's actually the querystring.unescape function. PR-URL: https://github.com/joyent/node/pull/9259 Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
* | doc: remove broken link to tracing apiRobert Kowalski2015-02-241-1/+0
| | | | | | | | | | | | | | | | closes joyent/node-website#77 PR: #9172 PR-URL: https://github.com/joyent/node/pull/9172 Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
* | deps: backport a02d97e from v8 upstreamAndrei Sedoi2015-02-201-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: Fix --max_old_space_size=4096 integer overflow. BUG=v8:3857 LOG=N Review URL: https://codereview.chromium.org/897543002 Cr-Commit-Position: refs/heads/master@{#26510} PR-URL: https://github.com/joyent/node/pull/9200 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
* | smalloc: extend user APITrevor Norris2015-02-205-7/+137
| | | | | | | | | | | | | | | | | | node::Environment isn't accessible to user APIs, so extend smalloc to also accept v8::Isolate. Fixes: 75adde07 "src: remove `node_isolate` from source" PR-URL: https://github.com/iojs/io.js/pull/905 Reviewed-by: Fedor Indutny <fedor@indutny.com>
* | net: unref timer in parent socketsFedor Indutny2015-02-193-9/+75
| | | | | | | | | | | | | | | | | | | | | | | | `TLSSocket` wraps the original `net.Socket`, but writes/reads to/from `TLSSocket` do not touch the timers of original `net.Socket`. Introduce `socket._parent` property, and iterate through all parents to unref timers and prevent timeout event on original `net.Socket`. Fix: https://github.com/joyent/node/issues/9242 PR-URL: https://github.com/iojs/io.js/pull/891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* | fs: properly handle fd passed to truncate()Bruno Jouhier2015-02-173-4/+48
| | | | | | | | | | | | | | | | | | | | Currently, fs.truncate() silently fails when a file descriptor is passed as the first argument. This commit changes this behavior to properly call fs.ftruncate(). PR-URL: https://github.com/joyent/node/pull/9161 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | src: update AUTHORS after mergeJulien Gilli2015-02-161-0/+4
| |
* | deps: do not add extra newline in log fileJulien Gilli2015-02-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | The commit in v0.10 (431eb172f97434a3b0868a610bc14d8ff7d9efd9) that backported the original change (https://codereview.chromium.org/806143002) did add an extra newline because the logging facilities in v0.10's V8 do not add one. When merging this commit in v0.12, V8's logging facilities now automatically add the newline character, and the debug builds assert if one is already present.
* | deps: add test for V8 version in profiler's logJulien Gilli2015-02-161-0/+15
| | | | | | | | | | | | | | | | | | | | | | 431eb172f97434a3b0868a610bc14d8ff7d9efd9 had integrated the addition of V8's version in V8's profiler log files, without backporting the test that was included in the original change (https://codereview.chromium.org/806143002). This commit backports this test. The newly added test was tested with https://github.com/joyent/node/pull/9208.
* | Merge remote-tracking branch 'upstream/v0.10' into v0.12Julien Gilli2015-02-163-2/+19
|\ \ | |/ | | | | | | Conflicts: deps/v8/src/log-utils.cc
| * url: reslove urls with . and ..Amir Saboury2015-02-092-2/+10
| | | | | | | | | | | | | | | | | | | | '.' and '..' are directory specs and resolving urls with or without the hostname with '.' and '..' should add a trailing slash to the end of the url. Fixes: https://github.com/joyent/node/issues/8992 PR-URL: https://github.com/joyent/node/pull/9010 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
| * deps: log V8 version in profiler log fileBen Noordhuis2015-02-041-0/+9
| | | | | | | | | | | | | | | | | | | | Patch from issue 800293002 authored by ben@strongloop.com Review URL: https://codereview.chromium.org/806143002 PR-URL: https://github.com/joyent/node/pull/9043 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | buffer: fix pool offset adjustmentTrevor Norris2015-02-161-1/+3
| | | | | | | | | | | | | | If the Buffer allocation isn't a slice then there's no need to adjust the pool offset after realloc'ing the space available. Fixes: 6462519 "buffer, doc: misc. fix and cleanup"
* | console: allow Object.prototype fields as labelscjihrig2015-02-132-10/+26
| | | | | | | | | | | | | | | | | | | | Console.prototype.timeEnd() returns NaN if the timer label corresponds to a property on Object.prototype. This commit uses Object.create(null) to construct the _times object. Fixes: https://github.com/joyent/node/issues/9069 PR-URL: https://github.com/joyent/node/pull/9116 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* | module: replace NativeModule.requireHerbert Vojčík2015-02-121-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | The NativeModule system passes NativeModule.require transparently and so is unnecessary to call explicitly. The only one which should have the prefix is the in line 295, where actually implements a big fs-based module system and actually requires a native module. That is left unchanged. PR-URL: https://github.com/joyent/node/pull/9201 Ref: https://github.com/joyent/node/issues/2009 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
* | doc: fix code syntaxDan Dascalescu2015-02-121-1/+1
| | | | | | | | | | | | | | Add a ';' to the end of a function call in documentation. PR-URL: https://github.com/joyent/node/pull/9198 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
* | fs: make F_OK/R_OK/W_OK/X_OK not writableJackson Tian2015-02-112-10/+15
| | | | | | | | | | | | | | | | | | Change the fs.F_OK/R_OK/W_OK/X_OK out of fs.js will lead unexpect exception. Make these properties readonly. PR-URL: https://github.com/joyent/node/pull/9060 [trev.norris@gmail.com test properties are read only] Signed-off-by: Trevor Norris <trev.norris@gmail.com>
* | test: Timeout#unref() does not return instanceJan Schär2015-02-111-1/+2
| | | | | | | | | | | | | | | | | | | | Timeout#unref() call returns undefined, not this. The test already worked before, because the interval was still unref'd, and the test also succeeds without clearing the interval. PR-URL: https://github.com/joyent/node/pull/9171 Reviewed-by: Colin Ihrig <cjihrig@gmail.com> Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
* | doc: grammar fix in smallocDebjeet Biswas2015-02-111-1/+1
| | | | | | | | | | PR-URL: https://github.com/joyent/node/pull/9164 Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
* | lib: fix max size check in Buffer constructorBen Noordhuis2015-02-102-3/+10
| | | | | | | | | | | | | | | | | | | | | | A number -> uint32 type coercion bug made buffer sizes larger than kMaxLength (0x3fffffff) wrap around. Instead of rejecting the requested size with an exception, the constructor created a buffer with the wrong size. PR-URL: https://github.com/iojs/io.js/pull/657 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* | asyncwrap: fix constructor condition for early retTrevor Norris2015-02-094-1/+18
| | | | | | | | | | | | | | | | | | | | AsyncWrap should always properly propagate asynchronous calls to any child that is created. Regardless whether kCallInitHook is currently active. The previous logic would always return early if kCallInitHook wasn't set. PR-URL: https://github.com/joyent/node/pull/9146 Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
* | Now working on 0.12.1Julien Gilli2015-02-061-2/+2
| |
* | Merge branch 'v0.12.0-release' into v0.12Julien Gilli2015-02-062-2/+9
|\ \
| * | 2015.02.06, Version 0.12.0 (Stable)v0.12.0v0.12.0-releaseJulien Gilli2015-02-062-2/+9
|/ / | | | | | | | | | | * npm: Upgrade to 2.5.1 * mdb_v8: update for v0.12 (Dave Pacheco)
* | deps: upgrade npm to 2.5.1Forrest L Norvell2015-02-06514-12460/+14685
| | | | | | | | | | | | | | Fixes #9126. Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
* | Now working on 0.12.0Julien Gilli2015-02-051-2/+2
| |
* | tools: improve tooling around AUTHORS fileJulien Gilli2015-02-055-595/+961
| | | | | | | | | | | | | | | | | | | | | | Replace tools/updateAuthors.awk with tools/update-authors.js. The new tool generates an AUTHORS file that is stable-ordered alphanumerically. Fixes #9077. PR: #9088 PR-URL: https://github.com/joyent/node/pull/9088 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | mdb_v8: fix symbols not loaded properlyJulien Gilli2015-02-052-7/+29
| | | | | | | | | | | | | | | | V8_CONSTANT_REMOVED_SINCE(major, minor) can be used to mark a constant has being removed from V8 since V8 version major.minor. Reviewed-By: Dave Pacheco <dap@joyent.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | mdb_v8: add tests for ::findjsobjects -k KINDJulien Gilli2015-02-052-0/+43
| | | | | | | | | | Reviewed-By: Dave Pacheco <dap@joyent.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | mdb_v8: update for v0.12Dave Pacheco2015-02-057-219/+1523
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bugs fixed: * v0.12 and later: in-object properties not printing correctly. * 64-bit: not printing external strings correctly (offset was hardcoded for 32-bit). This would happen with "::jsstack -vn0" because the script "node.js" wasn't printed correctly, at least with 0.10 core files. * 64-bit: printing JS source (via "::jsstack -v") emits errors and shows the wrong code. * Several build warnings. * Two-byte strings are unnecessarily truncated. * Could print friendlier note when given obviously bogus function token positions. New features: * ::jsstack prints much cleaner output by default. * ::jsprint keys are now quoted. * ::jsstack -v includes "this" value for each function on the stack. * ::jsstack -v includes more details about each argument (constructor names for each object). * new commands: ::jsconstructor, ::jsfunctions, ::jssource, ::nodebuffer and ::v8internal. * ::findjsobjects and ::jsprint hidden flags for developers to measure and improve test coverage. * internal jsobj_properties() function is much better documented. Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | Now working on 0.11.17Julien Gilli2015-01-301-2/+2
| |
* | Merge branch 'v0.11.16-release' into v0.12Julien Gilli2015-01-302-1/+16
|\ \
| * | 2015.01.29, Version 0.11.16 (Unstable)v0.11.16v0.11.16-releaseJulien Gilli2015-01-292-1/+16
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | * openssl: Upgrade to 1.0.1l * npm: Upgrade to 2.3.0 * url: revert support of `path` for url.format" (Julien Gilli) * assert: use util.inspect() to create error messages (cjihrig) * net: throw on invalid socket timeouts (cjihrig) * url: fix parsing of ssh urls (Evan Lucas)
* | src: make build pass with GCC < 4.5Julien Gilli2015-01-299-8/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Building node with GCC > 4.4 on CentOS makes the node binary depend on a more recent version of the C/C++ runtime that is not installed by default on these older CentOS platforms, and probably on other platforms as well. Building node with the default gcc and g++ compilers that come with these older versions of CentOS allows to ship a node binary that runs out of the box on these setups with older C/C++ runtimes. This change works around a bug that was fixed in GCC 4.5. Versions of GCC < 4.5 would not support using the injected-class-name of a template base class as a type name. This change also disables aliasing optimizations for toolchains using GCC <= 4.4 as they're not able to deal with the aliasing in the queue implementation used by libuv and node (see src/queue.h). Fixes #9079. PR: #9098 PR-URL: https://github.com/joyent/node/pull/9098 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* | assert: use util.inspect() to create error messagescjihrig2015-01-292-28/+19
| | | | | | | | | | | | | | | | | | | | | | | | Currently, JSON.stringify() is used to create error messages on failed assertions. This causes an error when stringifying objects with circular references. This commit switches out JSON.stringify() for util.inspect(), which can handle circular references. PR: #8734 PR-URL: https://github.com/joyent/node/pull/8734 Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
* | Revert "url: support `path` for url.format"Julien Gilli2015-01-293-100/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d312b6d15c69cf4c438ed7d884e6396c481a57f6. d312b6d15c69cf4c438ed7d884e6396c481a57f6 introduced some confusion in the existing API of url.format and url.parse. The way the 'path' property overrides other properties in url.format's input is too confusing for existing users compared to the issues it fixes. Fixes such as https://github.com/joyent/node/pull/9081 have been proposed, but they do not make the API less confusing. Instead, this change just reverts the original breaking change so that it gives us more time after v0.12.0 is released to come up with a better API for url.format, url.parse and other related APIs in the v0.13 development branch. Fixes #9070. Conflicts: doc/api/url.markdown PR: #9109 PR-URL: https://github.com/joyent/node/pull/9109 Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | deps: upgrade npm to 2.3.0Forrest L Norvell2015-01-27705-8490/+30689
| | | | | | | | | | | | | | PR: #9086 PR-URL: https://github.com/joyent/node/pull/9086 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
* | build: enable small-icu support for build-releaseJulien Gilli2015-01-261-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Windows, when building the "build-release" rule, enable both small-icu and download-all. This change also slightly refactors the build-release rule, mainly so that it's easier to read. The resulting MSI package was tested on Windows 7. Fixes #9099. PR: #9100 PR-URL: https://github.com/joyent/node/pull/9100 Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
View Lorry Controller Status