string_bytes: strip padding from base64 strings

Because of variations in different base64 implementation, it's been
decided to strip all padding from the end of a base64 string and
calculate its size from that.

1 files changed, 4 insertions, 0 deletions

diff --git a/test/simple/test-buffer.js b/test/simple/test-buffer.js
index 20a6bdba9..3808442ad 100644
--- a/test/simple/test-buffer.js
+++ b/test/simple/test-buffer.js
@@ -980,6 +980,10 @@ assert.throws(function() {
   }
 })();
 
+// Make sure byteLength properly checks for base64 padding
+assert.equal(Buffer.byteLength('aaa=', 'base64'), 2);
+assert.equal(Buffer.byteLength('aaaa==', 'base64'), 3);
+
 // Regression test for #5482: should throw but not assert in C++ land.
 assert.throws(function() {
   Buffer('', 'buffer');