Fix #3242 Actually deprecate 'binary' buffer encoding

1 files changed, 9 insertions, 7 deletions

diff --git a/src/node.cc b/src/node.cc
index 9b0e7cbeb..5afeb55fa 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -1104,16 +1104,18 @@ enum encoding ParseEncoding(Handle<Value> encoding_v, enum encoding _default) {
   } else if (strcasecmp(*encoding, "ucs-2") == 0) {
     return UCS2;
   } else if (strcasecmp(*encoding, "binary") == 0) {
+    fprintf(stderr, "The 'binary' buffer encoding is deprecated. "
+                    "Use a Buffer object directly.\n");
     return BINARY;
   } else if (strcasecmp(*encoding, "hex") == 0) {
     return HEX;
   } else if (strcasecmp(*encoding, "raw") == 0) {
     fprintf(stderr, "'raw' (array of integers) has been removed. "
-                    "Use 'binary'.\n");
+                    "Use a Buffer object directly.\n");
     return BINARY;
   } else if (strcasecmp(*encoding, "raws") == 0) {
-    fprintf(stderr, "'raws' encoding has been renamed to 'binary'. "
-                    "Please update your code.\n");
+    fprintf(stderr, "'raws' (array of integers) has been removed. "
+                    "Use a Buffer object directly.\n");
     return BINARY;
   } else {
     return _default;
@@ -1147,8 +1149,8 @@ ssize_t DecodeBytes(v8::Handle<v8::Value> val, enum encoding encoding) {
   HandleScope scope;
 
   if (val->IsArray()) {
-    fprintf(stderr, "'raw' encoding (array of integers) has been removed. "
-                    "Use 'binary'.\n");
+    fprintf(stderr, "'raw' (array of integers) has been removed. "
+                    "Use a Buffer object directly.\n");
     assert(0);
     return -1;
   }
@@ -1184,8 +1186,8 @@ ssize_t DecodeWrite(char *buf,
   // http://groups.google.com/group/v8-users/browse_thread/thread/1f83b0ba1f0a611
 
   if (val->IsArray()) {
-    fprintf(stderr, "'raw' encoding (array of integers) has been removed. "
-                    "Use 'binary'.\n");
+    fprintf(stderr, "'raw' (array of integers) has been removed. "
+                    "Use a Buffer object directly.\n");
     assert(0);
     return -1;
   }