diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2012-03-09 06:35:50 -0800 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2012-03-09 23:57:03 +0100 |
| commit | 8c02f9b7c844909cf5977d065b793c99eb0f9c45 (patch) | |
| tree | 502f4d08b899802c99ae30b07ffc945f7ee71b74 /src/node_buffer.h | |
| parent | 2589d5561191ac58f5c87efa796457c9936de73f (diff) | |
| download | node-8c02f9b7c844909cf5977d065b793c99eb0f9c45.tar.gz | |
buffer: throw from constructor if length > kMaxLength
Throw, don't abort. `new Buffer(0x3fffffff + 1)` used to bring down the process
with the following error message:
FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length
exceeds max acceptable value
Fixes #2280.
Diffstat (limited to 'src/node_buffer.h')
| -rw-r--r-- | src/node_buffer.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/node_buffer.h b/src/node_buffer.h index ef7cf4fd8..abfafa326 100644 --- a/src/node_buffer.h +++ b/src/node_buffer.h @@ -65,6 +65,9 @@ namespace node { class NODE_EXTERN Buffer: public ObjectWrap { public: + // mirrors deps/v8/src/objects.h + static const int kMaxLength = 0x3fffffff; + static v8::Persistent<v8::FunctionTemplate> constructor_template; static bool HasInstance(v8::Handle<v8::Value> val); |