Wrap uv_pipe_open, implement net.Stream(fd);

Fixes simple/test-child-process-ipc on unix.

1 files changed, 15 insertions, 12 deletions

diff --git a/lib/net_uv.js b/lib/net_uv.js
index 97470f825..dddc03fcb 100644
--- a/lib/net_uv.js
+++ b/lib/net_uv.js
@@ -78,21 +78,24 @@ function Socket(options) {
   stream.Stream.call(this);
 
   if (typeof options == 'number') {
-    // Legacy interface. Uncomment the following lines after
-    // libuv backend is stable and API compatibile with legaacy.
-    //   console.error('Deprecated interface net.Socket(fd).');
-    //   console.trace();
+    // Legacy interface.
     // Must support legacy interface. NPM depends on it.
     // https://github.com/isaacs/npm/blob/c7824f412f0cb59d6f55cf0bc220253c39e6029f/lib/utils/output.js#L110
-    // TODO Before we can do this we need a way to open a uv_stream_t by fd.
-    throw new Error("Not yet implemented")
-  }
+    var fd = options;
 
-  // private
-  this._handle = options && options.handle;
-  initSocketHandle(this);
-
-  this.allowHalfOpen = options && options.allowHalfOpen;
+    // Uncomment the following lines after libuv backend is stable and API
+    // compatibile with legaacy.
+    //   console.error('Deprecated interface net.Socket(fd).');
+    //   console.trace();
+    this._handle = createPipe();
+    this._handle.open(fd);
+    initSocketHandle(this);
+  } else {
+    // private
+    this._handle = options && options.handle;
+    initSocketHandle(this);
+    this.allowHalfOpen = options && options.allowHalfOpen;
+  }
 }
 util.inherits(Socket, stream.Stream);