summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFedor Indutny <fedor.indutny@gmail.com>2014-02-08 02:15:33 +0400
committerFedor Indutny <fedor.indutny@gmail.com>2014-02-08 02:15:33 +0400
commitd10a68736d338ea1d673f3f8bd410868b73318e2 (patch)
treef8c42473d31b83050ece5975ceed70d8bb5e2b3d
parent96379f83e0f649090caf15e8a6e016491aeca776 (diff)
downloadnode-d10a68736d338ea1d673f3f8bd410868b73318e2.tar.gz
Revert "dns: validate arguments in resolve"
This reverts commit 56e80a37e0df0d131d3a3ad6426d52f887ef8e94.
-rw-r--r--lib/dns.js5
-rw-r--r--test/simple/test-dns-regress-7070.js27
2 files changed, 0 insertions, 32 deletions
diff --git a/lib/dns.js b/lib/dns.js
index 15ee6a436..10214790d 100644
--- a/lib/dns.js
+++ b/lib/dns.js
@@ -146,11 +146,6 @@ function resolver(bindingName) {
if (!status) {
callback(null, result);
} else {
- if (!util.isString(name))
- throw new Error('Name must be a string')
- else if (!util.isFunction(callback))
- throw new Error('Callback must be a function')
-
callback(errnoException(process._errno, bindingName));
}
}
diff --git a/test/simple/test-dns-regress-7070.js b/test/simple/test-dns-regress-7070.js
deleted file mode 100644
index 849743a82..000000000
--- a/test/simple/test-dns-regress-7070.js
+++ /dev/null
@@ -1,27 +0,0 @@
-// Copyright Joyent, Inc. and other Node contributors.
-//
-// Permission is hereby granted, free of charge, to any person obtaining a
-// copy of this software and associated documentation files (the
-// "Software"), to deal in the Software without restriction, including
-// without limitation the rights to use, copy, modify, merge, publish,
-// distribute, sublicense, and/or sell copies of the Software, and to permit
-// persons to whom the Software is furnished to do so, subject to the
-// following conditions:
-//
-// The above copyright notice and this permission notice shall be included
-// in all copies or substantial portions of the Software.
-//
-// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
-// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
-// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
-// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
-// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
-// USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-var common = require('../common');
-var dns = require('dns');
-
-// Should not raise assertion error. Issue #7070
-assert.throws(function () { dns.resolveNs([]) }); // bad name
-assert.throws(function () { dns.resolveNs("") }); // bad callback