diff options
| author | Ojas Shirekar <ojas.shirekar@gmail.com> | 2016-09-23 20:01:04 +0530 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2016-10-07 00:57:35 +0200 |
| commit | 2154bc89d8ea16be90e14ff313c4bbcf7443472f (patch) | |
| tree | 3cf57b19cf6514e75fc658d394e86e55febfd5ba /test/parallel/test-buffer-sharedarraybuffer.js | |
| parent | 647e8e5ae4bb60a62767f5af1806a17a5ddf7c2b (diff) | |
| download | node-new-2154bc89d8ea16be90e14ff313c4bbcf7443472f.tar.gz | |
buffer: fix check for `.buffer` property
isSharedArrayBuffer in fromObject was missing obj.buffer
moved the 'length' in obj check so that it is checked first making
the code slightly more performant and able to handle SharedArrayBuffer
without relying on an explicit check.
Ref: https://github.com/nodejs/node/pull/8510
PR-URL: https://github.com/nodejs/node/pull/8739
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-buffer-sharedarraybuffer.js')
| -rw-r--r-- | test/parallel/test-buffer-sharedarraybuffer.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/parallel/test-buffer-sharedarraybuffer.js b/test/parallel/test-buffer-sharedarraybuffer.js index 47b3a59b86..f1bac72079 100644 --- a/test/parallel/test-buffer-sharedarraybuffer.js +++ b/test/parallel/test-buffer-sharedarraybuffer.js @@ -27,3 +27,5 @@ assert.deepStrictEqual(arr_buf, ar_buf, 0); // Checks for calling Buffer.byteLength on a SharedArrayBuffer assert.strictEqual(Buffer.byteLength(sab), sab.byteLength, 0); + +assert.doesNotThrow(() => Buffer.from({buffer: sab})); |