diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-03-18 13:30:21 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-22 00:45:48 +0100 |
| commit | bca23f2ee71ddaf4f4393652de75dbb7fbc27f1d (patch) | |
| tree | f41078894ea2494fa1a3d29a3a2b3ad09ea54a6c /src/api/callback.cc | |
| parent | d812dbb495a2471f7835c330b49c1d8f3fa8e5c2 (diff) | |
| download | node-new-bca23f2ee71ddaf4f4393652de75dbb7fbc27f1d.tar.gz | |
src: only open HandleScope when necessary
PR-URL: https://github.com/nodejs/node/pull/26734
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'src/api/callback.cc')
| -rw-r--r-- | src/api/callback.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/api/callback.cc b/src/api/callback.cc index b90f5ca92d..47a1549e93 100644 --- a/src/api/callback.cc +++ b/src/api/callback.cc @@ -79,7 +79,6 @@ InternalCallbackScope::~InternalCallbackScope() { void InternalCallbackScope::Close() { if (closed_) return; closed_ = true; - HandleScope handle_scope(env_->isolate()); if (!env_->can_call_into_js()) return; if (failed_ && !env_->is_main_thread() && env_->is_stopping()) { @@ -117,6 +116,7 @@ void InternalCallbackScope::Close() { return; } + HandleScope handle_scope(env_->isolate()); Local<Object> process = env_->process_object(); if (!env_->can_call_into_js()) return; |