diff options
| author | Richard Lau <riclau@uk.ibm.com> | 2020-05-11 10:28:51 -0400 |
|---|---|---|
| committer | Richard Lau <riclau@uk.ibm.com> | 2020-05-13 12:07:33 -0400 |
| commit | fcc183c99413750b1b965e45cb42a1af73da47ab (patch) | |
| tree | 1af544b283bee8ac9f08f6ab4e3859a369ec470d | |
| parent | 3aa515210afaefcf99b3f4ad49239fc5738ef58d (diff) | |
| download | node-new-fcc183c99413750b1b965e45cb42a1af73da47ab.tar.gz | |
build: enable `--error-on-warn` for POSIX workflows
Treat warnings as errors for non-deps code on Linux and macOS workflows.
Signed-off-by: Richard Lau <riclau@uk.ibm.com>
PR-URL: https://github.com/nodejs/node/pull/33357
Refs: https://github.com/nodejs/node/pull/32685
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
| -rw-r--r-- | .github/workflows/test-linux.yml | 2 | ||||
| -rw-r--r-- | .github/workflows/test-macos.yml | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/.github/workflows/test-linux.yml b/.github/workflows/test-linux.yml index 4b0bc052f0..cfe0ca4ab7 100644 --- a/.github/workflows/test-linux.yml +++ b/.github/workflows/test-linux.yml @@ -18,6 +18,6 @@ jobs: - name: Environment Information run: npx envinfo - name: Build - run: make build-ci -j2 V=1 + run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn" - name: Test run: make run-ci -j2 V=1 TEST_CI_ARGS="-p dots" diff --git a/.github/workflows/test-macos.yml b/.github/workflows/test-macos.yml index 8bb0ab6d71..c78ab45e4b 100644 --- a/.github/workflows/test-macos.yml +++ b/.github/workflows/test-macos.yml @@ -18,6 +18,6 @@ jobs: - name: Environment Information run: npx envinfo - name: Build - run: make build-ci -j8 V=1 + run: make build-ci -j8 V=1 CONFIG_FLAGS="--error-on-warn" - name: Test run: make run-ci -j8 V=1 TEST_CI_ARGS="-p dots" |