| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
This is common good practice, otherwise it's not clear who has
ownership, making it error prone for dangling pointers (this case)
or use after free.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
We were using gchar* for uris, instead of actual files, and converting
back and forward.
Instead use directly nautilus files.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were using the view as the destination for compression and
decompression.
However, the parent of the files is not always the view. This is the
case in list view when the "allow expand folder" setting is set and the
selection is different than the root location of the view.
To fix it, use a parent of one of the selected files, we assume all
files has the same parent.
https://bugzilla.gnome.org/show_bug.cgi?id=771470
|
|
|
|
|
|
|
|
|
|
|
| |
We weren't checking if there is some file selected to enable/disable
the compress action, which was causing the context menu item be always
displayed if we clicked an element that is not a file.
As odd as it sounds, this happens when allow to expand folders in list
view, since the "empty" element is selectable but not a file.
To fix that, check whether we have a file selected or not.
https://bugzilla.gnome.org/show_bug.cgi?id=771469
|
| |
|
| |
|
|
|
|
|
| |
We need at least 3.21.6 for GtkScrolledWindow.propagate-natural-height
since 2f878b79c43676eef37e00a1e1d4b1572d2cf341
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a tag is added, deleted or moved or a text is changed, inserted
or deleted, we need to do update the text and tags already present
based on what changed.
We were checking whether a tag was present or not matching with the
text rather than deterministically adding, removing or updating the
positions based on the direct user interaction.
Doing it in this way is a potential problem since two tags added
writing manually would confuse the underlying handling, apart of being
harder to have a consistent state of the tags like deleting multiple
tags at once, deleting tags with text on the sides when selected,
replacing tags with text, crashes when using overwrite mode instead of
insertion mode, or crashes when using modifiers. Apart of making the
handling more complex.
This patch refactors the tag handling for using positions and direct
manipulation of them instead of text.
https://bugzilla.gnome.org/show_bug.cgi?id=771069
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
|
|
|
|
|
| |
A translator modified that. I guess we need to be more careful
with these situations.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have a compile option to not use tracker. Batch renaming relies on
tracker for part of its functionality, and disabling that would mess the
code with ifdefs.
I think doesn't make much sense to have a compile time switch for
tracker anymore (tracker can still be disabled in runtime and it's fine)
so I would like to remove that switch.
Since it's late in the cycle, better to not do that, but let's try for
next release. For now just make the batch-renaming disabled in case
the compilation was done without tracker.
https://bugzilla.gnome.org/show_bug.cgi?id=771158
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Since there are few apps that are using it.
https://bugzilla.gnome.org/show_bug.cgi?id=771051
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a refactoring that is difficult to split in several pieces.
This patch implements the following changes:
- Use loops instead of serie of if/elses.
- Use enums and static arrays to define a static serie of tag types
and properties.
- Use enums for ordering and retrieval of properties of tags instead of
searching.
- Merge common code.
- Extract common code in functions.
- Mark for translation some strings.
- Plug some leaks.
- Fix some free-after-free.
- Fix issue with condition for unavailable metadata, that was
exacerbated with this refactoring.
https://bugzilla.gnome.org/show_bug.cgi?id=770586
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=770586
|
|
|
|
|
|
|
| |
We were doing the same for several items. Use and array and a for
to iterate on them.
https://bugzilla.gnome.org/show_bug.cgi?id=770586
|
| |
|
|
|
|
| |
Signed-off-by: Trần Ngọc Quân <vnwildman@gmail.com>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|