Added todo item to point out the somewhat tricky fact about snprintf's

return value.

1 files changed, 7 insertions, 0 deletions

diff --git a/disasm.c b/disasm.c
index 79837114..dd806d6f 100644
--- a/disasm.c
+++ b/disasm.c
@@ -582,6 +582,13 @@ long disasm (unsigned char *data, char *output, int outbufsize, int segsize,
 
     slen = 0;
 
+    /* TODO: snprintf returns the value that the string would have if
+    *	    the buffer were long enough, and not the actual length of 
+    *	    the returned string, so each instance of using the return
+    *	    value of snprintf should actually be checked to assure that
+    *	    the return value is "sane."  Maybe a macro wrapper could
+    *	    be used for that purpose.
+    */
     if (lock)
 	slen += snprintf(output+slen, outbufsize-slen, "lock ");
     for (i = 0; i < ins.nprefix; i++)