diff options
| author | Florian Müllner <fmuellner@gnome.org> | 2018-10-09 00:40:33 +0200 |
|---|---|---|
| committer | Ray Strode <rstrode@redhat.com> | 2019-01-14 10:06:51 -0500 |
| commit | e3d7b3828e71739e86b1d30838a7fd579d17aa98 (patch) | |
| tree | 94eb982e00d5bb3717eac801c5195f78d220eef0 | |
| parent | 6e14403ac837a67f2b5bf05916ddeb60a0bddf1c (diff) | |
| download | mutter-e3d7b3828e71739e86b1d30838a7fd579d17aa98.tar.gz | |
x11/window-props: Do not convert WM_NAME
The WM_NAME property is of type TEXT_PROPERTY, which is supposed to be
returned as UTF-8. Commit 840378ae68 broke that assumption, resulting
in crashes with non-UTF8 locales; however the "fix" of converting from
LATIN1 to UTF8 is wrong as well, as the conversion will spit out garbage
when the input encoding isn't actually LATIN1.
Now that the original issue in text_property_to_utf8() has been fixed,
we can simply revert the relevant bits of commit d62491f46eba748e.
https://gitlab.gnome.org/GNOME/mutter/merge_requests/227
| -rw-r--r-- | src/x11/window-props.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/x11/window-props.c b/src/x11/window-props.c index 2f4dfeb31..7c6b25fdb 100644 --- a/src/x11/window-props.c +++ b/src/x11/window-props.c @@ -645,10 +645,7 @@ reload_wm_name (MetaWindow *window, if (value->type != META_PROP_VALUE_INVALID) { - g_autofree gchar *title = g_convert (value->v.str, -1, - "UTF-8", "LATIN1", - NULL, NULL, NULL); - set_window_title (window, title); + set_window_title (window, value->v.str); meta_verbose ("Using WM_NAME for new title of %s: \"%s\"\n", window->desc, window->title); |