diff options
| author | Nirbheek Chauhan <nirbheek@centricular.com> | 2018-04-13 14:22:02 +0530 |
|---|---|---|
| committer | Nirbheek Chauhan <nirbheek@centricular.com> | 2018-04-13 17:30:07 +0530 |
| commit | ce9b13afd085e94a76c225d7b05f28664db41043 (patch) | |
| tree | 1c08bccf6203212d5247167b8952e3f383ac1a02 /mesonbuild/backend/backends.py | |
| parent | cb597adb0170a4818a4950ca9a4fe3f6d5a6c9d2 (diff) | |
| download | meson-nirbheek/remove-custom-target-backslashes-hack.tar.gz | |
custom targets: Don't replace \\ with /nirbheek/remove-custom-target-backslashes-hack
This is no longer required since we always use `/` as the path
separator for file arguments on Windows now. The only effect this
now has is to mangle the string args people pass to custom targets.
Closes https://github.com/mesonbuild/meson/issues/1564
Diffstat (limited to 'mesonbuild/backend/backends.py')
| -rw-r--r-- | mesonbuild/backend/backends.py | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/mesonbuild/backend/backends.py b/mesonbuild/backend/backends.py index 916f68099..5c5bcb4b9 100644 --- a/mesonbuild/backend/backends.py +++ b/mesonbuild/backend/backends.py @@ -839,25 +839,6 @@ class Backend: # Substitute the rest of the template strings values = mesonlib.get_filenames_templates_dict(inputs, outputs) cmd = mesonlib.substitute_values(cmd, values) - # This should not be necessary but removing it breaks - # building GStreamer on Windows. The underlying issue - # is problems with quoting backslashes on Windows - # which is the seventh circle of hell. The downside is - # that this breaks custom targets whose command lines - # have backslashes. If you try to fix this be sure to - # check that it does not break GST. - # - # The bug causes file paths such as c:\foo to get escaped - # into c:\\foo. - # - # Unfortunately we have not been able to come up with an - # isolated test case for this so unless you manage to come up - # with one, the only way is to test the building with Gst's - # setup. Note this in your MR or ping us and we will get it - # fixed. - # - # https://github.com/mesonbuild/meson/pull/737 - cmd = [i.replace('\\', '/') for i in cmd] return inputs, outputs, cmd def run_postconf_scripts(self): |