| Commit message (Collapse) | Author | Age | Files | Lines |
| | |
|
| |
|
|
|
| |
(dustin) I made some changes to the original growth code to pass in
the required size.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
accepting_conns for completeness, and listen_disabled_num to see how many
times you've hit maxconns and disabled incoming connections. probably a good
stat to monitor and flip out on.
|
| |
|
|
|
|
|
| |
shouldn't add much lock contention for just this.
I want to add this one stat (mayb a few more?) since it's happened more than
once that folks think memcached is broken when a cron or something is calling
'flush_all' once a minute.
|
| |
|
|
|
|
|
|
|
| |
AF_UNSPEC is still necessary for UDP sometimes.
We guarantee that at least one address returned from getaddrinfo binds
successfully, and in cases of lacking network or ipv6 addresses some of those
socket() calls might fail. That's normal. We were bailing on them.
This change also removes the need to pass AI_ADDRCONFIG on machines with ipv6
stacks disabled.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
See: http://code.google.com/p/memcached/issues/detail?id=22
|
| |
|
|
| |
http://code.google.com/p/memcached/issues/detail?id=36
|
| |
|
|
| |
See: http://code.google.com/p/memcached/issues/detail?id=33
|
| |
|
|
|
| |
Using the settings stats, we can verify the startup effects -C and -b:
bring and validate that they were both broken by a recent change.
|
| |
|
|
|
|
| |
Stats settings gives a dump of the overall settings of the server.
This is useful for verifying the effect of commandline parameters as
well as helping others debug odd behaviors.
|
| |
|
|
| |
Thanks to Toru for pointing this out.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This makes it so that it is a little bit easier to see what parameter
goes to what, and to make merges with different paramenters a bit
easier to manage.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I couldn't figure out how to get the stats output big enough to exceed
1024, but I accept it might.
I've given it a bit more space here and added an assertion to detect
when we fail in case we can figure out how to actually have this occur.
Maxing out pretty much everything got me up to 828 bytes:
STAT pid 35893
STAT uptime 152
STAT time 1237000260
STAT version 1.3.2
STAT pointer_size 32
STAT rusage_user 0.002487
STAT rusage_system 0.005412
STAT curr_connections 4
STAT total_connections 5
STAT connection_structures 5
STAT cmd_get 18446744073709551610
STAT cmd_set 18446744073709551610
STAT get_hits 18446744073709551610
STAT get_misses 18446744073709551610
STAT delete_misses 18446744073709551610
STAT delete_hits 18446744073709551610
STAT incr_misses 18446744073709551610
STAT incr_hits 18446744073709551610
STAT decr_misses 18446744073709551610
STAT decr_hits 18446744073709551610
STAT cas_misses 18446744073709551610
STAT cas_hits 18446744073709551610
STAT cas_badval 18446744073709551610
STAT bytes_read 1
STAT bytes_written 18446744073709551610
STAT limit_maxbytes 67108864
STAT threads 5
STAT bytes 18446744073709551610
STAT curr_items 4294967290
STAT total_items 4294967290
STAT evictions 18446744073709551610
|
| |
|
|
| |
See http://code.google.com/p/memcached/issues/detail?id=26
|
| |
|
|
| |
316 -> 312
|
| |
|
|
| |
initialized....)
|
| |
|
|
|
|
|
|
|
|
| |
There was apparently some issue on OS X 10.5 that led to the
introduction of this limitation, but it's not clear what the issue
was, and all tests pass on OS X 10.5 for me.
Assuming we find out what the cause of this issue is, we'll add tests
and sure they work fine on all platforms with no (or minimal) loss of
functionality.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
CAS stats break down into three different types:
* CAS misses (non-existent key)
* CAS hits (key + CAS ID match)
* CAS badval (key + CAS ID mismatch)
hits and bad-val are slab-specific stats. Specifically, they are
both based on the slab ID of the original item (the one being
replaced).
|
| | |
|
| |
|
|
| |
This includes both misses and per-slab hits.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
This makes running on Linux when disconnected possible.
Tests still fail when using the -l option to specify a binding address
while offline. This is probably quite unlikely if it weren't for the
first test.
|
| |
|
|
|
| |
Some strange signness handling around decr caused values that would be
signed 64-bit numbers to get dropped to zero.
|
| | |
|
| |
|
|
|
| |
If we daemonize before we try to setuid, we can't properly report a
setuid failure.
|
| |
|
|
|
|
| |
In this case, default means "NOT_STORED". Now that these are enums,
gcc will fail to compile the switch if a possibility is omitted. A
compile failure is much better than runtime weirdness.
|
| | |
|
| |
|
|
|
| |
The default was the bigger issue. Defaulting to NOT_STORED is
probably OK, but if a new storage type comes up, I'd rather see failures.
|
| |
|
|
|
| |
I saw some stuff like "stored = 3" and realized I had no idea what any
of these things actually meant.
|
| |
|
|
| |
http://code.google.com/p/memcached/issues/detail?id=18
|
| |
|
|
|
|
|
|
| |
This effectively exempted anything that was ever referenced in a
binary get from freeing, leading to the evil out of memory exceptions
that one should never see in a cache with an LRU.
http://code.google.com/p/memcached/issues/detail?id=16
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Victor found the bug and submitted a bunch of text, I just committed
it -- Dustin)
Unclear why this exists in the first place (history doesn't show
anything significant), but at some point after it was written, it
became wrong.
As this is a local variable and is not read after this memset and the
memset is wrong, I'm taking Victor's path of just removing it.
http://code.google.com/p/memcached/issues/detail?id=19
Signed-off-by: Dustin Sallings <dustin@spy.net>
|
| |
|
|
|
|
|
|
| |
This should not be used generally, but it assumes all of the keys are
null terminated.
This change copies all the keys for null-termination (making the
process even slower), but is at least somewhat safer.
|
| |
|
|
|
|
|
|
| |
This fixes a problem reported as bug 15 where incr and decr do not
change CAS values when they aren't completely replacing the item
(which is the typical case).
http://code.google.com/p/memcached/issues/detail?id=15
|
| |
|
|
| |
an unsigned int is always >= 0
|