summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJes Sorensen <Jes.Sorensen@redhat.com>2012-03-21 08:00:26 +1100
committerNeilBrown <neilb@suse.de>2012-03-21 08:00:26 +1100
commit1afa9308d2fdc889ab7847ddc9a9aa05ce1e5faa (patch)
treef02c203e9b782d4aa69ba4e8ed270e0184ad4516
parent4122675629c683fc8e0e3ed400107b6e27f9eac7 (diff)
downloadmdadm-1afa9308d2fdc889ab7847ddc9a9aa05ce1e5faa.tar.gz
init_super1() memset full buffer allocated for superblock
Avoid possibly using stale data in bitmap and misc area of superblock. In addition, remove superfluous memsets already covered by memset of full superblock. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: NeilBrown <neilb@suse.de>
-rw-r--r--super1.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/super1.c b/super1.c
index f165f59..4da5991 100644
--- a/super1.c
+++ b/super1.c
@@ -848,7 +848,7 @@ static int init_super1(struct supertype *st, mdu_array_info_t *info,
": %s could not allocate superblock\n", __func__);
return 0;
}
- memset(sb, 0, MAX_SB_SIZE);
+ memset(sb, 0, SUPER1_SIZE);
st->sb = sb;
if (info == NULL) {
@@ -883,7 +883,6 @@ static int init_super1(struct supertype *st, mdu_array_info_t *info,
sprintf(defname, "%d", info->md_minor);
name = defname;
}
- memset(sb->set_name, 0, 32);
if (homehost &&
strchr(name, ':')== NULL &&
strlen(homehost)+1+strlen(name) < 32) {